[Discover] [Bug 484714] Discover crashes on launch in PackageKitDependencies::dependencies() when opened with an appstream:// URI

2024-04-01 Thread Harald Sitter
https://bugs.kde.org/show_bug.cgi?id=484714

Harald Sitter  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/plas
   ||ma/discover/-/commit/0d16b2
   ||1156263e5449c51afa5556969f2
   ||97e87e0
 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

--- Comment #5 from Harald Sitter  ---
Git commit 0d16b21156263e5449c51afa5556969f297e87e0 by Harald Sitter.
Committed on 31/03/2024 at 05:00.
Pushed by sitter into branch 'master'.

packagekit: disarm dependencies start assertion

since we have disabled dependency listing for installed software
start() isn't necessarily called before dependencies() anymore.
remove the assertion and instead return early

M  +3-1   
libdiscover/backends/PackageKitBackend/PackageKitDependencies.cpp

https://invent.kde.org/plasma/discover/-/commit/0d16b21156263e5449c51afa5556969f297e87e0

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 484714] Discover crashes on launch in PackageKitDependencies::dependencies() when opened with an appstream:// URI

2024-03-30 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=484714

Bug Janitor Service  changed:

   What|Removed |Added

 Status|CONFIRMED   |ASSIGNED

--- Comment #4 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/plasma/discover/-/merge_requests/809

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 484714] Discover crashes on launch in PackageKitDependencies::dependencies() when opened with an appstream:// URI

2024-03-29 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=484714

Nate Graham  changed:

   What|Removed |Added

   Priority|VHI |HI

--- Comment #3 from Nate Graham  ---
The commit that causes it was cherry-picked to the stable branch, so in
principle it could.

But to be sure, I just built Discover from the stable branch and indeed, it
doesn't crash there. So the issue seems to be master-only at this point;
lowering the severity.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 484714] Discover crashes on launch in PackageKitDependencies::dependencies() when opened with an appstream:// URI

2024-03-29 Thread Harald Sitter
https://bugs.kde.org/show_bug.cgi?id=484714

--- Comment #2 from Harald Sitter  ---
That crash cannot happen in 6.0, can it?

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 484714] Discover crashes on launch in PackageKitDependencies::dependencies() when opened with an appstream:// URI

2024-03-29 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=484714

Nate Graham  changed:

   What|Removed |Added

 Status|REPORTED|CONFIRMED
 Ever confirmed|0   |1
   Priority|NOR |VHI
   Assignee|plasma-b...@kde.org |sit...@kde.org

--- Comment #1 from Nate Graham  ---
`git bisect` shows this was caused by:

commit b605a442ed23675f152b3a0706d03e739c5fd6ba
Author: Harald Sitter 
Date:   Wed Mar 27 01:02:56 2024 +0100

packagekit: only resolve dependencies for resources in None state

there is little to no meaning to be gained from knowing the dependencies
of an installed package

 libdiscover/backends/PackageKitBackend/PackageKitResource.cpp | 4 
 1 file changed, 4 insertions(+)


Harald, could you take a look? This commit was backported to the stable branch
and is at risk of being released with Plasma 6.0.4, so unfortunately it's
fairly high priority.

-- 
You are receiving this mail because:
You are watching all bug changes.