Re: Review Request 111335: Fix for one of the oldest KIO bugs: multiple dialogs when KIO encounters SSL errors

2013-07-06 Thread David Faure
On July 5, 2013, 2:23 p.m., David Faure wrote: kio/kio/scheduler.cpp, line 766 http://git.reviewboard.kde.org/r/111335/diff/2/?file=167766#file167766line766 Please don't put this code in scheduler.cpp I'm trying to properly split core and gui aspects of KIO in

Re: Review Request 111390: kshorturifilter: inverted condition in home directory handling

2013-07-06 Thread Jonathan Marten
On July 5, 2013, 2:27 p.m., David Faure wrote: Sounds like the unittest is incomplete then, if it didn't catch the error with ~ or ~user. (I don't mean testing the case where the home dir is empty, I only mean the normal case, which you say was going into an error path). Having

Re: Review Request 111390: kshorturifilter: inverted condition in home directory handling

2013-07-06 Thread David Faure
On July 5, 2013, 2:27 p.m., David Faure wrote: Sounds like the unittest is incomplete then, if it didn't catch the error with ~ or ~user. (I don't mean testing the case where the home dir is empty, I only mean the normal case, which you say was going into an error path).

Re: Review Request 111370: system_tray: initialize uninitialized members

2013-07-06 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111370/ --- (Updated July 6, 2013, 3:48 p.m.) Status -- This change has been

Re: Review Request 111370: system_tray: initialize uninitialized members

2013-07-06 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111370/#review35663 --- This review has been submitted with commit

Review Request 111419: Use case-insensitive URL scheme comparisons in KUrl::isLocalFile

2013-07-06 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111419/ --- Review request for kdelibs and David Faure. Description --- This

Re: Review Request 111419: Use case-insensitive URL scheme comparisons in KUrl::isLocalFile

2013-07-06 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111419/ --- (Updated July 6, 2013, 4:55 p.m.) Review request for kdelibs and David

Re: Review Request 111390: kshorturifilter: inverted condition in home directory handling

2013-07-06 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111390/#review35665 --- This review has been submitted with commit

Re: Review Request 111335: Fix for one of the oldest KIO bugs: multiple dialogs when KIO encounters SSL errors

2013-07-06 Thread Dawit Alemayehu
On July 5, 2013, 2:23 p.m., David Faure wrote: kio/kio/scheduler.cpp, line 766 http://git.reviewboard.kde.org/r/111335/diff/2/?file=167766#file167766line766 Please don't put this code in scheduler.cpp I'm trying to properly split core and gui aspects of KIO in

Re: Review Request 111335: Fix for one of the oldest KIO bugs: multiple dialogs when KIO encounters SSL errors

2013-07-06 Thread David Faure
On July 5, 2013, 2:23 p.m., David Faure wrote: kio/kio/scheduler.cpp, line 766 http://git.reviewboard.kde.org/r/111335/diff/2/?file=167766#file167766line766 Please don't put this code in scheduler.cpp I'm trying to properly split core and gui aspects of KIO in

Re: Review Request 111335: Fix for one of the oldest KIO bugs: multiple dialogs when KIO encounters SSL errors

2013-07-06 Thread Dawit Alemayehu
On July 5, 2013, 2:23 p.m., David Faure wrote: kio/kio/scheduler.cpp, line 766 http://git.reviewboard.kde.org/r/111335/diff/2/?file=167766#file167766line766 Please don't put this code in scheduler.cpp I'm trying to properly split core and gui aspects of KIO in