Re: Review Request 111585: Don't update clipboard before cut/paste KIO operation succeeds

2013-07-21 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111585/ --- (Updated July 21, 2013, 6:05 a.m.) Review request for kdelibs and David

Re: Proposal for branching policy towards KF5

2013-07-21 Thread Thomas Lübking
On Sonntag, 21. Juli 2013 05:04:10 CEST, Michael Pyne wrote: On Fri, July 19, 2013 00:21:21 David Faure wrote: After more live discussion with Sebas and Marco plus Aaron over a video chat, we came up with the following setup for the workspace repos (*) : Adding a similar generic selection for

Re: Proposal for branching policy towards KF5

2013-07-21 Thread Ben Cooksley
On Sun, Jul 21, 2013 at 9:13 PM, Thomas Lübking thomas.luebk...@gmail.com wrote: On Sonntag, 21. Juli 2013 05:04:10 CEST, Michael Pyne wrote: On Fri, July 19, 2013 00:21:21 David Faure wrote: After more live discussion with Sebas and Marco plus Aaron over a video chat, we came up with the

Re: Proposal for branching policy towards KF5

2013-07-21 Thread Thomas Lübking
On Sonntag, 21. Juli 2013 11:15:29 CEST, Ben Cooksley wrote: On Sun, Jul 21, 2013 at 9:13 PM, Thomas Lübking thomas.luebk...@gmail.com wrote: On Sonntag, 21. Juli 2013 05:04:10 CEST, Michael Pyne wrote: On Fri, July 19, 2013 00:21:21 David Faure wrote: ... git symbolic-ref refs/heads/NEXT

Supported Compilers / C++11 Support in KF5

2013-07-21 Thread Volker Krause
Hi, during one of the KF5 BoFs at Akademy we discussed which compilers we want to support for KF5 (for KDE PIM: s/KF5/Akonadi =1.11/). The conclusion was to do what Qt does (http://qt-project.org/doc/qt-5.0/qtdoc/platform-details.html) but ignore the older optional platforms (some of which are

Re: Proposal for branching policy towards KF5

2013-07-21 Thread Ben Cooksley
On Sun, Jul 21, 2013 at 9:54 PM, Thomas Lübking thomas.luebk...@gmail.com wrote: On Sonntag, 21. Juli 2013 11:15:29 CEST, Ben Cooksley wrote: On Sun, Jul 21, 2013 at 9:13 PM, Thomas Lübking thomas.luebk...@gmail.com wrote: On Sonntag, 21. Juli 2013 05:04:10 CEST, Michael Pyne wrote: On

Re: Supported Compilers / C++11 Support in KF5

2013-07-21 Thread Rolf Eike Beer
Volker Krause wrote: - GCC = 4.5 - override Explicit virtual overrides require g++ 4.7: http://gcc.gnu.org/projects/cxx0x.html This is trivially to work around by a CMake time check and then just define override to empty. Eike signature.asc Description: This is a digitally signed message

Re: Supported Compilers / C++11 Support in KF5

2013-07-21 Thread Ivan Čukić
This is trivially to work around by a CMake time check and then just define override to empty. Yes, similarly can be done for the nullptr. Cheerio, Ivan -- While you were hanging yourself on someone else's words Dying to believe in what you heard I was staring straight into the shining sun

Re: Supported Compilers / C++11 Support in KF5

2013-07-21 Thread Volker Krause
On Sunday 21 July 2013 13:52:06 Rolf Eike Beer wrote: Volker Krause wrote: - GCC = 4.5 - override Explicit virtual overrides require g++ 4.7: http://gcc.gnu.org/projects/cxx0x.html you are right, it's also what all other sources referenced in

Re: Supported Compilers / C++11 Support in KF5

2013-07-21 Thread David Faure
On Sunday 21 July 2013 13:52:06 Rolf Eike Beer wrote: Volker Krause wrote: - GCC = 4.5 - override Explicit virtual overrides require g++ 4.7: http://gcc.gnu.org/projects/cxx0x.html This is trivially to work around by a CMake time check and then just define override to empty. Not

Review Request 111626: Fix Amarok crash with Audio CD inserted

2013-07-21 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111626/ --- Review request for Amarok, kdelibs and Solid. Description ---

Re: Supported Compilers / C++11 Support in KF5

2013-07-21 Thread Rolf Eike Beer
Am Sonntag, 21. Juli 2013, 14:11:07 schrieb Volker Krause: On Sunday 21 July 2013 13:52:06 Rolf Eike Beer wrote: Volker Krause wrote: - GCC = 4.5 - override Explicit virtual overrides require g++ 4.7: http://gcc.gnu.org/projects/cxx0x.html you are right, it's also what

Re: Review Request 111585: Don't update clipboard before cut/paste KIO operation succeeds

2013-07-21 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111585/#review36244 --- Ship it! Ah, now I understand. Before hitting Undo, the user

Re: Proposal for branching policy towards KF5

2013-07-21 Thread Sebastian Kügler
On Saturday, July 20, 2013 10:10:11 David Faure wrote: On Saturday 20 July 2013 13:28:47 Ben Cooksley wrote: I'd also be inclined to think of kde-runtime as part of kdelibs, rather than the workspace Yes, that is very true. Especially since the plan for most of kde-runtime is to fold it

Re: Review Request 111633: Update announced KDE version / required Qt version

2013-07-21 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111633/#review36261 --- Is that qt change really needed? Otherwise we are a bit past

Re: Review Request 111633: Update announced KDE version / required Qt version

2013-07-21 Thread Christoph Feck
On July 21, 2013, 4:47 p.m., Albert Astals Cid wrote: Is that qt change really needed? Otherwise we are a bit past the dependency freeze CMakeLists.txt already requires Qt 4.8.0. - Christoph --- This is an automatically generated

Re: Review Request 111585: Don't update clipboard before cut/paste KIO operation succeeds

2013-07-21 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111585/ --- (Updated July 21, 2013, 6:32 p.m.) Status -- This change has been

Re: Review Request 111585: Don't update clipboard before cut/paste KIO operation succeeds

2013-07-21 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111585/#review36267 --- This review has been submitted with commit

Re: Supported Compilers / C++11 Support in KF5

2013-07-21 Thread Thiago Macieira
On domingo, 21 de julho de 2013 14.45.52, Rolf Eike Beer wrote: I totally agree with that. As I said: detection of this is trivial at CMake time, maybe I get my C++ feature detection package ready even to be included in 2.8.12, and if not the stuff can easily be extracted. And afterwards you

Re: Review Request 111633: Update announced KDE version / required Qt version

2013-07-21 Thread Christoph Feck
On July 21, 2013, 4:47 p.m., Albert Astals Cid wrote: Is that qt change really needed? Otherwise we are a bit past the dependency freeze Christoph Feck wrote: CMakeLists.txt already requires Qt 4.8.0. Albert Astals Cid wrote: But isn't the content of CMakeLists.txt for