Re: Supported Compilers / C++11 Support in KF5

2013-07-22 Thread Johannes Sixt
Am 7/21/2013 13:52, schrieb Rolf Eike Beer: Explicit virtual overrides require g++ 4.7: http://gcc.gnu.org/projects/cxx0x.html This is trivially to work around by a CMake time check and then just define override to empty. Not so. 'override' is a legal identifier, not a pure keyword. By

KF5 in Release Mode: C++11 and dates

2013-07-22 Thread Kevin Ottens
Hello people, As planned, we had the KF5 in Release Mode BoF at Akademy. Quite a lot of information on the current status got shared, but I'm not going to focus on that in this email. I'm writing this email to let everyone know about the two main novelties which got discussed during this

Re: Review Request 111576:

2013-07-22 Thread Lukáš Tinkl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111576/#review36293 --- Ship it! - Lukáš Tinkl On July 18, 2013, 5:58 p.m., Philipp

Re: Supported Compilers / C++11 Support in KF5

2013-07-22 Thread Alexander Neundorf
On Sunday 21 July 2013, Rolf Eike Beer wrote: Am Sonntag, 21. Juli 2013, 14:11:07 schrieb Volker Krause: On Sunday 21 July 2013 13:52:06 Rolf Eike Beer wrote: Volker Krause wrote: - GCC = 4.5 - override Explicit virtual overrides require g++ 4.7:

Re: Supported Compilers / C++11 Support in KF5

2013-07-22 Thread Rolf Eike Beer
Am Montag, 22. Juli 2013, 19:14:10 schrieb Alexander Neundorf: On Sunday 21 July 2013, Rolf Eike Beer wrote: I totally agree with that. As I said: detection of this is trivial at CMake time, maybe I get my C++ feature detection package ready even to be included in 2.8.12, and if not the

Re: Supported Compilers / C++11 Support in KF5

2013-07-22 Thread Michael Pyne
On Mon, July 22, 2013 08:38:12 Johannes Sixt wrote: Am 7/21/2013 13:52, schrieb Rolf Eike Beer: Explicit virtual overrides require g++ 4.7: http://gcc.gnu.org/projects/cxx0x.html This is trivially to work around by a CMake time check and then just define override to empty. Not

Re: Review Request 111072: Drop internal X11 cmake module

2013-07-22 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111072/ --- (Updated July 22, 2013, 6:44 p.m.) Status -- This change has been

Re: Review Request 111480: Notifications are shown multiple times

2013-07-22 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111480/#review36320 --- This breaks Amarok's Show OSD shortcut where you could tell it

Re: Review Request 111633: Update announced KDE version / required Qt version

2013-07-22 Thread Alexander Neundorf
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111633/#review36326 --- Ship it! Yes, it was simply forgotten. - Alexander Neundorf

Re: Review Request 111462: Avoid unnecessary stat of destination directory during copy/move in KDirWatch

2013-07-22 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111462/#review36330 --- What if e-dirty was already true before entering the whole

Re: Review Request 111462: Avoid unnecessary stat of destination directory during copy/move in KDirWatch

2013-07-22 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111462/ --- (Updated July 23, 2013, 3:47 a.m.) Review request for kdelibs and David

Review Request 111648: Fix for GroupExpander that overlaps application icon

2013-07-22 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111648/ --- Review request for kde-workspace and Eike Hein. Description --- In

Re: Review Request 111648: Fix for GroupExpander that overlaps application icon

2013-07-22 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111648/ --- (Updated July 23, 2013, 5:37 a.m.) Review request for kde-workspace and