---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111883/
---
Review request for kdelibs, Albert Astals Cid and David Faure.
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111852/#review37101
---
Thanks for the unittest. Almost there :)
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111883/#review37102
---
Ship it!
Looks good, please also revert the NoGUI-GUI changes
Looks ok, thanks for the work dude!
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111341/
---
(Updated Aug. 5, 2013, 3:37 p.m.)
Status
--
This change has been
On July 9, 2013, 12:17 a.m., Pino Toscano wrote:
The patch is wrong.
It is correct for knetattach to have an own icon and to use it its own
code. If you want an Oxygen version of this icon, then create one (named
knetattach) and add it to the Oxygen icon theme, which will be used
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111776/#review37114
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111883/
---
(Updated Aug. 5, 2013, 11:55 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111883/
---
(Updated Aug. 5, 2013, 11:58 a.m.)
Status
--
This change has been
On Saturday, August 03, 2013 08:19:48 PM Albert Astals Cid wrote:
Please let's try to keep this discussion in release-team, I'm just CC'ing k-c-
d because Alex's discussion about changing the release happened there.
At the Release Team BoF at Akademy I was tasked to come up with a proposed
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/45/
---
(Updated Aug. 5, 2013, 1:26 p.m.)
Status
--
This change has been
On Aug. 5, 2013, 7:46 a.m., David Faure wrote:
kdecore/services/kmimetype_p.h, line 48
http://git.reviewboard.kde.org/r/111852/diff/2/?file=176232#file176232line48
Why did you make this a new virtual method?
The concept doesn't exist in KServiceType, so I don't see the point.
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111852/
---
(Updated Aug. 5, 2013, 3:26 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111852/#review37138
---
This review has been submitted with commit
El Dilluns, 5 d'agost de 2013, a les 01:34:07, Milian Wolff va escriure:
On Sunday 04 August 2013 16:35:20 Albert Astals Cid wrote:
El Diumenge, 4 d'agost de 2013, a les 00:29:06, Milian Wolff va escriure:
On Sunday 04 August 2013 00:28:17 Milian Wolff wrote:
Hey all,
I'd like
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111870/
---
(Updated Aug. 5, 2013, 5:30 p.m.)
Review request for kdelibs and David
On Aug. 3, 2013, 10:27 p.m., Milian Wolff wrote:
kdecore/io/kdirwatch.cpp, line 372
http://git.reviewboard.kde.org/r/111870/diff/1/?file=176087#file176087line372
the indentation is broken here, no? should be two spaces like the rest
of the file.
Mark Gaiser wrote:
On Monday 05 August 2013 19:17:49 Albert Astals Cid wrote:
El Dilluns, 5 d'agost de 2013, a les 01:34:07, Milian Wolff va escriure:
On Sunday 04 August 2013 16:35:20 Albert Astals Cid wrote:
El Diumenge, 4 d'agost de 2013, a les 00:29:06, Milian Wolff va
escriure:
On Sunday 04 August
On 05/08/13 20:55, Milian Wolff wrote:
I'm out of the loop, since this is so close to the final release I'm not sure
whether I should get this in...
I'd say commit it; the patch is pretty trivial, and I can't see any way
it could break the build for anyone not using Clang, and build fixes are
19 matches
Mail list logo
