Re: What to do with KScanDialog

2013-09-02 Thread Àlex Fiestas
On Sunday 01 September 2013 21:58:25 Kåre Särs wrote: On Sunday 01 September 2013 13:34:50 Martin Koller wrote: On Saturday 31 August 2013 23:11:57 Kåre Särs wrote: I would vote to move it to kde4support and deprecate it. I can volunteer to port kolourpaint to libksane if needed.

Re: Review Request 112367: Include the icon's theme in the cache key

2013-09-02 Thread David Faure
On Aug. 31, 2013, 7:11 a.m., David Faure wrote: I disagree. Making things slow to cover a really really corner case (mixing kde4 and kde5), while the solution already exists (clearing the cache when switching icon themes), doesn't seem very sensible to me. The point is really that

Re: Review Request 112367: Include the icon's theme in the cache key

2013-09-02 Thread Àlex Fiestas
On Aug. 31, 2013, 7:11 a.m., David Faure wrote: I disagree. Making things slow to cover a really really corner case (mixing kde4 and kde5), while the solution already exists (clearing the cache when switching icon themes), doesn't seem very sensible to me. The point is really that

Re: Review Request 112200: Remove unused CMake qimageblitz includes and links

2013-09-02 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112200/#review39194 --- This review has been submitted with commit

Review Request 112463: Port SMB kioslave to KF5/Qt5

2013-09-02 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112463/ --- Review request for KDE Runtime and KDE Frameworks. Description ---

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

2013-09-02 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112463/#review39205 --- kioslave/CMakeLists.txt

Review Request 112467: Use cached login information when authenticating in kio_smb

2013-09-02 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112467/ --- Review request for KDE Runtime. Description --- Use

Re: Review Request 112294: Implement multi-seat support in KDM

2013-09-02 Thread Stefan Brüns
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112294/ --- (Updated Sept. 2, 2013, 7:57 p.m.) Review request for kde-workspace.

Re: Review Request 112467: Use cached login information when authenticating in kio_smb

2013-09-02 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112467/ --- (Updated Sept. 2, 2013, 8:59 p.m.) Review request for KDE Runtime.

Re: Review Request 112467: Use cached login information when authenticating in kio_smb

2013-09-02 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112467/ --- (Updated Sept. 2, 2013, 9:14 p.m.) Status -- This change has been

Re: Review Request 112294: Implement multi-seat support in KDM

2013-09-02 Thread Martin Tobias Holmedahl Sandsmark
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112294/#review39221 --- I don't see anything obviously wrong with it, but you should

Re: Review Request 112294: Implement multi-seat support in KDM

2013-09-02 Thread Stefan Brüns
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112294/ --- (Updated Sept. 2, 2013, 11:34 p.m.) Review request for kde-workspace and