Re: Review Request 112982: copyToFile support for kio_smb

2013-09-29 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112982/ --- (Updated Sept. 29, 2013, 4:10 p.m.) Review request for KDE Runtime.

Re: Review Request 112880: Added KColorSchemeToken class.

2013-09-29 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112880/#review41002 --- The name token surprises me a bit. Is this a usual naming

Re: Review Request 112880: Added KColorSchemeToken class.

2013-09-29 Thread Denis Kuplyakov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112880/ --- (Updated Sept. 29, 2013, 4:27 p.m.) Review request for KDE Frameworks and

Re: Review Request 112880: Added KColorSchemeToken class.

2013-09-29 Thread Denis Kuplyakov
On Sept. 29, 2013, 4:24 p.m., David Faure wrote: The name token surprises me a bit. Is this a usual naming scheme for accessing C++ classes from QML? Otherwise I would think the QML code would want to just write KColorScheme. Maybe the registration could be done in a static method,

Review Request 112991: Fix compilation rules of KDE-Workspace under OSX/Macports

2013-09-29 Thread Gilles Caulier
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112991/ --- Review request for kde-workspace. Description --- This patch fix