FindKDE4Internal.cmake clang c++11 -fdelayed-template-parsing

2013-10-12 Thread Milian Wolff
Hey Raphael! Thank you for working on clang support in FindKDE4Internal.cmake. Since recently though I have build issues with clang due to the -fdelayed- template-parsing flag passed in FindKDE4Internal.cmake. A simple example such as this: #include vector int main() { std::vectorint v; return

Review Request 113216: some little performance improvement for network kio

2013-10-12 Thread Jaime Torres Amate
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113216/ --- Review request for KDE Runtime. Repository: kde-runtime Description

Re: Review Request 113205: Make KJob::result public for the new signal/slot syntax.

2013-10-12 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113205/ --- (Updated Oct. 12, 2013, 2:08 p.m.) Review request for KDE Frameworks,

Re: Review Request 113184: windowmanagement: Remove unused variable

2013-10-12 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113184/#review41590 --- This review has been submitted with commit

Re: Review Request 113184: windowmanagement: Remove unused variable

2013-10-12 Thread Jiří Pinkava
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113184/ --- (Updated Oct. 12, 2013, 2:34 p.m.) Status -- This change has been

Review Request 113218: Enable translation functions for js script loaded through Kross

2013-10-12 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113218/ --- Review request for kdelibs. Repository: kdelibs Description ---

Review Request 113219: Fix struct initialization which is invalid for C++11

2013-10-12 Thread Jiří Pinkava
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113219/ --- Review request for kdelibs. Repository: kdelibs Description ---

Re: FindKDE4Internal.cmake clang c++11 -fdelayed-template-parsing

2013-10-12 Thread Thiago Macieira
On sábado, 12 de outubro de 2013 12:42:50, Milian Wolff wrote: Hey Raphael! Thank you for working on clang support in FindKDE4Internal.cmake. Since recently though I have build issues with clang due to the -fdelayed- template-parsing flag passed in FindKDE4Internal.cmake. A simple example

Re: Review Request 113219: Fix struct initialization which is invalid for C++11

2013-10-12 Thread Thiago Macieira
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113219/#review41600 --- Ship it! Ship It! - Thiago Macieira On Oct. 12, 2013, 3:10

Re: Review Request 113205: Make KJob::result public for the new signal/slot syntax.

2013-10-12 Thread David Faure
On Oct. 11, 2013, 9:51 p.m., Mark Gaiser wrote: We are here making a 'hole' for people to do 'bad things' that wasn't possible in the past. I'm not sure we want that. Mark Gaiser wrote: Interesting. So that mean we simply can't use the new signal/slot syntax because of it?

Re: Review Request 113131: Added missing slot to bookmarksrunner.*

2013-10-12 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113131/#review41605 --- This review has been submitted with commit

Re: Review Request 113131: Added missing slot to bookmarksrunner.*

2013-10-12 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113131/ --- (Updated Oct. 12, 2013, 5:34 p.m.) Status -- This change has been

Re: Review Request 113132: Move all Dolphin KPart extensions into dolphin_ext.*

2013-10-12 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113132/ --- (Updated Oct. 12, 2013, 5:36 p.m.) Status -- This change has been

Re: Review Request 113219: Fix struct initialization which is invalid for C++11

2013-10-12 Thread Albert Astals Cid
On Oct. 12, 2013, 4:47 p.m., Thiago Macieira wrote: Ship It! He doesn't have a commiting account afaik, so he'll need someone to commit for him. - Albert --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 113219: Fix struct initialization which is invalid for C++11

2013-10-12 Thread Jiří Pinkava
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113219/#review41609 --- Ship it! Ship It! - Jiří Pinkava On Oct. 12, 2013, 3:10

Re: Review Request 113219: Fix struct initialization which is invalid for C++11

2013-10-12 Thread Christoph Feck
On Oct. 12, 2013, 6:23 p.m., Jiří Pinkava wrote: Ship It! Thanks Jiří. If possible, please request commit rights to the KDE repositories, so you can commit yourself after each review. This simplifies the work for others. - Christoph

Re: Review Request 113219: Fix struct initialization which is invalid for C++11

2013-10-12 Thread Christoph Feck
On Oct. 12, 2013, 6:23 p.m., Jiří Pinkava wrote: Ship It! Christoph Feck wrote: Thanks Ji?í. If possible, please request commit rights to the KDE repositories, so you can commit yourself after each review. This simplifies the work for others. reviewboard isn't even Unicode safe.

Re: Review Request 113205: Make KJob::result public for the new signal/slot syntax.

2013-10-12 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113205/ --- (Updated Oct. 12, 2013, 6:30 p.m.) Review request for KDE Frameworks,

Re: Review Request 113216: some little performance improvement for network kio

2013-10-12 Thread Nicolás Alvarez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113216/#review41617 --- This will not improve performance noticeably; QString is

Re: Review Request 113189: lower (a lot) warning noise caused by undefined macros

2013-10-12 Thread Jiří Pinkava
On Oct. 10, 2013, 11:59 a.m., Bernd Buschinski wrote: This is a bit confussing... lets sum up the background story: - kjs(/wtf) loves gcc features - kjs-cmake filters out (gcc) pedantic now comes the problem... whats with other compilers? if you look at the commit message