Re: Review Request 113364: kio_http: fix for proxy connection

2013-10-25 Thread Andrea Iacovitti
On Oct. 25, 2013, 2:55 a.m., Dawit Alemayehu wrote: I have no objection to this patch. However, I want to make sure you have tested the other modes before I give it a thumbs up. Did you try the manual proxy setup with your patch? Also adding some exceptions to make sure it honors

Re: Review Request 113355: Reduce UDSEntry memory usage with implicit sharing

2013-10-25 Thread Jan Kundrát
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113355/#review42330 --- (d) Use QVector::reserve to reserve the appropriate size for

Re: Review Request 113413: Improved Keyboard Layout Preview

2013-10-25 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113413/#review42345 --- I think a screenshot would nicely go along with this ;)

Re: Review Request 112982: copyToFile support for kio_smb

2013-10-25 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112982/ --- (Updated Oct. 25, 2013, 1:10 p.m.) Review request for KDE Runtime.

Re: Review Request 113364: kio_http: fix for proxy connection

2013-10-25 Thread Andrea Iacovitti
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113364/ --- (Updated Oct. 25, 2013, 6:26 p.m.) Status -- This change has been

Re: Review Request 113413: Improved Keyboard Layout Preview

2013-10-25 Thread shivam makkar
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113413/ --- (Updated Oct. 25, 2013, 7:13 p.m.) Review request for KDE Runtime,

Re: Review Request 113413: Improved Keyboard Layout Preview

2013-10-25 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113413/#review42377 --- Could you also post a preview for French ? It should have 4

Re: Review Request 113413: Improved Keyboard Layout Preview

2013-10-25 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113413/#review42378 --- How does it look on 1024 pixel wide screens (not that I want

Re: Review Request 112991: Fix compilation rules of KDE-Workspace under OSX/Macports

2013-10-25 Thread Gilles Caulier
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112991/ --- (Updated Oct. 26, 2013, 4:57 a.m.) Review request for kde-workspace.