Re: Review Request 113846: fix kicontheme::list

2013-11-14 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113846/#review43650 --- Ship it! Oops. - David Faure On Nov. 13, 2013, 5:33 p.m.,

Re: Review Request 113591: Reduce UDSEntry memory usage by sharing the contained QStrings if possible

2013-11-14 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113591/#review43651 --- Ship it! Ship It! - David Faure On Nov. 3, 2013, 6:57

Re: Review Request 113846: fix kicontheme::list

2013-11-14 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113846/#review43653 --- This review has been submitted with commit

Re: Review Request 113846: fix kicontheme::list

2013-11-14 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113846/ --- (Updated Nov. 14, 2013, 9:48 a.m.) Status -- This change has been

Re: Review Request 113841: kcm locale: use kcmshell5

2013-11-14 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113841/#review43654 --- This review has been submitted with commit

Re: Review Request 113841: kcm locale: use kcmshell5

2013-11-14 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113841/ --- (Updated Nov. 14, 2013, 10 a.m.) Status -- This change has been

Review Request 113853: port kcm icons to KF5

2013-11-14 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113853/ --- Review request for KDE Runtime and Sebastian Kügler. Repository:

Review Request 113857: Get rid off ifdefs for windows driver kit

2013-11-14 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113857/ --- Review request for kdelibs, Patrick Spendrin and Patrick von Reth.

Review Request 113858: Add .reviewboardrc

2013-11-14 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113858/ --- Review request for kdelibs. Repository: kdelibs Description ---

Re: Review Request 112982: copy[To|From]File support for kio_smb

2013-11-14 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112982/ --- (Updated Nov. 14, 2013, 2:15 p.m.) Review request for KDE Runtime and

Re: Review Request 113853: port kcm icons to KF5

2013-11-14 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113853/#review43666 --- Nice. The QFormLayout doesn't need to be replaced, see the

Re: Review Request 113853: port kcm icons to KF5

2013-11-14 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113853/ --- (Updated Nov. 14, 2013, 4:26 p.m.) Review request for KDE Runtime and

Re: Review Request 113853: port kcm icons to KF5

2013-11-14 Thread Jonathan Riddell
On Nov. 14, 2013, 2:55 p.m., Sebastian Kügler wrote: Nice. The QFormLayout doesn't need to be replaced, see the comment inline. Did you test if switching icons works with this? Are changes being picked up at run-time? diff updated with points mentioned switching icon themes and

Re: Review Request 113779: KInfocenter/OpenGL: fix ReadPipe() in the case that the command cannot be run

2013-11-14 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113779/#review43682 --- This review has been submitted with commit

Re: Review Request 113779: KInfocenter/OpenGL: fix ReadPipe() in the case that the command cannot be run

2013-11-14 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113779/#review43683 --- This review has been submitted with commit

Re: Review Request 113853: port kcm icons to KF5

2013-11-14 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113853/#review43685 --- Ship it! Ship It! - Sebastian Kügler On Nov. 14, 2013,

Re: Review Request 113853: port kcm icons to KF5

2013-11-14 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113853/#review43686 --- This review has been submitted with commit

Re: Review Request 113853: port kcm icons to KF5

2013-11-14 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113853/ --- (Updated Nov. 14, 2013, 5:16 p.m.) Status -- This change has been

Re: Review Request 113839: kcmshell: change internal references to kcmshell5

2013-11-14 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113839/#review43692 --- Ship it! - Jeremy Whiting On Nov. 13, 2013, 7:36 a.m.,

Re: Review Request 113839: kcmshell: change internal references to kcmshell5

2013-11-14 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113839/#review43693 --- This review has been submitted with commit

Re: Review Request 113839: kcmshell: change internal references to kcmshell5

2013-11-14 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113839/ --- (Updated Nov. 14, 2013, 6:53 p.m.) Status -- This change has been

Re: Review Request 113413: Improved Keyboard Layout Preview

2013-11-14 Thread Andriy Rysin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113413/#review43699 --- Hi Shivam, there's a bug report about the reversed positions

Re: Review Request 112982: copy[To|From]File support for kio_smb

2013-11-14 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112982/#review43700 --- Ship it! kioslave/smb/kio_smb_dir.cpp