Re: Review Request 114436: Set WindowModality of all KIO message box to Qt::WindowModal

2013-12-17 Thread Frank Reininghaus
On Dec. 13, 2013, 2:27 p.m., Frank Reininghaus wrote: Thanks for looking into this, Dawit! I greatly appreciate this effort. Two questions come to my mind: 1. Why should these dialogs be modal at all? Everything that KIO does is asynchronous, so it could very well be that the

Re: Review Request 114506: Create testcase for bookmark toolbar

2013-12-17 Thread Frank Reininghaus
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114506/#review45845 --- I'd say that adding unit tests never hurts :-) I can't really

Re: Review Request 113866: kio bookmarks: Only iterate over element nodes in findToolbar()

2013-12-17 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113866/#review45846 --- Ship it! Looks good, please push to KDE 4.12, I'll merge

Re: Review Request 114472: kjs: Implement ES6 Number parseInt, parseFloat

2013-12-17 Thread Martin Tobias Holmedahl Sandsmark
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114472/#review45855 --- Ship it! Ship It! - Martin Tobias Holmedahl Sandsmark On

Review Request 114519: fix endless loop in KLineEdit-setSqueezedText()

2013-12-17 Thread Axel Arnold
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114519/ --- Review request for kdelibs. Bugs: 328263

Re: Nepomuk in 4.13 and beyond

2013-12-17 Thread Todd
On Dec 12, 2013 6:36 PM, Vishesh Handa m...@vhanda.in wrote: i’ll say it again here so that it is at least on record: i really disagree with renaming Nepomuk. call it Nepomuk 2 or whatever, but tossing aside name recognition and years of messaging is doing the promo teams a massive

Re: Review Request 114436: Set WindowModality of all KIO message box to Qt::WindowModal

2013-12-17 Thread Dawit Alemayehu
On Dec. 13, 2013, 2:27 p.m., Frank Reininghaus wrote: Thanks for looking into this, Dawit! I greatly appreciate this effort. Two questions come to my mind: 1. Why should these dialogs be modal at all? Everything that KIO does is asynchronous, so it could very well be that the