---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119498/#review66935
---
Unless anyone has any objections in the next 24 hours, I
hi...
KConfigGroup parent() currently always returns a KConfigGroup object with a
dptr. isValid() determines validity based on having a dptr. this leads to
loops like this:
KConfigGroup group = some valid group;
while (group.isValid()) {
group = group.parent();
}
to never terminate,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120281/
---
Review request for KDE Runtime.
Bugs: 329983
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120178/
---
(Updated Sept. 19, 2014, 11:25 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120282/
---
Review request for KDE Runtime.
Repository: kde-runtime
Description
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119372/
---
(Updated Sept. 19, 2014, 5:26 p.m.)
Review request for KDE Base Apps.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120282/#review66948
---
Ship it!
Ship It!
- Lukáš Tinkl
On Zář. 19, 2014, 1:31
On Freitag, 19. September 2014 13:06:41 CEST, Aaron J. Seigo wrote:
KConfigGroup group = some valid group;
while (group.isValid()) {
group = group.parent();
}
I'm checking for existance rather than validity in kconfig (great tool, far
superior to k(read|write)config, btw /advert ;-)
On Sept. 18, 2014, 9:19 vorm., Thomas Lübking wrote:
drkonqi/main.cpp, line 47
https://git.reviewboard.kde.org/r/119498/diff/2/?file=312509#file312509line47
this sounds fishy - at least the comment to be incorrect?
i hope that OSX does not just actually abort() when you call
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120287/
---
Review request for KDE Software on Mac OS X and kde-workspace.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120281/#review66971
---
C.UTF-8 is not a standard locale, even if quite a number of
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120287/#review66972
---
kcontrol/krdb/krdb.cpp
On Sept. 19, 2014, 6:40 nachm., Thomas Lübking wrote:
kcontrol/krdb/krdb.cpp, line 581
https://git.reviewboard.kde.org/r/120287/diff/1/?file=313477#file313477line581
Xlib call?
Why do you need krdb at all?
(gtk+ Qt should align to OSX anyway and you're skipping
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120182/#review66976
---
I don't know this code but David's proposed patch differs
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120287/#review66990
---
overall I rather tend to -1 for these changes. I consider
On Sept. 19, 2014, 8:40 p.m., Thomas Lübking wrote:
kcontrol/krdb/krdb.cpp, line 581
https://git.reviewboard.kde.org/r/120287/diff/1/?file=313477#file313477line581
Xlib call?
Why do you need krdb at all?
(gtk+ Qt should align to OSX anyway and you're skipping
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120287/
---
(Updated Sept. 19, 2014, 10:43 p.m.)
Review request for KDE Software on
On Sept. 19, 2014, 10:24 p.m., Martin Gräßlin wrote:
overall I rather tend to -1 for these changes. I consider changing the
build system in a long term release as way too risky considering that the
core development doesn't use this iteration any more. Any unintended
breakage (e.g. a
On Sept. 19, 2014, 10:24 nachm., Martin Gräßlin wrote:
kcontrol/krdb/krdb.cpp, lines 544-548
https://git.reviewboard.kde.org/r/120287/diff/1/?file=313477#file313477line544
this looks like an inintended change
René J.V. Bertin wrote:
No, I often do this when conditionals get
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120287/#review67003
---
CMakeLists.txt
On Sept. 19, 2014, 8:24 p.m., Martin Gräßlin wrote:
overall I rather tend to -1 for these changes. I consider changing the
build system in a long term release as way too risky considering that the
core development doesn't use this iteration any more. Any unintended
breakage (e.g. a
On Sept. 19, 2014, 8:24 nachm., Martin Gräßlin wrote:
kcontrol/krdb/krdb.cpp, lines 544-548
https://git.reviewboard.kde.org/r/120287/diff/1/?file=313477#file313477line544
this looks like an inintended change
René J.V. Bertin wrote:
No, I often do this when conditionals get
On Sept. 19, 2014, 10:24 p.m., Martin Gräßlin wrote:
kcontrol/krdb/krdb.cpp, lines 544-548
https://git.reviewboard.kde.org/r/120287/diff/1/?file=313477#file313477line544
this looks like an inintended change
René J.V. Bertin wrote:
No, I often do this when conditionals get
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120287/
---
(Updated Sept. 20, 2014, 12:05 a.m.)
Review request for KDE Software on
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120287/#review67010
---
You added APPLE to the if() but not always to the matching
On Sept. 20, 2014, 12:26 a.m., Christoph Feck wrote:
You added APPLE to the if() but not always to the matching endif()...
True. But that's optional, no?
- René J.V.
---
This is an automatically generated e-mail. To reply, visit:
On Sept. 18, 2014, 9:19 a.m., Thomas Lübking wrote:
drkonqi/main.cpp, line 47
https://git.reviewboard.kde.org/r/119498/diff/2/?file=312509#file312509line47
this sounds fishy - at least the comment to be incorrect?
i hope that OSX does not just actually abort() when you call
2014-09-19 12:28 GMT-03:00 Thomas Lübking thomas.luebk...@gmail.com:
On Freitag, 19. September 2014 13:06:41 CEST, Aaron J. Seigo wrote:
KConfigGroup group = some valid group;
while (group.isValid()) {
group = group.parent();
}
I'm checking for existance rather than validity in
On Sept. 19, 2014, 7:03 p.m., Andrea Iacovitti wrote:
I don't know this code but David's proposed patch differs from the one
committed
if (m_asMethod || !fileInfo.exists()) {
vs
if (m_asMethod !fileInfo.exists()) {
It is a typo on my part. I will fix it.
- Dawit
29 matches
Mail list logo
