Re: Review Request 120406: ksysguardd: Avoid including IO-wait in CPU load.

2014-10-06 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120406/#review67978 --- as that is a change which might break My Workflow(TM) (expect

Re: Review Request 120406: ksysguardd: Avoid including IO-wait in CPU load.

2014-10-06 Thread Thomas Lübking
On Okt. 5, 2014, 10:29 vorm., Milian Wolff wrote: Hmm... there is no way to see the wait time anywhere then, right? I don't see a way to add individual columns for that. Maybe that should be re-thought for frameworks. I.e. keep the CPU% like now but add more columns for the

Re: SDDM-KCM In Review

2014-10-06 Thread Àlex Fiestas
On Saturday 04 October 2014 22:38:30 David Edmundson wrote: Application history: - I wrote a KCM for LightDM in Playground - This was forked and changed to work on SDDM in Github - We switched to SDDM as the recommended DM for Plasma - We want a KCM to configure it - It's easier (for

Re: Muon and kde-gtk-config moved to kde/workspace - was - Re: Moving repositories in the module structure

2014-10-06 Thread Albert Astals Cid
El Dilluns, 6 d'octubre de 2014, a les 01:30:47, Aleix Pol va escriure: On Sun, Oct 5, 2014 at 8:30 PM, Albert Astals Cid aa...@kde.org wrote: El Divendres, 3 d'octubre de 2014, a les 03:28:44, Aleix Pol va escriure: On Fri, Oct 3, 2014 at 1:52 AM, Albert Astals Cid aa...@kde.org wrote:

Re: Review Request 120406: ksysguardd: Avoid including IO-wait in CPU load.

2014-10-06 Thread Søren Holm
On okt. 5, 2014, 10:29 a.m., Milian Wolff wrote: Hmm... there is no way to see the wait time anywhere then, right? I don't see a way to add individual columns for that. Maybe that should be re-thought for frameworks. I.e. keep the CPU% like now but add more columns for the individual

Re: Review Request 120406: ksysguardd: Avoid including IO-wait in CPU load.

2014-10-06 Thread Søren Holm
On okt. 5, 2014, 10:29 a.m., Milian Wolff wrote: Hmm... there is no way to see the wait time anywhere then, right? I don't see a way to add individual columns for that. Maybe that should be re-thought for frameworks. I.e. keep the CPU% like now but add more columns for the individual

Re: Review Request 120406: ksysguardd: Avoid including IO-wait in CPU load.

2014-10-06 Thread Søren Holm
On okt. 5, 2014, 10:29 a.m., Milian Wolff wrote: Hmm... there is no way to see the wait time anywhere then, right? I don't see a way to add individual columns for that. Maybe that should be re-thought for frameworks. I.e. keep the CPU% like now but add more columns for the individual

Re: Review Request 120406: ksysguardd: Avoid including IO-wait in CPU load.

2014-10-06 Thread Søren Holm
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120406/ --- (Updated okt. 6, 2014, 6:53 p.m.) Review request for kde-workspace and

Re: Muon and kde-gtk-config moved to kde/workspace - was - Re: Moving repositories in the module structure

2014-10-06 Thread Matthias Klumpp
2014-10-06 19:57 GMT+02:00 Albert Astals Cid aa...@kde.org: El Dilluns, 6 d'octubre de 2014, a les 01:30:47, Aleix Pol va escriure: [...] I don't expect to compete with Apper. Muon Discover is a software center and that's the main solution I'm pushing here, as I explained in Plasma. Apper is

KF 5.3.0 changelog

2014-10-06 Thread David Faure
Dear workspace and application developers, In case you're not reading kde-announce, here's the list of changes in KF 5.3.0, just released. ### KActivities * Added DBus interface to load plugins at runtime ### KArchive * Add convenience method KArchive::file() * Compilation fixes for MSVC ###

Re: Muon and kde-gtk-config moved to kde/workspace - was - Re: Moving repositories in the module structure

2014-10-06 Thread Albert Astals Cid
El Diumenge, 5 d'octubre de 2014, a les 20:30:33, Albert Astals Cid va escriure: El Divendres, 3 d'octubre de 2014, a les 03:28:44, Aleix Pol va escriure: Changes: - kde-gtk-config was moved from extragear/base to kde/workspace. - muon was moved from extragear/sysadmin to kde/workspace.

Re: SDDM-KCM In Review

2014-10-06 Thread Albert Astals Cid
El Dissabte, 4 d'octubre de 2014, a les 22:38:30, David Edmundson va escriure: Hey all, I want to merge SDDM-KCM [1] into Plasma for 5.2. It's in kdereview now starting the mandatory review period. It's a config module for configuring SDDM, the Display Manager. Mostly themes and

Re: SDDM-KCM In Review

2014-10-06 Thread Harald Sitter
On Mon, Oct 6, 2014 at 11:48 PM, Albert Astals Cid aa...@kde.org wrote: There is no COPYING file (not sure if this one is mandatory or not, ask Riddell) Mandatory it is. At least for just about all GNU licenses as they even explicitly mention that a full copy needs to accompany the source. HS

Re: Review Request 120431: Fix and future-proof Dr Konqi security methods on Bugzilla

2014-10-06 Thread Ian Wadham
On Oct. 5, 2014, 7:43 a.m., Ben Cooksley wrote: As this is needed to restore the functionality of Dr Konqi, can someone familiar with the codebase please review it so we can get this in? Perhaps I am the person most familiar with the codebase of Dr Konqi, having worked on it for a few

Re: Review Request 120431: Fix and future-proof Dr Konqi security methods on Bugzilla

2014-10-06 Thread Albert Astals Cid
On oct. 5, 2014, 7:43 a.m., Ben Cooksley wrote: As this is needed to restore the functionality of Dr Konqi, can someone familiar with the codebase please review it so we can get this in? Ian Wadham wrote: Perhaps I am the person most familiar with the codebase of Dr Konqi, having

Re: Review Request 120431: Fix and future-proof Dr Konqi security methods on Bugzilla

2014-10-06 Thread Marko Käning
On Oct. 5, 2014, 9:43 a.m., Ben Cooksley wrote: As this is needed to restore the functionality of Dr Konqi, can someone familiar with the codebase please review it so we can get this in? Ian Wadham wrote: Perhaps I am the person most familiar with the codebase of Dr Konqi, having

Re: Review Request 120431: Fix and future-proof Dr Konqi security methods on Bugzilla

2014-10-06 Thread Thomas Lübking
On Okt. 5, 2014, 7:43 vorm., Ben Cooksley wrote: As this is needed to restore the functionality of Dr Konqi, can someone familiar with the codebase please review it so we can get this in? Ian Wadham wrote: Perhaps I am the person most familiar with the codebase of Dr Konqi,