Re: desktoptojson and list properties / i18n of JSON files

2014-11-21 Thread Burkhard Lück
Am Freitag, 21. November 2014, 00:16:23 schrieben Sie: On Friday 21 November 2014 00:07:53 Milian Wolff wrote: On Thursday 20 November 2014 19:57:54 Burkhard Lück wrote: Am Mittwoch, 19. November 2014, 23:00:57 schrieb Albert Astals Cid: Well, there's two steps about this: 1)

Re: Review Request 121083: Replace manual export files with CMake's generate_export_header

2014-11-21 Thread Andrius da Costa Ribas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121083/ --- (Updated Nov. 21, 2014, 10:47 p.m.) Status -- This change has been

Re: Review Request 121083: Replace manual export files with CMake's generate_export_header

2014-11-21 Thread Andrius da Costa Ribas
On Nov. 22, 2014, 12:18 a.m., Harald Sitter wrote: This breaks the kde4 build as ECM is not being used there and generate_export_header is not available without ECM. generate_export_header isn't in ECM, but in cmake itself

Re: Review Request 121083: Replace manual export files with CMake's generate_export_header

2014-11-21 Thread Harald Sitter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121083/#review70761 --- This breaks the kde4 build as ECM is not being used there and