/backends/fstab/fstabstorageaccess.cpp 5482d48
Diff: https://git.reviewboard.kde.org/r/113587/diff/
Testing
---
Add "x-gvfs-name=Share%20on%20Laptop" to CIFS mount, open dolphin -> Name has
changed
Thanks,
Stefan Brüns
.
CCBUG: 339193
Diffs
-
kioslave/remote/remoteimpl.cpp 5d973c6c1b6c31b7f3107d0d15805ef04bfdd661
Diff: https://git.reviewboard.kde.org/r/122653/diff/
Testing
---
dolphin remote:
-> no lock icon on smb:, mtp:, ... links
Thanks,
Stefan Brüns
marked as submitted.
Review request for KDE Frameworks, kdelibs and David Faure.
Changes
---
Submitted with commit 6215e878706dc6e79d1b6ac5df33f5751d6c7ec0 by Stefan Brüns
to branch master.
Bugs: 339193
http://bugs.kde.org/show_bug.cgi?id=339193
Repository: kdelibs
Description
if it is still
relevant there.
Stefan Brüns wrote:
So shall I commit this (and https://git.reviewboard.kde.org/r/122653/ as
well)?
AFAIK next Applications release is due in short time.
Will of course forward port to KF5
I am still waiting for a ship it. Patch applies
generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122652/#review76626
---
On Feb. 20, 2015, 9:28 p.m., Stefan Brüns wrote:
---
This is an automatically generated e-mail
: https://git.reviewboard.kde.org/r/122653/diff/
Testing
---
dolphin remote:
- no lock icon on smb:, mtp:, ... links
Thanks,
Stefan Brüns
://git.reviewboard.kde.org/r/122652/diff/
Testing
---
dolphin remote:
- no lock icon on smb:, mtp:, ... links
Thanks,
Stefan Brüns
solid/solid/backends/fstab/fstabdevice.h bac409e
Diff: https://git.reviewboard.kde.org/r/113587/diff/
Testing
---
Add x-gvfs-name=Share%20on%20Laptop to CIFS mount, open dolphin - Name has
changed
Thanks,
Stefan Brüns
/112294/#review58845
---
On May 29, 2014, 7:03 p.m., Stefan Brüns wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/112294
On May 26, 2014, 8:32 a.m., Oswald Buddenhagen wrote:
kdm/backend/dm.c, line 1436
https://git.reviewboard.kde.org/r/112294/diff/7/?file=274916#file274916line1436
no matching unused
Stefan Brüns wrote:
There is no unused or no matching unused dynamic display for %s sounds
/#review58845
---
On May 29, 2014, 7:03 p.m., Stefan Brüns wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/112294
much earlier than here, and the next line would be pointless (we use
pam_getenvlist). that would also mean that pam is a hard dependency, which
should be expressed by the configure code and appropriate ifdefs.
Stefan Brüns wrote:
Actually, pam_systemd needs it to register the session
On May 26, 2014, 2:50 p.m., Stefan Brüns wrote:
kdm/backend/dm.c, line 1430
https://git.reviewboard.kde.org/r/112294/diff/7/?file=274916#file274916line1430
Hm, I prefer this notation, in particular as this is the same as for
std::string (guaranteed since C++03, working for all
---
On May 26, 2014, 12:06 a.m., Stefan Brüns wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/112294
/#review58442
---
On May 26, 2014, 12:06 a.m., Stefan Brüns wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/112294
/resource.c 38a8c70
kdm/backend/server.c d8dd6f3
kdm/config-kdm.h.cmake 3e8912d
kdm/kfrontend/kdm_config.c 368c8d1
Diff: https://git.reviewboard.kde.org/r/112294/diff/
Testing
---
Single seat system, several multiseat systems
Thanks,
Stefan Brüns
://domainkeys.sourceforge.net/underscore.html
kdm/backend/resource.c
https://git.reviewboard.kde.org/r/112294/#comment40689
see above
kdm/backend/session.c
https://git.reviewboard.kde.org/r/112294/#comment40690
Will remove
- Stefan Brüns
On May 26, 2014, 12:06 a.m., Stefan Brüns wrote
://git.reviewboard.kde.org/r/112294/diff/
Testing
---
Single seat system, several multiseat systems
Thanks,
Stefan Brüns
/112294/#comment40630
This is actually needed to supply the seat to logind session registration
via pam_systemd.
This could be placed earlier, but I chose this place because it is near the
old CK session registration, and it only has to be before pam_open_session(...)
- Stefan Brüns
On May
On May 24, 2014, 11:46 a.m., Stefan Brüns wrote:
regarding DynamicDisplays and your magic backwards compat handling ... i
think the seat-encoded config stuff i insisted on makes that redundant,
after all. suppose we do it like that:
StaticServers=:0,@seat1_:4,@seat2_:7
/kdm_config.c 368c8d1
Diff: https://git.reviewboard.kde.org/r/112294/diff/
Testing
---
Single seat system, several multiseat systems
Thanks,
Stefan Brüns
won't know what to do with it.
Stefan Brüns wrote:
When a seat goes away, rStopDisplay(d, DS_RESERVE) is called - maybe a
d-displayType = dLocal | dReserve is missing for these cases.
But as long as the seat exists, you want it to behave like a static
display (restart server after
...
- Stefan
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/112294/#review54418
---
On May 18, 2014, 7:44 p.m., Stefan Brüns wrote
what to do with it.
Stefan Brüns wrote:
When a seat goes away, rStopDisplay(d, DS_RESERVE) is called - maybe a
d-displayType = dLocal | dReserve is missing for these cases.
But as long as the seat exists, you want it to behave like a static
display (restart server after session exit
/server.c d8dd6f3
kdm/backend/session.c 0e7901c
Diff: https://git.reviewboard.kde.org/r/112294/diff/
Testing
---
Single seat system, several multiseat systems
Thanks,
Stefan Brüns
/112294/#review54418
---
On April 6, 2014, 8:16 p.m., Stefan Brüns wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/112294
/plasma-wallpaper-image.desktop 6484545
Diff: https://git.reviewboard.kde.org/r/112294/diff/
Testing
---
Single seat system, several multiseat systems
Thanks,
Stefan Brüns
/backend/server.c d8dd6f3
kdm/backend/session.c 0e7901c
Diff: https://git.reviewboard.kde.org/r/112294/diff/
Testing
---
Single seat system, several multiseat systems
Thanks,
Stefan Brüns
/backend/client.c 26bb0b4
kdm/backend/dm.h b2f8c61
kdm/backend/dm.c 77a2ef7
kdm/backend/server.c d8dd6f3
kdm/backend/session.c 0e7901c
Diff: https://git.reviewboard.kde.org/r/112294/diff/
Testing
---
Single seat system, several multiseat systems
Thanks,
Stefan Brüns
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/112294/#review54418
---
On March 29, 2014, 5:38 p.m., Stefan Brüns wrote
correct.
- Stefan
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/112294/#review54418
---
On March 29, 2014, 5:38 p.m., Stefan Brüns
On Sept. 3, 2013, 10:20 p.m., Oswald Buddenhagen wrote:
given that there is no intention to make further feature releases of the
kde workspace which will include kdm, i wonder why we'd go through the
(potentially tedious) process of upstreaming this now?
Stefan Brüns wrote
is not an QDomElement.
toElement will return NULL and accessing it will crash.
Possible fix for 320006
Diffs
-
kio/bookmarks/kbookmark.cc 8459a02
Diff: https://git.reviewboard.kde.org/r/113866/diff/
Testing
---
None
Thanks,
Stefan Brüns
is not an QDomElement.
toElement will return NULL and accessing it will crash.
Possible fix for 320006
Diffs (updated)
-
kio/bookmarks/kbookmark.cc 8459a02
Diff: http://git.reviewboard.kde.org/r/113866/diff/
Testing
---
None
Thanks,
Stefan Brüns
. 16, 2013, 6:33 p.m., Stefan Brüns wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113866/
---
(Updated Dec. 16, 2013, 6:33
it will crash.
Possible fix for 320006
Diffs
-
kio/bookmarks/kbookmark.cc 8459a02
Diff: http://git.reviewboard.kde.org/r/113866/diff/
Testing
---
None
Thanks,
Stefan Brüns
:
http://git.reviewboard.kde.org/r/112294/#review39302
---
On Sept. 2, 2013, 11:34 p.m., Stefan Brüns wrote:
---
This is an automatically generated e-mail. To reply, visit:
http
d8dd6f3
kdm/backend/session.c 0e7901c
Diff: http://git.reviewboard.kde.org/r/112294/diff/
Testing
---
Single seat system, several multiseat systems
Thanks,
Stefan Brüns
/session.c 0e7901c
Diff: http://git.reviewboard.kde.org/r/112294/diff/
Testing
---
Single seat system, several multiseat systems
Thanks,
Stefan Brüns
On Aug. 27, 2013, 2:08 p.m., Stefan Brüns wrote:
looks fine to me, just that tiny minor nitpick on variable naming.
I assume this applies to systemd_monitor{,_fd} in dm.c as well. Will fix,
waiting a few days for more comments ...
- Stefan
/112294/diff/
Testing
---
Single seat system, several multiseat systems
Thanks,
Stefan Brüns
/kbookmarkmanager.cc d8a9cb7
Diff: http://git.reviewboard.kde.org/r/106563/diff/
Testing
---
Thanks,
Stefan Brüns
---
On Sept. 25, 2012, 11:01 a.m., Stefan Brüns wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106563/
---
(Updated Sept. 25
tbcache file is created when the toolbar bookmarks are the
full bookmarks, i.e. no entries/folders with toolbar attribute.
Diffs
-
kio/bookmarks/kbookmarkmanager.cc d8a9cb7
Diff: http://git.reviewboard.kde.org/r/106563/diff/
Testing
---
Thanks,
Stefan Brüns
44 matches
Mail list logo
