Re: Review Request: Prevent crash in KJob::emitResult() if job is deleted

2010-12-06 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6022/#review9150 --- Ship it! Good to go! - Kevin On 2010-12-06 09:43:30, Aurélien

Re: Review Request: Prevent crash in KJob::emitResult() if job is deleted

2010-12-02 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6022/#review9095 --- Proposing a slightly different approach.

Re: Review Request: Prevent crash in KJob::emitResult() if job is deleted

2010-12-02 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6022/ --- (Updated 2010-12-02 16:51:19.493828) Review request for kdelibs and Kevin

Review Request: Prevent crash in KJob::emitResult() if job is deleted

2010-12-01 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6022/ --- Review request for kdelibs and Kevin Ottens. Summary --- If a someone

Re: Review Request: Prevent crash in KJob::emitResult() if job is deleted

2010-12-01 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6022/#review9080 --- Well, if the job is explicitely isAutoDelete() then I'd say it's

Re: Review Request: Prevent crash in KJob::emitResult() if job is deleted

2010-12-01 Thread Aurélien Gâteau
On 2010-12-01 17:23:11, Kevin Ottens wrote: Well, if the job is explicitely isAutoDelete() then I'd say it's a bug in the caller to try to delete it in the first place... I see your point, but on the other hand if the job is not *autodelete* and the slot connected to result() deletes the

Re: Review Request: Prevent crash in KJob::emitResult() if job is deleted

2010-12-01 Thread Andras Mantia
On 2010-12-01 17:23:11, Kevin Ottens wrote: Well, if the job is explicitely isAutoDelete() then I'd say it's a bug in the caller to try to delete it in the first place... Aurélien Gâteau wrote: I see your point, but on the other hand if the job is not *autodelete* and the slot

Re: Review Request: Prevent crash in KJob::emitResult() if job is deleted

2010-12-01 Thread Albert Astals Cid
On 2010-12-01 17:23:11, Kevin Ottens wrote: Well, if the job is explicitely isAutoDelete() then I'd say it's a bug in the caller to try to delete it in the first place... Aurélien Gâteau wrote: I see your point, but on the other hand if the job is not *autodelete* and the slot