---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111335/#review35907
---
Almost there, thanks.
I'm surprised by the dispatch (to call
On July 13, 2013, 6:32 a.m., David Faure wrote:
Almost there, thanks.
I'm surprised by the dispatch (to call one of the many uidelegate methods),
followed by an un-dispatch (what's the term?), i.e. these many methods all
end up calling the same method anyway I can see how it
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111335/
---
(Updated July 13, 2013, 7:22 a.m.)
Review request for kdelibs.
Changes
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111335/#review35913
---
Ship it!
Perfect, thanks :-)
- David Faure
On July 13,
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111335/#review35917
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111335/
---
(Updated July 13, 2013, 1:30 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111335/#review35879
---
Looks good. I share your concern about the new public API, how
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111335/
---
(Updated July 13, 2013, 1:30 a.m.)
Review request for kdelibs.
Changes
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111335/
---
(Updated July 11, 2013, 11:37 p.m.)
Review request for kdelibs.
Changes
On July 5, 2013, 2:23 p.m., David Faure wrote:
kio/kio/scheduler.cpp, line 766
http://git.reviewboard.kde.org/r/111335/diff/2/?file=167766#file167766line766
Please don't put this code in scheduler.cpp
I'm trying to properly split core and gui aspects of KIO in
On July 5, 2013, 2:23 p.m., David Faure wrote:
kio/kio/scheduler.cpp, line 766
http://git.reviewboard.kde.org/r/111335/diff/2/?file=167766#file167766line766
Please don't put this code in scheduler.cpp
I'm trying to properly split core and gui aspects of KIO in
On July 5, 2013, 2:23 p.m., David Faure wrote:
kio/kio/scheduler.cpp, line 766
http://git.reviewboard.kde.org/r/111335/diff/2/?file=167766#file167766line766
Please don't put this code in scheduler.cpp
I'm trying to properly split core and gui aspects of KIO in
On July 5, 2013, 2:23 p.m., David Faure wrote:
kio/kio/scheduler.cpp, line 766
http://git.reviewboard.kde.org/r/111335/diff/2/?file=167766#file167766line766
Please don't put this code in scheduler.cpp
I'm trying to properly split core and gui aspects of KIO in
On July 5, 2013, 2:23 p.m., David Faure wrote:
kio/kio/scheduler.cpp, line 766
http://git.reviewboard.kde.org/r/111335/diff/2/?file=167766#file167766line766
Please don't put this code in scheduler.cpp
I'm trying to properly split core and gui aspects of KIO in
On July 5, 2013, 2:23 p.m., David Faure wrote:
kio/kio/scheduler.cpp, line 766
http://git.reviewboard.kde.org/r/111335/diff/2/?file=167766#file167766line766
Please don't put this code in scheduler.cpp
I'm trying to properly split core and gui aspects of KIO in
On July 5, 2013, 2:23 p.m., David Faure wrote:
kio/kio/scheduler.cpp, line 766
http://git.reviewboard.kde.org/r/111335/diff/2/?file=167766#file167766line766
Please don't put this code in scheduler.cpp
I'm trying to properly split core and gui aspects of KIO in
On July 5, 2013, 2:23 p.m., David Faure wrote:
kio/kio/scheduler.cpp, line 766
http://git.reviewboard.kde.org/r/111335/diff/2/?file=167766#file167766line766
Please don't put this code in scheduler.cpp
I'm trying to properly split core and gui aspects of KIO in
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111335/#review35634
---
Oh joy, a commit that moves a bunch of code which has changed
On July 5, 2013, 2:23 p.m., David Faure wrote:
kio/kio/scheduler.cpp, line 766
http://git.reviewboard.kde.org/r/111335/diff/2/?file=167766#file167766line766
Please don't put this code in scheduler.cpp
I'm trying to properly split core and gui aspects of KIO in
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111335/#review35497
---
kio/kio/scheduler.cpp
On July 3, 2013, 10:48 a.m., Andreas Hartmetz wrote:
kio/kio/scheduler.cpp, line 660
http://git.reviewboard.kde.org/r/111335/diff/1/?file=166900#file166900line660
Just return a QString. With the pointer you have more verbosity in the
caller, and the state of key is unclear after
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111335/
---
(Updated July 3, 2013, 12:19 p.m.)
Review request for kdelibs.
Changes
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111335/
---
Review request for kdelibs.
Description
---
The attach patch address
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111335/
---
(Updated July 1, 2013, 3:13 a.m.)
Review request for kdelibs.
Changes
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111335/
---
(Updated July 1, 2013, 5:10 a.m.)
Review request for kdelibs.
Changes
25 matches
Mail list logo
