Re: Review Request 111776: Update URLs copied to clipboard when they change due to KIO operations

2013-08-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111776/#review37114 --- This review has been submitted with commit

Re: Review Request 111776: Update URLs copied to clipboard when they change due to KIO operations

2013-08-02 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111776/#review36982 --- This review has been submitted with commit

Re: Review Request 111776: Update URLs copied to clipboard when they change due to KIO operations

2013-08-02 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111776/ --- (Updated Aug. 2, 2013, 12:37 p.m.) Status -- This change has been

Re: Review Request 111776: Update URLs copied to clipboard when they change due to KIO operations

2013-08-02 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111776/#review36984 --- Sorry for my slow review which led you to commit meanwhile,

Re: Review Request 111776: Update URLs copied to clipboard when they change due to KIO operations

2013-08-02 Thread Dawit Alemayehu
On Aug. 2, 2013, 12:53 p.m., David Faure wrote: kio/kio/clipboardupdater.cpp, line 108 http://git.reviewboard.kde.org/r/111776/diff/2/?file=175012#file175012line108 The name sounds like it will clear the clipboard. removeUrlsFromClipboard would be better Well this

Re: Review Request 111776: Update URLs copied to clipboard when they change due to KIO operations

2013-08-02 Thread David Faure
On Aug. 2, 2013, 12:53 p.m., David Faure wrote: kio/kio/clipboardupdater.cpp, line 108 http://git.reviewboard.kde.org/r/111776/diff/2/?file=175012#file175012line108 The name sounds like it will clear the clipboard. removeUrlsFromClipboard would be better Dawit

Re: Review Request 111776: Update URLs copied to clipboard when they change due to KIO operations

2013-08-02 Thread Dawit Alemayehu
On Aug. 2, 2013, 12:53 p.m., David Faure wrote: kio/kio/copyjob.cpp, line 2190 http://git.reviewboard.kde.org/r/111776/diff/2/?file=175014#file175014line2190 Where's this instance deleted? Should there be a deleteLater() in all code paths of slotResult()? Dawit

Re: Review Request 111776: Update URLs copied to clipboard when they change due to KIO operations

2013-08-02 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111776/#review36990 --- This review has been submitted with commit

Review Request 111776: Update URLs copied to clipboard when they change due to KIO operations

2013-07-28 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111776/ --- Review request for kdelibs and David Faure. Description --- This