Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

2013-12-10 Thread Mark Gaiser
Bump.. Ok to push it? On Fri, Dec 6, 2013 at 12:44 AM, Mark Gaiser mark...@gmail.com wrote: This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112463/ Review request for KDE Runtime and KDE Frameworks. By Mark Gaiser. *Updated Dec. 5, 2013,

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

2013-12-10 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112463/#review45467 --- If there are further objections/feedback, please share them.

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

2013-12-10 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112463/#review45466 --- kioslave/smb/CMakeLists.txt

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

2013-12-10 Thread Mark Gaiser
On Dec. 10, 2013, 3:54 p.m., Aleix Pol Gonzalez wrote: kioslave/smb/kio_smb_internal.cpp, line 68 http://git.reviewboard.kde.org/r/112463/diff/3/?file=222942#file222942line68 Does it really need QDir::separator()? It seems to me like everything should be '/'. could be, but i'm

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

2013-12-10 Thread Aleix Pol Gonzalez
On Dec. 10, 2013, 3:54 p.m., Aleix Pol Gonzalez wrote: kioslave/smb/kio_smb_auth.cpp, line 76 http://git.reviewboard.kde.org/r/112463/diff/3/?file=222937#file222937line76 A xD Maybe we can just remove this one? Mark Gaiser wrote: Just the A

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

2013-12-10 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112463/ --- (Updated Dec. 10, 2013, 6:51 p.m.) Review request for KDE Runtime and KDE

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

2013-12-10 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112463/#review45520 --- Ship it! - Aleix Pol Gonzalez On Dec. 10, 2013, 6:51 p.m.,

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

2013-12-10 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112463/ --- (Updated Dec. 11, 2013, 1:45 a.m.) Status -- This change has been

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

2013-12-05 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112463/ --- (Updated Dec. 5, 2013, 11:44 p.m.) Review request for KDE Runtime and KDE

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

2013-12-04 Thread Mark Gaiser
Bump. Can anyone look at this? On Sun, Dec 1, 2013 at 10:32 PM, Mark Gaiser mark...@gmail.com wrote: This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112463/ Review request for KDE Runtime and KDE Frameworks. By Mark Gaiser. *Updated Dec.

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

2013-12-04 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112463/#review45140 --- kioslave/smb/kio_smb.cpp

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

2013-12-01 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112463/ --- (Updated Dec. 1, 2013, 9:32 p.m.) Review request for KDE Runtime and KDE

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

2013-11-28 Thread Mark Gaiser
On Nov. 26, 2013, 5:12 p.m., Kevin Ottens wrote: It's been stalled for almost three months now, any chance to see progress or should it be discarded? Mark Gaiser wrote: No, it should most certainly not be disgarded. It was even working when i posted this post up for review.

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

2013-11-27 Thread Dawit Alemayehu
On Nov. 26, 2013, 5:12 p.m., Kevin Ottens wrote: It's been stalled for almost three months now, any chance to see progress or should it be discarded? Mark Gaiser wrote: No, it should most certainly not be disgarded. It was even working when i posted this post up for review.

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

2013-11-26 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112463/#review44515 --- It's been stalled for almost three months now, any chance to

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

2013-11-26 Thread Mark Gaiser
On Nov. 26, 2013, 5:12 p.m., Kevin Ottens wrote: It's been stalled for almost three months now, any chance to see progress or should it be discarded? No, it should most certainly not be disgarded. It was even working when i posted this post up for review. Dawit, how are you doing in the

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

2013-09-09 Thread Dawit Alemayehu
On Sept. 6, 2013, 1:10 p.m., Dawit Alemayehu wrote: I have several changes coming to this ioslave. Mainly I am going to implement the copyFrom and copyTo optimizations like I did for the sftp ioslave and add support for upload/download resumptions. The changes are going to come in

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

2013-09-06 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112463/#review39463 --- I have several changes coming to this ioslave. Mainly I am

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

2013-09-06 Thread Mark Gaiser
On Sept. 6, 2013, 1:10 p.m., Dawit Alemayehu wrote: I have several changes coming to this ioslave. Mainly I am going to implement the copyFrom and copyTo optimizations like I did for the sftp ioslave and add support for upload/download resumptions. The changes are going to come in

Review Request 112463: Port SMB kioslave to KF5/Qt5

2013-09-02 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112463/ --- Review request for KDE Runtime and KDE Frameworks. Description ---

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

2013-09-02 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112463/#review39205 --- kioslave/CMakeLists.txt