Re: Review Request 112982: copyToFile support for kio_smb

2013-10-25 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112982/ --- (Updated Oct. 25, 2013, 1:10 p.m.) Review request for KDE Runtime.

Re: Review Request 112982: copyToFile support for kio_smb

2013-10-23 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112982/ --- (Updated Oct. 23, 2013, 1:21 p.m.) Review request for KDE Runtime.

Re: Review Request 112982: copyToFile support for kio_smb

2013-10-23 Thread Dawit Alemayehu
On Oct. 22, 2013, 8:08 a.m., David Faure wrote: kioslave/smb/kio_smb_dir.cpp, line 45 http://git.reviewboard.kde.org/r/112982/diff/2/?file=193087#file193087line45 this TODO can be removed now, right? Yes it can, but only as soon as I implement the other half, copyFromFile. On

Re: Review Request 112982: copyToFile support for kio_smb

2013-10-23 Thread David Faure
On Oct. 22, 2013, 8:08 a.m., David Faure wrote: kioslave/smb/kio_smb_dir.cpp, line 285 http://git.reviewboard.kde.org/r/112982/diff/2/?file=193087#file193087line285 I'm pretty sure this cast is wrong. QFile::Permissions doesn't map to mode_t, at least not with a simple cast.

Re: Review Request 112982: copyToFile support for kio_smb

2013-10-22 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112982/#review42150 --- This would have been easier to review if the coding style

Re: Review Request 112982: copyToFile support for kio_smb

2013-10-05 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112982/#review41273 --- Hi Dawit, Sorry for the late reply. I will test this patch

Re: Review Request 112982: copyToFile support for kio_smb

2013-10-05 Thread Dawit Alemayehu
On Oct. 5, 2013, 12:12 p.m., Mark Gaiser wrote: Hi Dawit, Sorry for the late reply. I will test this patch out and report my findings later today. I guess this is the long awaited patch that improves the file copy speed from SMB to local. Yes, amongst the other fixes I outlined

Re: Review Request 112982: copyToFile support for kio_smb

2013-10-05 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112982/ --- (Updated Oct. 5, 2013, 3:07 p.m.) Review request for KDE Runtime.

Re: Review Request 112982: copyToFile support for kio_smb

2013-10-05 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112982/#review41277 --- Tested it. PRE patch: ~17MB/s POST patch: ~27MB/s So in

Re: Review Request 112982: copyToFile support for kio_smb

2013-10-05 Thread Dawit Alemayehu
On Oct. 5, 2013, 4:01 p.m., Mark Gaiser wrote: Tested it. PRE patch: ~17MB/s POST patch: ~27MB/s So in functionality terms this patch makes a file copy from a windows share (note: a linux machine sharing through samba, not an actual windows machine) much faster. However,

Re: Review Request 112982: copyToFile support for kio_smb

2013-10-05 Thread Mark Gaiser
On Oct. 5, 2013, 4:01 p.m., Mark Gaiser wrote: Tested it. PRE patch: ~17MB/s POST patch: ~27MB/s So in functionality terms this patch makes a file copy from a windows share (note: a linux machine sharing through samba, not an actual windows machine) much faster. However,

Re: Review Request 112982: copyToFile support for kio_smb

2013-10-05 Thread Dawit Alemayehu
On Oct. 5, 2013, 4:01 p.m., Mark Gaiser wrote: Tested it. PRE patch: ~17MB/s POST patch: ~27MB/s So in functionality terms this patch makes a file copy from a windows share (note: a linux machine sharing through samba, not an actual windows machine) much faster. However,

Re: Review Request 112982: copyToFile support for kio_smb

2013-10-05 Thread Mark Gaiser
On Oct. 5, 2013, 4:01 p.m., Mark Gaiser wrote: Tested it. PRE patch: ~17MB/s POST patch: ~27MB/s So in functionality terms this patch makes a file copy from a windows share (note: a linux machine sharing through samba, not an actual windows machine) much faster. However,

Re: Review Request 112982: copyToFile support for kio_smb

2013-10-05 Thread Dawit Alemayehu
On Oct. 5, 2013, 4:01 p.m., Mark Gaiser wrote: Tested it. PRE patch: ~17MB/s POST patch: ~27MB/s So in functionality terms this patch makes a file copy from a windows share (note: a linux machine sharing through samba, not an actual windows machine) much faster. However,

Re: Review Request 112982: copyToFile support for kio_smb

2013-10-05 Thread Mark Gaiser
On Oct. 5, 2013, 4:01 p.m., Mark Gaiser wrote: Tested it. PRE patch: ~17MB/s POST patch: ~27MB/s So in functionality terms this patch makes a file copy from a windows share (note: a linux machine sharing through samba, not an actual windows machine) much faster. However,

Re: Review Request 112982: copyToFile support for kio_smb

2013-09-29 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112982/ --- (Updated Sept. 29, 2013, 4:10 p.m.) Review request for KDE Runtime.

Review Request 112982: copyToFile support for kio_smb

2013-09-28 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112982/ --- Review request for KDE Runtime. Description --- The attach patch