On Nov. 28, 2013, 5:17 a.m., Dawit Alemayehu wrote:
konqueror/settings/kio/kproxydlg.cpp, line 295
http://git.reviewboard.kde.org/r/114105/diff/1/?file=219633#file219633line295
nitpick: no need for KSaveIOConfig here.
?. Not sure what do you mean
On Nov. 28, 2013, 5:17 a.m.,
On Nov. 28, 2013, 5:17 a.m., Dawit Alemayehu wrote:
konqueror/settings/kio/kproxydlg.cpp, line 295
http://git.reviewboard.kde.org/r/114105/diff/1/?file=219633#file219633line295
nitpick: no need for KSaveIOConfig here.
Andrea Iacovitti wrote:
?. Not sure what do you mean
On Nov. 28, 2013, 5:17 a.m., Dawit Alemayehu wrote:
konqueror/settings/kio/kproxydlg.cpp, line 444
http://git.reviewboard.kde.org/r/114105/diff/1/?file=219633#file219633line444
This does not make sense. I explicitly check show me the value and you
uncheck it as a result of me
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114105/#review44690
---
Ship it!
Minus this change =
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114105/#review44709
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114105/
---
(Updated Nov. 28, 2013, 4:16 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114105/#review44646
---
konqueror/settings/kio/kproxydlg.cpp
