Re: Review Request 114479: Select the newly created bookmark folder as the current item

2014-02-12 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114479/#review49637 --- This review has been submitted with commit

Re: Review Request 114479: Select the newly created bookmark folder as the current item

2013-12-24 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114479/#review46109 --- Much better, but... :) kio/bookmarks/kbookmarkdialog.h

Re: Review Request 114479: Select the newly created bookmark folder as the current item

2013-12-24 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114479/ --- (Updated Dec. 24, 2013, 2:26 p.m.) Review request for kdelibs and David

Re: Review Request 114479: Select the newly created bookmark folder as the current item

2013-12-24 Thread Dawit Alemayehu
On Dec. 24, 2013, 8:14 a.m., David Faure wrote: kio/bookmarks/kbookmarkdialog.cc, line 350 https://git.reviewboard.kde.org/r/114479/diff/3/?file=227047#file227047line350 this method could now call the other one with an empty selectGroup, to remove the code duplication, right?

Re: Review Request 114479: Select the newly created bookmark folder as the current item

2013-12-24 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114479/#review46134 --- Ship it! Ship It! - David Faure On Dec. 24, 2013, 2:26

Re: Review Request 114479: Select the newly created bookmark folder as the current item

2013-12-24 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114479/ --- (Updated Dec. 24, 2013, 2:50 p.m.) Status -- This change has been

Re: Review Request 114479: Select the newly created bookmark folder as the current item

2013-12-24 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114479/#review46135 --- This review has been submitted with commit

Re: Review Request 114479: Select the newly created bookmark folder as the current item

2013-12-23 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114479/#review46065 --- kio/bookmarks/kbookmarkdialog.cc

Re: Review Request 114479: Select the newly created bookmark folder as the current item

2013-12-23 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114479/ --- (Updated Dec. 24, 2013, 6 a.m.) Review request for kdelibs and David

Re: Review Request 114479: Select the newly created bookmark folder as the current item

2013-12-23 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114479/ --- (Updated Dec. 24, 2013, 6:04 a.m.) Review request for kdelibs and David

Review Request 114479: Select the newly created bookmark folder as the current item

2013-12-15 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114479/ --- Review request for kdelibs and David Faure. Bugs: 152158

Re: Review Request 114479: Select the newly created bookmark folder as the current item

2013-12-15 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114479/ --- (Updated Dec. 15, 2013, 4:40 p.m.) Review request for kdelibs and David