Re: Review Request 116524: Make kio_ftp work with ftp server that don't support absolute path with SIZE command

2014-03-12 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116524/#review52715 --- kioslave/ftp/ftp.cpp

Re: Review Request 116524: Make kio_ftp work with ftp server that don't support absolute path with SIZE command

2014-03-12 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116524/ --- (Updated March 12, 2014, 11:36 a.m.) Review request for kdelibs and

Re: Review Request 116524: Make kio_ftp work with ftp server that don't support absolute path with SIZE command

2014-03-12 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116524/#review52744 --- Ship it! Ship It! - David Faure On March 12, 2014, 11:36

Re: Review Request 116524: Make kio_ftp work with ftp server that don't support absolute path with SIZE command

2014-03-12 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116524/#review52861 --- This review has been submitted with commit

Re: Review Request 116524: Make kio_ftp work with ftp server that don't support absolute path with SIZE command

2014-03-12 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116524/ --- (Updated March 13, 2014, 5:05 a.m.) Status -- This change has been

Re: Review Request 116524: Make kio_ftp work with ftp server that don't support absolute path with SIZE command

2014-03-11 Thread Dawit Alemayehu
On March 5, 2014, 7:47 a.m., David Faure wrote: kioslave/ftp/ftp.cpp, line 2275 https://git.reviewboard.kde.org/r/116524/diff/2/?file=251597#file251597line2275 This is surely wrong. If you're in /home/dfaure (as the CWD would be, by default, on non-anonymous FTP)

Re: Review Request 116524: Make kio_ftp work with ftp server that don't support absolute path with SIZE command

2014-03-06 Thread Dawit Alemayehu
On March 5, 2014, 7:47 a.m., David Faure wrote: kioslave/ftp/ftp.cpp, line 2275 https://git.reviewboard.kde.org/r/116524/diff/2/?file=251597#file251597line2275 This is surely wrong. If you're in /home/dfaure (as the CWD would be, by default, on non-anonymous FTP)

Re: Review Request 116524: Make kio_ftp work with ftp server that don't support absolute path with SIZE command

2014-03-04 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116524/#review52013 --- kioslave/ftp/ftp.cpp

Re: Review Request 116524: Make kio_ftp work with ftp server that don't support absolute path with SIZE command

2014-03-02 Thread David Faure
On March 2, 2014, 12:14 a.m., Dawit Alemayehu wrote: I am curious if stripping the leading / and sending a relative path with the SIZE command would work for every FTP server? It's worth a try. I took at look at the very old svn history, and it has just always been an absolute path, we

Re: Review Request 116524: Make kio_ftp work with ftp server that don't support absolute path with SIZE command

2014-03-02 Thread Dawit Alemayehu
On March 2, 2014, 12:14 a.m., Dawit Alemayehu wrote: I am curious if stripping the leading / and sending a relative path with the SIZE command would work for every FTP server? David Faure wrote: It's worth a try. I took at look at the very old svn history, and it has just always

Re: Review Request 116524: Make kio_ftp work with ftp server that don't support absolute path with SIZE command

2014-03-02 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116524/ --- (Updated March 3, 2014, 12:16 a.m.) Review request for kdelibs and David

Re: Review Request 116524: Make kio_ftp work with ftp server that don't support absolute path with SIZE command

2014-03-01 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116524/#review51562 --- I am curious if stripping the leading / and sending a