D6674: use an initializer list instead of calling insert a million times

This revision was automatically updated to reflect the committed changes. Closed by commit R244:30b735056fa2: use an initializer list instead of calling insert a million times (authored by sitter). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D6674?vs=16635=16638#toc REPOSITORY R244

D6604: add a metainfo.yaml to make ECM a proper framework

This revision was automatically updated to reflect the committed changes. Closed by commit R240:5f6aa58b8067: add a metainfo.yaml to make ECM a proper framework (authored by sitter). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE

D6700: disable compiler warning on testing deprecated function

sitter created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. TEST PLAN builds and doesn't warn anymore REPOSITORY R244 KCoreAddons BRANCH no-testwarning REVISION DETAIL https://phabricator.kde.org/D6700

D6700: disable compiler warning on testing deprecated function

sitter added a reviewer: mpyne. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D6700 To: sitter, mpyne Cc: #frameworks

D6672: add KAboutLicense::spdx and introduce orLater qualification

sitter updated this revision to Diff 16694. sitter added a comment. BC constructor addition + change to enum for orlater as suggested + switch param orders to take license, then restriction, then kaboutdata kaboutdata looks and feels idiomatically like a qobject parent which also is

D6624: do not crash qaccessible by causing a resize in a resize event

sitter added a comment. In https://phabricator.kde.org/D6624#126465, @cfeck wrote: > > It probably does. > > Were you able to test? I would prefer the simpler patch. I cannot test it, because my system does not have accessibility enabled. Yes, I did not manage to crash it

D6624: do not crash qaccessible by causing a resize in a resize event

sitter added a comment. In https://phabricator.kde.org/D6624#126503, @cfeck wrote: > If you are sure that your fix is "correct", then please remove the comment. From reading it, it looks like a workaround for a Qt bug. It is a workaround. It crashes because the life time of the

D6624: do not crash qaccessible by causing a resize in a resize event

sitter added a comment. In https://phabricator.kde.org/D6624#126506, @cfeck wrote: > Let's say someone fixes the referenced Qt bug, and we are at a point requiring that Qt version anyway. Are you going to remove the workaround? Anyone who happens to stumble upon it can.

D6672: add KAboutLicense::spdx and introduce orLater qualification

sitter updated this revision to Diff 16858. sitter added a comment. - do not use ctor delegation, can't use that in kf5 yet - eliminate the "partial" private ctor, instead call the full private ctor from the partial public ctors. this results in defaults being implemented in the public

D6624: do not crash qaccessible by causing a resize in a resize event

This revision was automatically updated to reflect the committed changes. Closed by commit R236:ca40063c4e49: do not crash qaccessible by causing a resize in a resize event (authored by sitter). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D6624?vs=16502=16860#toc REPOSITORY R236

D6793: adopt new KAboutLicense::spdx

sitter added a dependent revision: D6794: assert the testpackage appstream data validates. REPOSITORY R290 KPackage REVISION DETAIL https://phabricator.kde.org/D6793 To: sitter, sebas, apol Cc: #frameworks

D6793: adopt new KAboutLicense::spdx

sitter added a reviewer: apol. REPOSITORY R290 KPackage REVISION DETAIL https://phabricator.kde.org/D6793 To: sitter, sebas, apol Cc: #frameworks

D6793: adopt new KAboutLicense::spdx

sitter created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Previously we'd use the verbatim License key of the kpackage desktop file as license in appstream. This is however incorrect since

D6793: adopt new KAboutLicense::spdx

This revision was automatically updated to reflect the committed changes. Closed by commit R290:f2127b122bd1: adopt new KAboutLicense::spdx (authored by sitter). REPOSITORY R290 KPackage CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6793?vs=16935=17078 REVISION DETAIL

D6793: adopt new KAboutLicense::spdx

sitter added a comment. Ping? REPOSITORY R290 KPackage REVISION DETAIL https://phabricator.kde.org/D6793 To: sitter, sebas, apol Cc: #frameworks

D6794: assert the testpackage appstream data validates

This revision was automatically updated to reflect the committed changes. Closed by commit R290:cd4ec70f3539: assert the testpackage appstream data validates (authored by sitter). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D6794?vs=16936=17079#toc REPOSITORY R290 KPackage CHANGES

D6672: add KAboutLicense::spdx and introduce orLater qualification

This revision was automatically updated to reflect the committed changes. Closed by commit R244:107a7fd1a3c0: add KAboutLicense::spdx and introduce orLater qualification (authored by sitter). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE

D5557: fix basename handling of po files

sitter created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY get_filename_component(... ... NAME_WE) gets the name without the *longest* extension. in case of 'org.kde.plasma.kittens.po' that would

D5557: fix basename handling of po files

This revision was automatically updated to reflect the committed changes. Closed by commit R249:7bce4e812836: fix basename handling of po files (authored by sitter). REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5557?vs=13728=13770 REVISION DETAIL

D7008: Don't export internal helper executables

sitter added subscribers: habacker, sandsmark, sitter. sitter added a comment. As per the if below the proposed change it is used for cross compiling. Subscribing original author and committer. (kind of off topic: This code should really be changed to use the `KF5_HOST_TOOLING` we

D7094: Include a module for finding qml imports as runtime dependencies

sitter added inline comments. INLINE COMMENTS > apol wrote in ECMFindQMLModule.cmake.in:30 > Doing find_program for now. The right fix would be to change Qt to export the > `qmlplugindump` target. You still need to do "something" if qmlplugindump isn't found. Print a `message(WARNING` and/or

D7094: Include a module for finding qml imports as runtime dependencies

sitter accepted this revision. sitter added a comment. This revision is now accepted and ready to land. Oh it's gorgeous! REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D7094 To: apol, #build_system, #frameworks, sitter Cc: dfaure, aacid

anyone interested in working on a KIO slave on libcloudstorage?

Hola! I've just been talking to Jean-Baptiste Kempf from VideoLAN about their new cloud library libcloudstorage [1] which is apparently fairly usable now and supports a whole bunch of main stream file storage clouds. We are thinking that a KIO slave based on this could be really awesome and give

D7008: Don't export internal helper executables

sitter added a comment. In https://phabricator.kde.org/D7008#133644, @sitter wrote: > https://phabricator.kde.org/source/kconfig/browse/master/KF5ConfigConfig.cmake.in;023e3ecfe985e09f786134fc28793d24383998f8$11 when not xcompiling the targets are fairly useless and don't need to get

D7008: Don't export internal helper executables

sitter added a comment. In https://phabricator.kde.org/D7008#133764, @vkrause wrote: > I assume installation is done for cross-compilation, yes. For Yocto this wouldn't even be necessary though, we manually inject the host executables into the -dev packages there, for this it only

D7094: Include a module for finding qml imports as runtime dependencies

sitter added a comment. qmlplugindump not being found needs to be handled somehow. Other than that only minor nitpicks. (as always I'd also be more confident if it had a test case ;)) INLINE COMMENTS > ECMFindQMLModule.cmake.in:30 > + > +execute_process(COMMAND qmlplugindump

D7008: Don't export internal helper executables

sitter added a subscriber: apol. sitter added a comment. In https://phabricator.kde.org/D7008#133756, @habacker wrote: > In https://phabricator.kde.org/D7008#133755, @sitter wrote: > > > In https://phabricator.kde.org/D7008#133644, @sitter wrote: > > > > >

D7216: refactor kpackagetool away from stringy options

sitter created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY A notable advantage of qcommandlineoption is that using the objects the compiler makes sure that everyone is talking about the same option.

Re: relocatable kdoctools

On Tue, Aug 22, 2017 at 10:18 PM, Luigi Toscano <luigi.tosc...@tiscali.it> wrote: > Harald Sitter wrote: >> Ahoy ahoy >> >> I've just stumbled upon a rather puzzling situation with kdoctools. It >> has code branching to turn its assets relocatable [1] (i.e. reso

Re: relocatable kdoctools

On Tue, Aug 22, 2017 at 10:47 PM, Ralf Habacker wrote: > Hi, > > I'm using the following patch to cross build kdoctools for windows > >

Re: Requiem for Pure C++ plasmoid, and QML plugin... again :S

You may wish to note that plasma-devel is a more on-point mailing list for plasma widget questions. Also, you can model xml using qml exclusively [0]. Should you opt not to, what you need to do is write one plugin, not two. If you want to go the custom plugin route have a look at [1] for example.

Re: Elisa is in kdereview

On Wed, Jun 21, 2017 at 11:15 PM, Matthieu Gallien wrote: > Hello, > On mercredi 21 juin 2017 23:01:23 CEST Albert Astals Cid wrote: >> El divendres, 16 de juny de 2017, a les 22:44:03 CEST, Matthieu Gallien va >> >> escriure: >> > Hello, >> > >> > Elisa is now in

projects api alpha

I finally got annoyed with the obscenely large xml file we had for projects and wrote a RESTful api to replace it. https://projects.kde.org/api/ https://cgit.kde.org/sysadmin/projects-api.git/ Usage example https://cgit.kde.org/releaseme.git/commit?id=d5ae8f9b3a56b0521e84b6e5955faecb6e6099c0

extra-cmake-modules in kdesupport?

Is there a reason ECM's project is placed in kdesupport rather than frameworks? https://cgit.kde.org/sysadmin/repo-metadata.git/tree/projects/kdesupport/extra-cmake-modules Seems a bit fishy at best and practically means that if ECM ever were to get translations it wouldn't inherit the

Re: projects api alpha

stable now On Wed, May 24, 2017 at 5:57 PM, Harald Sitter <sit...@kde.org> wrote: > I finally got annoyed with the obscenely large xml file we had for > projects and wrote a RESTful api to replace it. > > https://projects.kde.org/api/ > https://cgit.kde.org/sysadmin/projec

D5741: Fix test when compiling from a tarball

sitter accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D5741 To: apol, #frameworks, joselema, sitter Cc: #build_system

Re: extra-cmake-modules in kdesupport?

On Sat, Jun 3, 2017 at 11:32 AM, David Faure <fa...@kde.org> wrote: > On mardi 30 mai 2017 16:18:42 CEST Aleix Pol wrote: >> On Tue, May 30, 2017 at 4:10 PM, Luigi Toscano <luigi.tosc...@tiscali.it> > wrote: >> > On Tuesday, 30 May 2017 16:06:56 CEST Harald Sitt

D6767: simplify setContents by letting Qt do more of the work

This revision was automatically updated to reflect the committed changes. Closed by commit R236:c0b452358397: simplify setContents by letting Qt do more of the work (authored by sitter). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE

Re: qqc2-desktop-style as framework

On Mon, Sep 11, 2017 at 4:16 PM, Marco Martin wrote: > On Sun, Sep 10, 2017 at 3:41 PM, David Faure wrote: >> Sounds OK to me, get it moved to frameworks/ so it can be included in the >> next >> release. >> >> I notice there are no unittests (but that's always

Re: qqc2-desktop-style as framework

Mh > set(CMAKE_LIBRARY_OUTPUT_DIRECTORY I don't think that will do for production. "This property specifies the directory into which library target files should be built. Multi-configuration generators (VS, Xcode) append a per-configuration subdirectory to the specified directory." I *think*

Re: relocatable kdoctools

On Tue, Aug 22, 2017 at 11:32 AM, Ben Cooksley <bcooks...@kde.org> wrote: > On Tue, Aug 22, 2017 at 9:25 PM, Harald Sitter <sit...@kde.org> wrote: >> Ahoy ahoy > > Hi Harald, > >> >> I've just stumbled upon a rather puzzling situation with kdoctools. I

relocatable kdoctools

Ahoy ahoy I've just stumbled upon a rather puzzling situation with kdoctools. It has code branching to turn its assets relocatable [1] (i.e. resolve paths relative rather than hardcode their location). Now the weird bit about this is that it is only used on windows. The reason this puzzles me is

D7462: [kiocore] assert that klauncher is running or not

sitter added a comment. LGTM. Also can confirm this fixes the original problem of defunct kfileopen dialogs. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7462 To: bshah, #frameworks, sitter, dfaure

falcon has no bugzilla product

I literally can't file bug reports :(

D7462: [kiocore] assert that klauncher is running or not

sitter added a comment. You committed `(... && getuid() != reply)` rather than `||`. We'll want a fork in either scenario, so this should be `||` as suggested by David. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7462 To: bshah, #frameworks, sitter, dfaure

D7430: Add unit test

sitter added a reviewer: dfaure. sitter added a subscriber: Frameworks. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7430 To: chinmoyr, dfaure Cc: #frameworks

D7216: refactor kpackagetool away from stringy options

This revision was automatically updated to reflect the committed changes. Closed by commit R290:9597930a4596: refactor kpackagetool away from stringy options (authored by sitter). REPOSITORY R290 KPackage CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7216?vs=17926=19045 REVISION

Re: relocatable kdoctools

On Thu, Aug 24, 2017 at 3:20 PM, Ralf Habacker wrote: > 10. The conclusion of 9. is that it might also be a solution on windows > to patch only all generated files after 3. and before 4. Hm, I may be missing a piece of the puzzle in my mind, but it appears to me this

Re: relocatable kdoctools

On Sun, Aug 27, 2017 at 8:37 PM, Luigi Toscano wrote: > Even without the if branch it would be still complicated. Ah! I think I get the complexity now. At build time we need to run our tools already and so the dtd/xsl need to be able to resolve the paths, hence the

D5032: drop examples dir

This revision was automatically updated to reflect the committed changes. Closed by commit R308:5ea3c8759505: drop examples dir (authored by sitter). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D5032?vs=12428=19968#toc REPOSITORY R308 KRunner CHANGES SINCE LAST UPDATE

D8825: do not show edit bookmarks action if keditbookmarks is not installed

sitter created this revision. sitter added a reviewer: Frameworks. Restricted Application added a project: Frameworks. REVISION SUMMARY keditbookmarks lives in applications, making it very likely that it is not installed. this does already raise an error window explaining that the binary is

D8824: port from deprecated KAuthorized::authorizeKAction to authorizeAction

sitter created this revision. sitter added a reviewer: Frameworks. Restricted Application added a project: Frameworks. REVISION SUMMARY authorizeKAction is internally calling authorizeAction, so simply switch the function calls to the new name fixes excessive deprecation warnings getting

D8825: do not show edit bookmarks action if keditbookmarks is not installed

This revision was automatically updated to reflect the committed changes. Closed by commit R294:5dffdee21f20: do not show edit bookmarks action if keditbookmarks is not installed (authored by sitter). REPOSITORY R294 KBookmarks CHANGES SINCE LAST UPDATE

Re: Frameworks and pkgconfig files

On Wed, Nov 29, 2017 at 9:43 AM, Christophe Giboudeaux wrote: > Hello, > > in https://bugs.kde.org/386933, the bug reporter mentions the pkgconfig file > name shall match the library one. I cannot find any such requirement. It is *suggested* to have one config per lib with

D9299: Introduce INSTALL_PREFIX_SCRIPT to easily set up prefixes

sitter requested changes to this revision. sitter added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > KDEInstallDirs.cmake:699 > +if(INSTALL_PREFIX_SCRIPT) > +file(WRITE ${CMAKE_BINARY_DIR}/prefix.sh " > +export

D9299: Introduce INSTALL_PREFIX_SCRIPT to easily set up prefixes

sitter accepted this revision. sitter added a comment. This revision is now accepted and ready to land. I currently can't do a testbuild, but the code looks good now. If we want to iterate on the concept further I think we should do it separately, no sense holding up this diff from

D8848: do not install development tool to aggregate desktop files

This revision was automatically updated to reflect the committed changes. Closed by commit R304:f4f245325cc0: do not install development tool to aggregate desktop files (authored by sitter). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8848?vs=22469=22505

Re: What controls the default ordering of which application handles an opened file?

On Thu, Nov 16, 2017 at 4:24 AM, Nate Graham wrote: > Howdy all, > I'm working on adding Krita file support to Gwenview > (https://phabricator.kde.org/D8751) and my patch works, but has the side > effect of causing Krita files to prefer being opened in Gwenview rather than

D8848: do not install development tool to aggregate desktop files

sitter created this revision. sitter added reviewers: Frameworks, whiting, gregormi. Restricted Application added a project: Frameworks. REVISION SUMMARY it's not useful in production REPOSITORY R304 KNewStuff BRANCH master REVISION DETAIL https://phabricator.kde.org/D8848 AFFECTED

D8825: do not show edit bookmarks action if keditbookmarks is not installed

sitter updated this revision to Diff 22443. sitter added a comment. rebased REPOSITORY R294 KBookmarks CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8825?vs=22379=22443 BRANCH master REVISION DETAIL https://phabricator.kde.org/D8825 AFFECTED FILES

D8824: port from deprecated KAuthorized::authorizeKAction to authorizeAction

This revision was automatically updated to reflect the committed changes. Closed by commit R294:378808a575d7: port from deprecated KAuthorized::authorizeKAction to authorizeAction (authored by sitter). REPOSITORY R294 KBookmarks CHANGES SINCE LAST UPDATE

releaseme new requirement: non-conflicting files on case-insensitive FS/OS

Guten Abend Everyone! To aid with use of our tarballs on Windows and case-insensitive file systems, releaseme now makes sure [1] that the tarballs it generates are safe to use in such contexts. As this is a major problem for pretty much every source tarball as it prevents people from doing

D8825: do not show edit bookmarks action if keditbookmarks is not installed

sitter added inline comments. INLINE COMMENTS > apol wrote in kbookmarkmenu_p.h:42 > Why not in the cpp file? It's used in 2 difference cpps. REPOSITORY R294 KBookmarks REVISION DETAIL https://phabricator.kde.org/D8825 To: sitter, #frameworks Cc: apol

D9240: [RunnerManager] Use QThread::idealThreadCount() instead of going through Solid

sitter added a comment. It seems to me the only reason we have custom code to set the max count is because of that `maxThreads` config entry. An entry for which I can't see any UI backing, so it's borderline usless to begin with. The qMin then destroys any remaining use that entry may have

D9240: [RunnerManager] Don't mess with ThreadWeaver thread count

sitter accepted this revision. sitter added a comment. I love it REPOSITORY R308 KRunner REVISION DETAIL https://phabricator.kde.org/D9240 To: broulik, #plasma, #frameworks, davidedmundson, sitter Cc: sitter, davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai,

D9295: do not treat ts-pmap-compile as exectuable

sitter created this revision. sitter added a reviewer: ilic. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY - strip shebang - make -x the script is run through add_custom_command with the explicit python

D9295: do not treat ts-pmap-compile as exectuable

This revision was automatically updated to reflect the committed changes. Closed by commit R249:54147ad2fc2d: do not treat ts-pmap-compile as exectuable (authored by sitter). REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9295?vs=23802=23803 REVISION DETAIL

Re: DragonPlayer

It's maintained just fine https://phabricator.kde.org/R259:b06cd9e1fbacefabdd2c0fa61f9af39cead25d8e. It's not getting better, it's not getting worse it's getting maintained at the level it is at. What Nate is asking for is an active developer... and that is an entirely different problem which

Re: Frameworks release schedule?

On Wed, Oct 25, 2017 at 10:35 AM, laurent Montel wrote: > Hi, > I send this email to kde-frameworks-devel > > It's the correct ML for having an answer about it > > Regards. > > Le mercredi 25 octobre 2017, 09:29:58 CEST Valorie Zimmerman a écrit : >> Hello folks, with my Kubuntu

Re: Frameworks release schedule?

On Wed, Oct 25, 2017 at 10:35 AM, laurent Montel wrote: > Hi, > I send this email to kde-frameworks-devel > > It's the correct ML for having an answer about it > > Regards. > > Le mercredi 25 octobre 2017, 09:29:58 CEST Valorie Zimmerman a écrit : >> Hello folks, with my Kubuntu

Re: http://commitfilter.kde.org/ ?

See http://markmail.org/thread/hekkp2rcdvir732q http://markmail.org/thread/b6neyhjak2h4g2yd On Sun, Oct 29, 2017 at 9:47 PM, Martin Koller wrote: > Should http://commitfilter.kde.org/ still exist ? > Currently I get "unknown host" > > -- > Best regards/Schöne Grüße > > Martin >

bic in kactivities

Salut! https://cgit.kde.org/kactivities.git/commit/?id=47a4055e4d6fbf4eb826f255d040620ef23f11c1 It appears to me that this is a binary incompatible change. https://community.kde.org/Policies/Binary_Compatibility_Issues_With_C%2B%2B > You cannot...For existing functions of any type:change its

D13327: Fix conversion error when compiled against MDNSRESPONDER option

sitter added a comment. `-DQT_NO_CAST_FROM_BYTEARRAY` is a default define from `KDEFrameworkCompilerSettings.cmake`, so kdnssd should be working. The reason it wasn't is likely because most/all distributions build with avahi. Additionally, build.kde.org seems to build without avahi and

Re: duplicate icon in breeze-icons

https://phabricator.kde.org/D9781 On Wed, Jan 10, 2018 at 10:06 AM, Harald Sitter <sit...@kde.org> wrote: > Whatever's going on with that output Oo > > On Fri, Jan 5, 2018 at 10:13 AM, David Faure <fa...@kde.org> wrote: >> Hello Andreas, >> >> I'm emailin

Re: duplicate icon in breeze-icons

Whatever's going on with that output Oo On Fri, Jan 5, 2018 at 10:13 AM, David Faure wrote: > Hello Andreas, > > I'm emailing you since you committed some gnumeric icons to breeze-icons. > > CI fails because it says that > /icons/actions/24/gnumeric-formulaguru.svg > and >

D9781: do not incorrectly split spaces in paths of duplicate results

sitter created this revision. sitter added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. sitter requested review of this revision. REVISION SUMMARY use kcoreaddons to split fdupes output. fdupes outputs `/space\

D9781: do not incorrectly split spaces in paths of duplicate results

This revision was automatically updated to reflect the committed changes. Closed by commit R266:08ddec40bf89: do not incorrectly split spaces in paths of duplicate results (authored by sitter). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE

D9807: autotests: do not incorrectly split spaces in paths of duplicate results

sitter accepted this revision. This revision is now accepted and ready to land. BRANCH master REVISION DETAIL https://phabricator.kde.org/D9807 To: dfaure, sitter, apol Cc: cfeck, #frameworks

D9888: Make kdesu work when PWD is /usr/bin

sitter accepted this revision. sitter added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > suprocess.cpp:122 > > -QByteArray command; > -if (d->superUserCommand == QLatin1String("sudo")) { > -command = __PATH_SUDO; > -} else { > -

D10044: actually install the new animations context

sitter created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. sitter requested review of this revision. REVISION SUMMARY https://phabricator.kde.org/R266:495829b2b0fea458bfa01a996d23181d254e3521 introduced a new

D10046: unset maintainer

sitter created this revision. sitter added a reviewer: apol. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. sitter requested review of this revision. REVISION SUMMARY Alex isn't really active right now, so untag him as maintainer and

D10044: actually install the new animations context

This revision was automatically updated to reflect the committed changes. Closed by commit R266:c6fcf84e1ac8: actually install the new animations context (authored by sitter). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10044?vs=25807=25810 REVISION

Re: Dependent review requests

On Thu, Jan 25, 2018 at 3:00 PM, Michael Heidelbach wrote: > Hi! > > When I do > > git checkout -b A origin/master > > (changes) > > git checkout -b B A > > (changes) > > > git checkout A > > arc diff > > git checkout B > > arc diff > > Will phabricator show the relation of A

D10716: handle wrong password when using sudo which asks for another password

sitter added a comment. As mentioned on IRC I think this would benefit greatly from some unit testing as that line check is dangerously close to requiring mental gymnastics to read. AT a glance, all that's needed is writing stub sudo/su helpers and a test asserting outcome of

D7008: Don't export internal helper executables

sitter added a comment. In https://phabricator.kde.org/D7008#185897, @apol wrote: > Or as @dfaure says, don't install at all, because I don't see who uses this. Or remove altogether? The helpers are used by sonnet at build time, so to cross compile sonnet you need the helpers

D10716: handle wrong password when using sudo which asks for another password

sitter added a comment. Restricted Application edited subscribers, added: kde-frameworks-devel; removed: Frameworks. ping ping ping REPOSITORY R299 KDESu REVISION DETAIL https://phabricator.kde.org/D10716 To: jriddell, sitter Cc: kde-frameworks-devel, michaelh, ngraham, bruns,

D10716: handle wrong password when using sudo which asks for another password

sitter requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R299 KDESu REVISION DETAIL https://phabricator.kde.org/D10716 To: jriddell, sitter Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14397: Support libcanberra for audio notification

sitter added a comment. In D14397#299073 , @rjvbb wrote: > > That's reinventing the wheel to a point. > > Creating Qt after Gtk or vice-versa was also reinventing the wheel to a much larger extent - so is adding more and more OS features

D14397: Support libcanberra for audio notification

sitter added a comment. In D14397#298557 , @ngraham wrote: > Impressive work, Kai! However I rather like the idea of improving QTMultiMedia's sound handling features rather than working around the lack of them by using a different library.

D14397: Port audio notification to libcanberra

sitter added a comment. Canberra's primary advantage over phonon is that it can directly use pulseaudio/alsa, bypassing the entire sound system middleware madness and leveraging PA's builtin caching mechanism. i.e. if a sound notification is played a bunch of times it will be cached

D14397: Port audio notification to libcanberra

sitter added a comment. In D14397#298420 , @rjvbb wrote: > I didn't think of this before, but do you actually need a 3rd party library for playing alert sounds? In D14397#298350 , @sitter

D14397: Port audio notification to libcanberra

sitter added a comment. In D14397#298420 , @rjvbb wrote: > > According to its website "It comes with several backends (ALSA, PulseAudio, OSS, GStreamer, null)" > > Which are all either Linux-specific or *nix-desktop oriented with ties to

D14397: Support libcanberra for audio notification

sitter accepted this revision. sitter added a comment. This revision is now accepted and ready to land. Well, I still think the result handling is more complicated than it needs to be, but whatever. LGTM for landing after 5.49 tagging (expected August 4th IIRC).

D14397: Support libcanberra for audio notification

sitter requested changes to this revision. sitter added a comment. This revision now requires changes to proceed. Code looks mostly ok. As discussed on IRC my main concern is that the current code ignores the return values of just about every ca_* method. This is a bit problematic from a

Re: Kdiff3 release.

this should help https://community.kde.org/ReleasingSoftware On Thu, Aug 2, 2018 at 9:25 AM Michael Reeves wrote: > > That's what I'm looking at doing. The translation need some minor updating. > In particular the docs were changed to correct some obsolete information > regarding windows and

os-release parser?

konnichiwa A while ago I wrote a class to parse /etc/os-release. Should we maybe add this functionality to some framework? If so, which? https://cgit.kde.org/kinfocenter.git/tree/Modules/about-distro/src/OSRelease.cpp

D12493: Require NetworkManager 1.4.0 and newer

sitter accepted this revision. This revision is now accepted and ready to land. Herald added a subscriber: kde-frameworks-devel. REPOSITORY R282 NetworkManagerQt BRANCH master REVISION DETAIL https://phabricator.kde.org/D12493 To: jgrulich, #frameworks, sitter Cc: kde-frameworks-devel,

kio slaves + kcrash + drkonqi

Hey I am a bit confused about crash handling in kio slaves. As in: it's not working the way it should be working and I don't know why it is the way it is. The debugging faq [1] suggest that this should behave like KCrash. by default all crashes get drkonqi'd unless you set KDE_DEBUG at which

D14045: [Containment] Don't load containment actions with plasma/containment_actions KIOSK restriction

sitter added a comment. lgtm. There's a legacy mention of this kiosk key in ContainmentInterface which should be nukable in favor of this change. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D14045 To: broulik, #plasma, mart, sitter Cc:

D11236: [KCrash] Establish socket to allow change of ptrace scope

sitter added a subscriber: lepagevalleeemmanuel. REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D11236 To: croick, #frameworks Cc: lepagevalleeemmanuel, kde-frameworks-devel, sitter, michaelh, ngraham, bruns

<    1   2   3   4   5   6   7   8   9   10   >