[kphotoalbum/feature/remove-kipi] doc: Remove plugin system from handbook.

2020-05-03 Thread Johannes Zarl-Zierl
Git commit b0f3f70194dc1eef0354d4dfc43871af7b510bb7 by Johannes Zarl-Zierl. Committed on 03/05/2020 at 23:32. Pushed by johanneszarl into branch 'feature/remove-kipi'. Remove plugin system from handbook. Note: the handbook is very seriously out of date anyways. At this point it would probably be

D29353: Update copyright

2020-05-03 Thread Toni Asensi Esteve
asensi accepted this revision as: asensi. asensi added a comment. Everything in that proposal looks good to me. Thanks for all the work! > Test Plan > Check if any file is missing the update. After applying the patch: In krusader/compat.h I find "Copyright (C) 2019 Krusader

D29006: Allow to copy or move selection to the other split view

2020-05-03 Thread Antonio Prcela
aprcela marked 2 inline comments as done. REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D29006 To: aprcela, #dolphin, elvisangelaccio, ngraham, meven, dfaure Cc: yurchor, kde-doc-english, dfaure, meven, kfm-devel, azyx, nikolaik, pberestov, iasensio, aprcela, fprice,

D29006: Allow to copy or move selection to the other split view

2020-05-03 Thread Antonio Prcela
aprcela marked 2 inline comments as done. aprcela added a comment. @elvisangelaccio wrote: copySelectedItems() is already used to copy to clipboard. See L365. @meven I uploadaded the currently working code (to check if destination is writable for the copy function). But I can't get

D29006: Allow to copy or move selection to the other split view

2020-05-03 Thread Antonio Prcela
aprcela updated this revision to Diff 81826. aprcela marked 2 inline comments as done. aprcela added a comment. - Add check if destination is writable for copy - Move copy/move logic to DolphinTabWidget - Set Shift+F5 /F6 instead of CTRL+F5

[kdesrc-build] /: Document new behaviour of git-desired-protocol

2020-05-03 Thread Johan Ouwerkerk
Git commit 66e5e69208792ccf00fcd8d396d290a01b24c70c by Johan Ouwerkerk. Committed on 03/05/2020 at 15:03. Pushed by mpyne into branch 'master'. Document new behaviour of git-desired-protocol M +6-4doc/index.docbook M +1-1kdesrc-build-setup

D29006: Allow to copy or move selection to the other split view

2020-05-03 Thread Elvis Angelaccio
elvisangelaccio requested changes to this revision. elvisangelaccio added a comment. The feature looks reasonable to me. INLINE COMMENTS > dolphinmainwindow.cpp:670-684 > +void DolphinMainWindow::copyToOtherView() > +{ > +const DolphinTabPage* tabPage = m_tabWidget->currentTabPage(); > +

D29006: Allow to copy or move selection to the other split view

2020-05-03 Thread Antonio Prcela
aprcela added a comment. In D29006#662058 , @meven wrote: > Just a check to add. @meven See inline comment In D29006#662094 , @dfaure wrote: > Actually, wait, I vote against Ctrl+F5

D29006: Allow to copy or move selection to the other split view

2020-05-03 Thread David Faure
dfaure requested changes to this revision. dfaure added a comment. Actually, wait, I vote against Ctrl+F5 /Ctrl+F6 because these shortcuts, by default, in Plasma, are bound to "Switch to Desktop 5" and "Switch to Desktop 6". Shift+F5

D29006: Allow to copy or move selection to the other split view

2020-05-03 Thread Méven Car
meven requested changes to this revision. meven added a comment. This revision now requires changes to proceed. I tested the patch, works nicely. Just a check to add. Drag'n drop is quite easy in the use case it covers, so wait for @ngraham and/or @elvisangelaccio feedback before

D29006: Allow to copy or move selection to the other split view

2020-05-03 Thread Antonio Prcela
aprcela added a comment. In D29006#661964 , @dfaure wrote: > Looks good to me. > > Did you test copying and moving directories as well? Should work, but just to make sure. > > I'll let the Dolphin developers/maintainers decide on whether

D29006: Allow to copy or move selection to the other split view

2020-05-03 Thread David Faure
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Looks good to me. Did you test copying and moving directories as well? Should work, but just to make sure. I'll let the Dolphin developers/maintainers decide on whether the