Re: Review Request: Remove QFSFileEngine useage from Phonon five.

2012-10-21 Thread Jon Severinsson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106974/ --- (Updated Oct. 21, 2012, 9:59 a.m.) Review request for KDE Frameworks and

Re: Review Request: Remove QFSFileEngine useage from Phonon five.

2012-10-21 Thread Jon Severinsson
On Oct. 21, 2012, 10:30 a.m., Harald Sitter wrote: Changing the behavior of a function to that extent seems unwise to me, plus it allows even further misuse of the function. One should only ever have local files thrown at that function, hence why I think Phonon 5 should not have that

Review Request: Fix ObjectDescriptionModel*::staticMetaObject initialization on Qt5.

2012-10-21 Thread Jon Severinsson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106976/ --- Review request for KDE Frameworks and Phonon. Description --- The

Re: Review Request: Remove QFSFileEngine useage from Phonon five.

2012-10-21 Thread Harald Sitter
On Oct. 21, 2012, 10:30 a.m., Harald Sitter wrote: phonon/mediasource.cpp, line 58 http://git.reviewboard.kde.org/r/106974/diff/2/?file=91573#file91573line58 documentation on why path and url would be useful Jon Severinsson wrote: I thought it self explanatory, we need the

Re: Review Request: Remove QFSFileEngine useage from Phonon five.

2012-10-21 Thread Jon Severinsson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106974/ --- (Updated Oct. 21, 2012, 2 p.m.) Review request for KDE Frameworks and