Re: Review Request 112527: Clean up KEmoticons framework (prior to splitting)

2013-09-06 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112527/#review39452 --- staging/kemoticons/src/core/kemoticonsprovider.h

Re: Review Request 111938: Allow installing both qca2 and qca3

2013-09-06 Thread David Faure
On Sept. 1, 2013, 5:16 p.m., David Faure wrote: Looks fine to me. Ivan Romanov wrote: I don't agree with this patch. I didn't get any notification about this. So I very ask you before do any changes in cmake rules talk with me. It is important for me. Holy... and here I was,

Build failed in Jenkins: plasma-framework_master_qt5 #693

2013-09-06 Thread KDE CI System
See http://build.kde.org/job/plasma-framework_master_qt5/693/changes Changes: [notmart] use plasma components [notmart] use native text rendering -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on

Plasma Frameworks 5 article

2013-09-06 Thread Ho Wan Chan
Hello David, Kevin and the KDE Frameworks 5 developers, We at the KDE Promotion Team are working on an article to explain the benefits of KDE Frameworks 5 (which is different from the Dot article we posted yesterday, that is about the release cycle). We would like to know who currently are

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

2013-09-06 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112463/#review39463 --- I have several changes coming to this ioslave. Mainly I am

Re: Plasma Frameworks 5 article

2013-09-06 Thread David Faure
On Friday 06 September 2013 14:39:07 Sebastian Kügler wrote: Hey Howard, Thanks for the excellent article published yesterday! On Friday, September 06, 2013 20:20:24 Ho Wan Chan wrote: We at the KDE Promotion Team are working on an article to explain the benefits of KDE Frameworks 5

Re: Review Request 112559: Port the remaining uses of KIO::NetAccess to KIO/Jobs

2013-09-06 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112559/ --- (Updated Sept. 6, 2013, 2:28 p.m.) Status -- This change has been

Review Request 112559: Port the remaining uses of KIO::NetAccess to KIO/Jobs

2013-09-06 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112559/ --- Review request for KDE Frameworks and David Faure. Description ---

Re: Review Request 112559: Port the remaining uses of KIO::NetAccess to KIO/Jobs

2013-09-06 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112559/ --- (Updated Sept. 6, 2013, 3:10 p.m.) Review request for KDE Frameworks and

Build failed in Jenkins: plasma-framework_master_qt5 #694

2013-09-06 Thread KDE CI System
See http://build.kde.org/job/plasma-framework_master_qt5/694/changes Changes: [notmart] experiment support for panel auto resize -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 2 in workspace

Build failed in Jenkins: plasma-framework_master_qt5 #695

2013-09-06 Thread KDE CI System
See http://build.kde.org/job/plasma-framework_master_qt5/695/changes Changes: [notmart] fix size hints propagation -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 2 in workspace

Re: Review Request 112281: Allow setting a custom highligher on the spell check decorator

2013-09-06 Thread David Edmundson
On Sept. 1, 2013, 8:31 a.m., David Faure wrote: tier1/sonnet/src/ui/spellcheckdecorator.h, line 42 http://git.reviewboard.kde.org/r/112281/diff/2/?file=185151#file185151line42 Missing documentation (in particular about the ownership being transferred to the decorator) hmm,

Re: Review Request 112281: Allow setting a custom highligher on the spell check decorator

2013-09-06 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112281/ --- (Updated Sept. 6, 2013, 6:42 p.m.) Review request for KDE Frameworks.

Re: Review Request 112281: Allow setting a custom highligher on the spell check decorator

2013-09-06 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112281/ --- (Updated Sept. 6, 2013, 5:53 p.m.) Review request for KDE Frameworks.

Re: Review Request 112281: Allow setting a custom highligher on the spell check decorator

2013-09-06 Thread David Faure
On Sept. 1, 2013, 8:31 a.m., David Faure wrote: tier1/sonnet/src/ui/spellcheckdecorator.h, line 42 http://git.reviewboard.kde.org/r/112281/diff/2/?file=185151#file185151line42 Missing documentation (in particular about the ownership being transferred to the decorator) hmm,

Re: Review Request 112559: Port the remaining uses of KIO::NetAccess to KIO/Jobs

2013-09-06 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112559/#review39476 --- khtml/ecma/xmlhttprequest.cpp

Review Request 112571: enable clearButton in kpassworddialog

2013-09-06 Thread Wojciech Kapuscinski
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112571/ --- Review request for KDE Frameworks. Description --- enable

Re: Review Request 112281: Allow setting a custom highligher on the spell check decorator

2013-09-06 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112281/#review39491 --- Looks ok to me, apart from the formatting of the documentation

Re: Review Request 112519: trim KStyle

2013-09-06 Thread Wojciech Kapuscinski
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112519/ --- (Updated Sept. 6, 2013, 3:11 p.m.) Review request for KDE Frameworks.

Re: Review Request 111938: Allow installing both qca2 and qca3

2013-09-06 Thread Ivan Romanov
On Sept. 1, 2013, 5:16 p.m., David Faure wrote: Looks fine to me. Ivan Romanov wrote: I don't agree with this patch. I didn't get any notification about this. So I very ask you before do any changes in cmake rules talk with me. It is important for me. David Faure wrote:

Review Request 112560: Remove KNotification dependency in KCompletion

2013-09-06 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112560/ --- Review request for KDE Frameworks. Description --- Drop

Review Request 112574: Reorganizing knewstuff framework

2013-09-06 Thread Jeremy Paul Whiting
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112574/ --- Review request for KDE Frameworks. Description --- I renamed