Re: Review Request 115613: Drop platform name from default user agent string

2014-02-10 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115613/ --- (Updated Feb. 10, 2014, 9:15 a.m.) Review request for KDE Frameworks,

Review Request 115617: Don't perform XLib calls if we are not on X11

2014-02-10 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115617/ --- Review request for KDE Frameworks. Repository: kde4support Description

Re: Review Request 115613: Drop platform name from default user agent string

2014-02-10 Thread David Faure
On Monday 10 February 2014 09:15:23 Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115613/ --- (Updated

Re: Review Request 115613: Drop platform name from default user agent string

2014-02-10 Thread Ben Cooksley
On Mon, Feb 10, 2014 at 10:21 PM, David Faure fa...@kde.org wrote: On Monday 10 February 2014 09:15:23 Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115613/

Re: Review Request 115606: Ommit ontologies/ dir from installing

2014-02-10 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115606/#review49423 --- As far as I'm concerned it can be nuked. But let's wait for

Review Request 115619: Add -platform to the args and remove X specific args on non X

2014-02-10 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115619/ --- Review request for KDE Frameworks. Repository: kcrash Description

Re: Review Request 115606: Ommit ontologies/ dir from installing

2014-02-10 Thread Ivan Čukić
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115606/#review49428 --- Ship it! Commenting out is ok, but remove CMakeLists.txt

Review Request 115620: Fix build when CMAKE_SOURCE_DIR contains spaces in its path

2014-02-10 Thread Andrea Scarpino
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115620/ --- Review request for KDE Frameworks and Aurélien Gâteau. Repository:

Re: Review Request 115605: Rename plasmapkg

2014-02-10 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115605/#review49429 --- I'd rather have it names plasmapkg2, the 5 prefix sounds

kde5 in path

2014-02-10 Thread Nicolas Lécureuil
Hello, i ecm there is references to kde5 ./kde-modules/KDEInstallDirs.cmake: _set_fancy(LIBEXEC_INSTALL_DIR ${LIB_INSTALL_DIR}/kde5/libexec The install dir for libexec executables (default is ${LIB_INSTALL_DIR}/kde5/libexec))

Re: kde5 in path

2014-02-10 Thread Alex Merry
On 09/02/14 23:55, Nicolas Lécureuil wrote: ./kde-modules/KDEInstallDirs.cmake:_set_fancy(XDG_APPS_INSTALL_DIR ${SHARE_INSTALL_PREFIX}/applications/kde5 The XDG apps dir) Personally, I'm still of the view that XDG_APPS_INSTALL_DIR should just be ${SHARE_INSTALL_PREFIX}/applications; did

Re: Review Request 115540: Wrap string literals in QStringLiteral in headers so projects with QT_NO_CAST_FROM_ASCII can use them

2014-02-10 Thread Teo Mrnjavac
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115540/ --- (Updated Feb. 10, 2014, 11:39 a.m.) Review request for KDE Frameworks

Re: Review Request 115606: Ommit ontologies/ dir from installing

2014-02-10 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115606/ --- (Updated Feb. 10, 2014, 11:43 a.m.) Status -- This change has been

Re: Review Request 115606: Ommit ontologies/ dir from installing

2014-02-10 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115606/#review49432 --- This review has been submitted with commit

Re: Review Request 115605: Rename plasmapkg

2014-02-10 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115605/ --- (Updated Feb. 10, 2014, 11:45 a.m.) Review request for KDE Frameworks,

Re: Review Request 115605: Rename plasmapkg

2014-02-10 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115605/#review49433 --- Ship it! Ship It! - Sebastian Kügler On Feb. 10, 2014,

Re: Review Request 115605: Rename plasmapkg

2014-02-10 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115605/#review49435 --- This review has been submitted with commit

Re: Review Request 115605: Rename plasmapkg

2014-02-10 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115605/ --- (Updated Feb. 10, 2014, 11:53 a.m.) Status -- This change has been

Re: Review Request 115605: Rename plasmapkg

2014-02-10 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115605/#review49438 --- Ehh, the 2 doesn't make sense anymore since the plasma

Re: Review Request 115616: Add platform to qt options in KCmdLineArgs

2014-02-10 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115616/#review49439 --- Ship it! Ship It! - Aleix Pol Gonzalez On Feb. 10, 2014,

Re: Review Request 115541: Build fix for Mac OS X

2014-02-10 Thread Harald Fernengel
On Feb. 8, 2014, 10:07 a.m., David Faure wrote: Urgh, we were hoping this wouldn't be an issue. This commit would break #include attica/event.h, so it cannot go in. All namespaced frameworks do it this way already btw, see kparts for instance: -- Up-to-date:

Re: let's get ready for Google Summer of Code 2014

2014-02-10 Thread Mark Gaiser
Done: http://community.kde.org/GSoC/2014/Ideas#Revive_KioFuse.2C_fuse_support_for_KIO Lets hope a student comes by and picks that project :) All we need then is someone to mentor that. On Mon, Feb 10, 2014 at 2:47 AM, Mark Gaiser mark...@gmail.com wrote: On Mon, Feb 10, 2014 at 12:51 AM, Aleix

Review Request 115624: Rename kross man page to match binary name

2014-02-10 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115624/ --- Review request for KDE Frameworks. Repository: kross Description

Review Request 115625: Do not create NETRootInfo/NETWinInfo instances on non-x11

2014-02-10 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115625/ --- Review request for KDE Frameworks. Repository: kde4support Description

Re: Review Request 115625: Do not create NETRootInfo/NETWinInfo instances on non-x11

2014-02-10 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115625/#review49449 --- Ship it! Ship It! - David Edmundson On Feb. 10, 2014,

Re: kf5 alpha 1 : modules, versions

2014-02-10 Thread Marco Martin
On Saturday 08 February 2014, David Faure wrote: * OK if I run astyle-kdelibs in both, to harmonize coding style? (drawback: it makes forward-porting changes from 4.x harder) +1 if you can do it. + Can you add both to http://community.kde.org/Frameworks/List? This includes figuring out who

Re: kf5 alpha 1 : modules, versions

2014-02-10 Thread Ivan Čukić
the above points should be done.. only thing, in kactivities frameworks should still be merged in master (Ivan, would this be ok?) Fine by me :) (even more than 'fine') ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org

Re: kf5 alpha 1 : modules, versions

2014-02-10 Thread Marco Martin
On Monday 10 February 2014, Ivan Čukić wrote: the above points should be done.. only thing, in kactivities frameworks should still be merged in master (Ivan, would this be ok?) Fine by me :) (even more than 'fine') ok. i suppose kdesrc-build has to be updated beforehand tough to pick up

Re: Review Request 115617: Don't perform XLib calls if we are not on X11

2014-02-10 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115617/#review49452 --- Ship it! Ship It! - Alexander Richardson On Feb. 10,

Re: let's get ready for Google Summer of Code 2014

2014-02-10 Thread Vishesh Handa
On Monday, February 10, 2014 01:54:36 PM Mark Gaiser wrote: Done: http://community.kde.org/GSoC/2014/Ideas#Revive_KioFuse.2C_fuse_support_for _KIO Lets hope a student comes by and picks that project :) All we need then is someone to mentor that. Not you? -- Vishesh Handa

Re: let's get ready for Google Summer of Code 2014

2014-02-10 Thread Mark Gaiser
On Mon, Feb 10, 2014 at 4:13 PM, Vishesh Handa m...@vhanda.in wrote: On Monday, February 10, 2014 01:54:36 PM Mark Gaiser wrote: Done: http://community.kde.org/GSoC/2014/Ideas#Revive_KioFuse.2C_fuse_support_for _KIO Lets hope a student comes by and picks that project :) All we need then is

Re: let's get ready for Google Summer of Code 2014

2014-02-10 Thread Christoph Feck
On Monday 10 February 2014 16:21:34 Mark Gaiser wrote: On Mon, Feb 10, 2014 at 4:13 PM, Vishesh Handa m...@vhanda.in wrote: On Monday, February 10, 2014 01:54:36 PM Mark Gaiser wrote: Done: http://community.kde.org/GSoC/2014/Ideas#Revive_KioFuse.2C_fuse_ support_for _KIO Lets hope a

Review Request 115629: Port DrKonqi to QCommandLineParser and QCommandLineOption

2014-02-10 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115629/ --- Review request for KDE Frameworks and Jekyll Wu. Repository: kde-runtime

Re: Review Request 115629: Port DrKonqi to QCommandLineParser and QCommandLineOption

2014-02-10 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115629/#review49455 --- drkonqi/main.cpp

Re: Review Request 115629: Port DrKonqi to QCommandLineParser and QCommandLineOption

2014-02-10 Thread Aleix Pol Gonzalez
On Feb. 10, 2014, 4:14 p.m., Aleix Pol Gonzalez wrote: drkonqi/main.cpp, line 74 https://git.reviewboard.kde.org/r/115629/diff/1/?file=243089#file243089line74 You can instantiate QApplication in the stack, instead of calling new+delete. Also you probably want to

New framework: KRunner

2014-02-10 Thread Aleix Pol
Hi, During the last sprint, it was decided to split KRunner out of the plasma framework, since it seems like we want to use it but then there are a couple of alternatives. To that end, I created a new repository (kde:krunner) that contains the relevant code and I'll remove it from plasma and add

Re: Review Request 115540: Wrap string literals in QStringLiteral in headers so projects with QT_NO_CAST_FROM_ASCII can use them

2014-02-10 Thread Ivan Romanov
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115540/#review49457 --- Add explanation for #define - Ivan Romanov On Feb. 10,

Re: Review Request 115540: Wrap string literals in QStringLiteral in headers so projects with QT_NO_CAST_FROM_ASCII can use them

2014-02-10 Thread Teo Mrnjavac
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115540/ --- (Updated Feb. 10, 2014, 5:35 p.m.) Review request for KDE Frameworks and

KF5 Update Meeting 2014-w7 Reminder

2014-02-10 Thread Kevin Ottens
Hello all, Just a quick reminder: The next KF5 Update Meeting will happen on #kde-devel tomorrow at 4pm Paris time. See you there! Regards. -- Kévin Ottens, http://ervin.ipsquad.net KDAB - proud supporter of KDE, http://www.kdab.com signature.asc Description: This is a digitally signed

Re: Review Request 115540: Wrap string literals in QStringLiteral in headers so projects with QT_NO_CAST_FROM_ASCII can use them

2014-02-10 Thread Ivan Romanov
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115540/#review49463 --- Ship it! Ship It! - Ivan Romanov On Feb. 10, 2014, 11:35

Re: Review Request 115540: Wrap string literals in QStringLiteral in headers so projects with QT_NO_CAST_FROM_ASCII can use them

2014-02-10 Thread Teo Mrnjavac
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115540/ --- (Updated Feb. 10, 2014, 6:51 p.m.) Status -- This change has been

Re: Review Request 115613: Drop platform name from default user agent string

2014-02-10 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115613/#review49479 --- Well the platform name was added for compatibility with what

Re: Review Request 115613: Drop platform name from default user agent string

2014-02-10 Thread Martin Gräßlin
On Feb. 10, 2014, 8:37 p.m., Dawit Alemayehu wrote: Well the platform name was added for compatibility with what Firefox at the time. And Chromium seems to have adapted that as well. The latest stable version of Firefox (version 27) for example sends the following user agent string

Re: Review Request 115613: Drop platform name from default user agent string

2014-02-10 Thread Alexander Richardson
On Feb. 10, 2014, 8:37 p.m., Dawit Alemayehu wrote: Well the platform name was added for compatibility with what Firefox at the time. And Chromium seems to have adapted that as well. The latest stable version of Firefox (version 27) for example sends the following user agent string

Re: Review Request 115613: Drop platform name from default user agent string

2014-02-10 Thread Christoph Feck
On Feb. 10, 2014, 7:37 p.m., Dawit Alemayehu wrote: Well the platform name was added for compatibility with what Firefox at the time. And Chromium seems to have adapted that as well. The latest stable version of Firefox (version 27) for example sends the following user agent string

Review Request 115635: Make kconfig_compiler signals actually useful

2014-02-10 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115635/ --- Review request for KDE Frameworks. Repository: kconfig Description

Review Request 115634: Add kconfig_compiler autotest that checks whether signals are emitted

2014-02-10 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115634/ --- Review request for KDE Frameworks. Repository: kconfig Description

Re: Review Request 115625: Do not create NETRootInfo/NETWinInfo instances on non-x11

2014-02-10 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115625/#review49503 --- This review has been submitted with commit

Re: Review Request 115617: Don't perform XLib calls if we are not on X11

2014-02-10 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115617/#review49502 --- This review has been submitted with commit

Re: Review Request 115617: Don't perform XLib calls if we are not on X11

2014-02-10 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115617/ --- (Updated Feb. 11, 2014, 6:39 a.m.) Status -- This change has been

Re: Review Request 115616: Add platform to qt options in KCmdLineArgs

2014-02-10 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115616/#review49501 --- This review has been submitted with commit

Re: Review Request 115616: Add platform to qt options in KCmdLineArgs

2014-02-10 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115616/ --- (Updated Feb. 11, 2014, 6:39 a.m.) Status -- This change has been

Review Request 115639: Ensure X11 specific code is only called on platform X11

2014-02-10 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115639/ --- Review request for KDE Frameworks. Repository: kde4support Description

Fwd: Re: Re: HAVE_X11 usage in KIO/core

2014-02-10 Thread David Faure
-- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5 ---BeginMessage--- Well that was done for compatibility with what Firefox/Chromium. The latest stable version (version 27) sends the following user agent string: Mozilla/5.0 (X11; Linux