D25149: Add a new Template for KCM's.

ervin added a comment. What about having the template use kcfg and ManagedConfigModule as well? It'd give better behaving modules by default and is a better practice than starting without them. I'd rather have people make the conscious decision to remove them because it turns out it's a KCM

D25139: LaTeX: fix backslash delimiter in some keywords

nibags closed this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D25139 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann, jpoelen Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking,

D25139: LaTeX: fix backslash delimiter in some keywords

nibags edited the summary of this revision. REPOSITORY R216 Syntax Highlighting BRANCH latex-keys-del REVISION DETAIL https://phabricator.kde.org/D25139 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann, jpoelen Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2,

D25149: Add a new Template for KCM's.

tcanabrava updated this revision to Diff 69296. tcanabrava added a comment. - Update readme REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25149?vs=69295=69296 BRANCH kcm_template REVISION DETAIL https://phabricator.kde.org/D25149

D25149: Add a new Template for KCM's.

tcanabrava edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25149 To: tcanabrava Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25149: Add a new Template for KCM's.

tcanabrava created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. tcanabrava requested review of this revision. REVISION SUMMARY Add a new template for KCM's TEST PLAN Created a new project via KAppTemplate, compiled, run the kcm stuvb

D25132: Use an eyedropper for color-picker icons

ndavis added a comment. another set F7736364: Screenshot_20191104_154914.png F7736366: Screenshot_20191104_154930.png REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D25132

KDE CI: Frameworks » kcmutils » kf5-qt5 FreeBSDQt5.13 - Build # 34 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kcmutils/job/kf5-qt5%20FreeBSDQt5.13/34/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 04 Nov 2019 18:23:57 + Build duration: 2 hr 12 min and counting

D25139: LaTeX: fix backslash delimiter in some keywords

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. New result looks better, true! REPOSITORY R216 Syntax Highlighting BRANCH latex-keys-del REVISION DETAIL https://phabricator.kde.org/D25139 To: nibags,

D25122: embedd trigrams.map into shared library

cullmann closed this revision. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D25122 To: cullmann, dfaure, vonreth, #frameworks, vkrause Cc: nicolasfella, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25122: embedd trigrams.map into shared library

cullmann requested review of this revision. cullmann added a comment. This revision is now accepted and ready to land. Ok, then first close this. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D25122 To: cullmann, dfaure, vonreth, #frameworks, vkrause Cc:

D25143: Basic cross-compiling support for parsetrigrams

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Looks a bit more like the stuff in syntax-highlighting, guess we should try this. REPOSITORY R246 Sonnet BRANCH master REVISION DETAIL https://phabricator.kde.org/D25143 To:

KDE CI: Frameworks » kcmutils » kf5-qt5 SUSEQt5.13 - Build # 38 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kcmutils/job/kf5-qt5%20SUSEQt5.13/38/ Project: kf5-qt5 SUSEQt5.13 Date of build: Mon, 04 Nov 2019 18:23:37 + Build duration: 7 min 58 sec and counting BUILD ARTIFACTS

D25122: embedd trigrams.map into shared library

vkrause added a comment. In D25122#558385 , @cullmann wrote: > I re-scheduled the build, seems to work for me now. > > @vkrause : have you some solution to run the trigrams stuff for cross compiles, too? D25143

D25143: Basic cross-compiling support for parsetrigrams

vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY Works with or without KF5_HOST_TOOLING set. Not particularly elegant, but before spending more time on this I think

KDE CI: Frameworks » kpeople » kf5-qt5 WindowsMSVCQt5.13 - Build # 24 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kpeople/job/kf5-qt5%20WindowsMSVCQt5.13/24/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Mon, 04 Nov 2019 08:52:05 + Build duration: 8 hr 15 min and counting JUnit Tests Name:

D24843: [KDEPlatformSystemTrayIcon] Recreate deleted menu

kmaterka added a comment. Any chance to get this reviewed? :) REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D24843 To: kmaterka, apol, davidedmundson, #plasma, #frameworks, broulik, nicolasfella Cc: plasma-devel, LeGast00n,

D25067: Fix the header layouts for EntryDetails and Page components

ngraham added a comment. With that Kirigami patch, this *almost* works. There's still an empty area on the right: F7735292: Screenshot_20191104_092108.png F7735295: Screenshot_20191104_092215.png

D25067: Fix the header layouts for EntryDetails and Page components

leinir added a comment. In D25067#558557 , @ngraham wrote: > With that Kirigami patch, this *almost* works. There's still an empty area on the right: > > F7735292: Screenshot_20191104_092108.png >

D25067: Fix the header layouts for EntryDetails and Page components

leinir updated this revision to Diff 69281. leinir added a comment. Thanks to @ahiemstra for helping out with the Kirigami side :) - Switch to using layouts (and massively simplify the sizing logic) REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE

D25067: Fix the header layouts for EntryDetails and Page components

leinir added a dependency: D25141: Use a RowLayout for laying out ToolBarPageHeader. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D25067 To: leinir, ngraham, #knewstuff, #frameworks, #plasma Cc: ahiemstra, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 WindowsMSVCQt5.13 - Build # 25 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20WindowsMSVCQt5.13/25/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Sun, 03 Nov 2019 20:48:06 + Build duration: 18 hr and counting JUnit Tests

KDE CI: Frameworks » kcmutils » kf5-qt5 WindowsMSVCQt5.13 - Build # 27 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kcmutils/job/kf5-qt5%20WindowsMSVCQt5.13/27/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Sun, 03 Nov 2019 20:11:48 + Build duration: 18 hr and counting CONSOLE OUTPUT

KDE CI: Frameworks » kcmutils » kf5-qt5 FreeBSDQt5.13 - Build # 33 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kcmutils/job/kf5-qt5%20FreeBSDQt5.13/33/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 04 Nov 2019 14:08:31 + Build duration: 42 sec and counting CONSOLE OUTPUT [...truncated

KDE CI: Frameworks » kcmutils » kf5-qt5 SUSEQt5.13 - Build # 37 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kcmutils/job/kf5-qt5%20SUSEQt5.13/37/ Project: kf5-qt5 SUSEQt5.13 Date of build: Mon, 04 Nov 2019 14:08:31 + Build duration: 1 min 3 sec and counting CONSOLE OUTPUT [...truncated

D25072: Disable the restore defaults button if the KCModule says so

This revision was automatically updated to reflect the committed changes. Closed by commit R295:f2f04d67e221: Disable the restore defaults button if the KCModule says so (authored by ervin). REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25072?vs=69042=69274

D25070: Make KCModuleQml conform to the defaulted() signal

This revision was automatically updated to reflect the committed changes. Closed by commit R295:4dc999b9eba1: Make KCModuleQml conform to the defaulted() signal (authored by ervin). REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25070?vs=69040=69272

D25071: Have KCModuleProxy take care of the defaulted state

This revision was automatically updated to reflect the committed changes. Closed by commit R295:dc836403bb5d: Have KCModuleProxy take care of the defaulted state (authored by ervin). REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25071?vs=69270=69273

D25069: Adjust KCModule to also channel information about defaults

This revision was automatically updated to reflect the committed changes. Closed by commit R265:0762203eb9df: Adjust KCModule to also channel information about defaults (authored by ervin). REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE

D25071: Have KCModuleProxy take care of the defaulted state

ervin updated this revision to Diff 69270. ervin added a comment. Add missing @since markers REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25071?vs=69041=69270 REVISION DETAIL https://phabricator.kde.org/D25071 AFFECTED FILES src/kcmoduleproxy.cpp

D25069: Adjust KCModule to also channel information about defaults

ervin updated this revision to Diff 69269. ervin added a comment. Add missing @since markers REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25069?vs=69039=69269 REVISION DETAIL https://phabricator.kde.org/D25069 AFFECTED FILES src/kcmodule.cpp

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

meven updated this revision to Diff 69261. meven added a comment. Move KIO::StatJob::StatDetail(s) to KIO::StatDetail(s), wrapped old details metadata code path with KIOCORE_ENABLE_DEPRECATED_SINCE REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

Re: Notice of intention to remove tests from KCrash and KNotifications

Wouldn't the more appropriate workaround then be to disable the test on windows? On Mon, Nov 4, 2019 at 10:57 AM Ben Cooksley wrote: > > On Mon, Nov 4, 2019 at 10:53 PM David Edmundson > wrote: > > > > Given kcrashtest passes locally, can you please confirm that by > > "remove" you mean disable

D25067: Fix the header layouts for EntryDetails and Page components

leinir added a comment. In D25067#557225 , @ngraham wrote: > Now that's fixed on the main page but it's missing margins on the right side: F7702718: Screenshot_20191031_081429.png Right,

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 SUSEQt5.12 - Build # 72 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20SUSEQt5.12/72/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 04 Nov 2019 11:05:53 + Build duration: 9 min 54 sec and counting JUnit Tests Name:

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 SUSEQt5.13 - Build # 38 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20SUSEQt5.13/38/ Project: kf5-qt5 SUSEQt5.13 Date of build: Mon, 04 Nov 2019 11:05:53 + Build duration: 8 min 38 sec and counting JUnit Tests Name:

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 FreeBSDQt5.13 - Build # 37 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20FreeBSDQt5.13/37/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 04 Nov 2019 11:05:53 + Build duration: 3 min 51 sec and counting JUnit Tests

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 SUSEQt5.13 - Build # 37 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20SUSEQt5.13/37/ Project: kf5-qt5 SUSEQt5.13 Date of build: Mon, 04 Nov 2019 10:17:47 + Build duration: 7 min 47 sec and counting JUnit Tests Name:

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 FreeBSDQt5.13 - Build # 36 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20FreeBSDQt5.13/36/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 04 Nov 2019 10:17:49 + Build duration: 3 min 42 sec and counting JUnit Tests

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 SUSEQt5.12 - Build # 71 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20SUSEQt5.12/71/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 04 Nov 2019 10:17:48 + Build duration: 3 min 10 sec and counting JUnit Tests Name:

Re: Notice of intention to remove tests from KCrash and KNotifications

On Mon, Nov 4, 2019 at 10:53 PM David Edmundson wrote: > > Given kcrashtest passes locally, can you please confirm that by > "remove" you mean disable and not remove. I mean remove. This test is highly dangerous and enters into a fork loop on Windows, necessitating use of an administrator level

Re: Notice of intention to remove tests from KCrash and KNotifications

Given kcrashtest passes locally, can you please confirm that by "remove" you mean disable and not remove. David

Notice of intention to remove tests from KCrash and KNotifications

Hi all, The following is notice that the following tests have been identified as causing issues to the operation of the CI system, and as such will be subject to removal to ensure the smooth running of the CI system. The below tests cause the execution workflow to indefinitely hang in all

D25122: embedd trigrams.map into shared library

cullmann added a comment. Given I did break it, sorry for the issue at all ;=) But still, the fix is not that nice, not trigrams there at all, like before :/ REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D25122 To: cullmann, dfaure, vonreth, #frameworks, vkrause

KDE CI: Frameworks » kcrash » kf5-qt5 WindowsMSVCQt5.13 - Build # 10 - Aborted!

BUILD ABORTED Build URL https://build.kde.org/job/Frameworks/job/kcrash/job/kf5-qt5%20WindowsMSVCQt5.13/10/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Sat, 02 Nov 2019 11:43:26 + Build duration: 1 day 21 hr and counting

D24443: Add a plugin system

nicolasfella updated this revision to Diff 69253. nicolasfella added a comment. - Docs CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24443?vs=69241=69253 BRANCH arcpatch-D24443 REVISION DETAIL https://phabricator.kde.org/D24443 AFFECTED FILES src/CMakeLists.txt

KDE CI: Frameworks » kpeople » kf5-qt5 WindowsMSVCQt5.13 - Build # 23 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpeople/job/kf5-qt5%20WindowsMSVCQt5.13/23/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Sat, 02 Nov 2019 11:46:33 + Build duration: 1 day 21 hr and counting JUnit Tests

D25139: LaTeX: fix backslash delimiter in some keywords

nibags edited the summary of this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D25139 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann, jpoelen Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham,

D25139: LaTeX: fix backslash delimiter in some keywords

nibags created this revision. nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann, jpoelen. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REVISION SUMMARY BUG: 413493

D25122: embedd trigrams.map into shared library

nicolasfella added a comment. Thanks for the quick fix! REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D25122 To: cullmann, dfaure, vonreth, #frameworks, vkrause Cc: nicolasfella, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns