D27338: Provide an initial implementation for input-method-unstable-v1

apol updated this revision to Diff 78515. apol added a comment. rebase REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27338?vs=78514=78515 BRANCH arcpatch-D27338 REVISION DETAIL https://phabricator.kde.org/D27338 AFFECTED FILES

D27338: Provide an initial implementation for input-method-unstable-v1

apol marked 6 inline comments as done. apol added inline comments. INLINE COMMENTS > zzag wrote in inputmethod_interface.cpp:25 > Add Q_DECL_HIDDEN. If it makes you happy. But we're building with opt-in export symbols, it shouldn't make much of a difference. > zzag wrote in

D27338: Provide an initial implementation for input-method-unstable-v1

apol updated this revision to Diff 78514. apol marked an inline comment as done. apol added a comment. Address comments REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27338?vs=78417=78514 BRANCH arcpatch-D27338 REVISION DETAIL

D28203: Move corner fold to top right in 24 icons

ngraham accepted this revision. ngraham added a comment. Feel free to land this, @davidhurka! Very nice work. REPOSITORY R266 Breeze Icons BRANCH move-corner-fold-to-top REVISION DETAIL https://phabricator.kde.org/D28203 To: davidhurka, #vdg, ndavis, ngraham Cc: ngraham,

T12855: [Breeze Icons] Get rid of redundancy in icons-dark/

ngraham added a comment. Yeah, I was planning to. It would probably be helpful to do the cleanup first though. TASK DETAIL https://phabricator.kde.org/T12855 To: ngraham Cc: ngraham, kde-frameworks-devel, davidhurka, dmenig, manueljlin, Orage, LeGast00n, cblack, konkinartem, ian,

D28203: Move corner fold to top right in 24 icons

ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH move-corner-fold-to-top REVISION DETAIL https://phabricator.kde.org/D28203 To: davidhurka, #vdg, ndavis Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2,

D28203: Move corner fold to top right in 24 icons

ndavis added a comment. LGTM REPOSITORY R266 Breeze Icons BRANCH move-corner-fold-to-top REVISION DETAIL https://phabricator.kde.org/D28203 To: davidhurka, #vdg, ndavis Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

T12855: [Breeze Icons] Get rid of redundancy in icons-dark/

davidhurka added a comment. Can you write a bash script which copies the icon files to icons-dark/ and substitutes the colors? Apparently you know how to do that, my bash skills are a bit worse. TASK DETAIL https://phabricator.kde.org/T12855 To: davidhurka Cc: ngraham,

T12855: [Breeze Icons] Get rid of redundancy in icons-dark/

davidhurka added a comment. I have created montages of the different icons. The original files to the left, the generated to the right. (Hover the images to see the file path) There are false positives: F8199094: categories_32_applications-development.png

T12855: [Breeze Icons] Get rid of redundancy in icons-dark/

ngraham added a comment. None whatsoever. :) I suspect that most of the dark icons that are different from their light counterparts could be auto-ted and the differences are errors. So yeah, for any that aren't, the built script would simply avoid making an auto-generated version

D28128: Add force save behavior to KEntryMap

bport updated this revision to Diff 78503. bport added a comment. Take in consideration dfaure feedback. REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28128?vs=78432=78503 REVISION DETAIL https://phabricator.kde.org/D28128 AFFECTED FILES

D28128: Add force save behavior to KEntryMap

dfaure added a comment. I did some debugging. e.bForceSave is set to true at the time of doing the writeEntry("testRestore", "restore") -- or if I split this and create another KConfig instance (I thought this would fail...) it is then set while loading the file (good). The naming

D27724: Synchronise setNeedsSave between KCModule and ConfigModule in both directions

crossi added a comment. In D27724#633240 , @davidedmundson wrote: > > Unfortunately, if the user clicks on reset button at first, the apply button is disabled an stays disabled. > > I'm not sure I understand why that would happen. > >

D28203: Move corner fold to top right in 24 icons

davidhurka added inline comments. INLINE COMMENTS > ngraham wrote in acrobat.svg:2 > Yeah probably. The color is intrinsic to their brand, not something we should > re-color. Actually the 16px version of acrobat.svg //was// recolored by colorScheme-Negative. I will set the color fixed anyway.

D28203: Move corner fold to top right in 24 icons

davidhurka marked 3 inline comments as done. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28203 To: davidhurka, #vdg, ndavis Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D28203: Move corner fold to top right in 24 icons

davidhurka updated this revision to Diff 78484. davidhurka added a comment. - Give **/acrobat.svg its fixed color back REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28203?vs=78459=78484 BRANCH move-corner-fold-to-top REVISION DETAIL

D28285: [ApplicationLauncherJob] Add way to launch KServiceAction

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28285 To: broulik, #frameworks, dfaure, davidedmundson Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28203: Move corner fold to top right in 24 icons

ngraham added inline comments. INLINE COMMENTS > davidhurka wrote in acrobat.svg:2 > I realize that acrobat.svg had a fixed color, which I mistakenly replaced by > colorScheme-Negative. Shall I change that back? Yeah probably. The color is intrinsic to their brand, not something we should

D28288: [QML] Correctly watch for unregistration

This revision was automatically updated to reflect the committed changes. Closed by commit R293:26e9b4afd7dd: [QML] Correctly watch for unregistration (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28288?vs=78476=78480 REVISION DETAIL

D28288: [QML] Correctly watch for unregistration

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH config_rework REVISION DETAIL https://phabricator.kde.org/D28288 To: bruns, #baloo, ngraham, davidedmundson Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n,

D28267: [FileIndexScheduler] Update the content index progress more often

This revision was automatically updated to reflect the committed changes. Closed by commit R293:f1bb38a7a83d: [FileIndexScheduler] Update the content index progress more often (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE

D28202: [FileIndexerConfig] Replace config QString, bool pair with dedicated class

This revision was automatically updated to reflect the committed changes. Closed by commit R293:7aacb80b23cc: [FileIndexerConfig] Replace config QString,bool pair with dedicated class (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE

D28267: [FileIndexScheduler] Update the content index progress more often

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Nice work. REPOSITORY R293 Baloo BRANCH config_rework REVISION DETAIL https://phabricator.kde.org/D28267 To: bruns, #baloo, ngraham Cc: kde-frameworks-devel, hurikhan77,

D28273: Fix building breeze-icons

mardelle closed this revision. mardelle added a comment. Fixed in commit https://commits.kde.org/breeze-icons/7a7cbad866bbab362b4b27e2e283c1ff94458927 REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28273 To: mardelle, nicolasfella, ngraham Cc: ngraham,

D28202: [FileIndexerConfig] Replace config QString, bool pair with dedicated class

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D28202 To: bruns, #baloo, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, GB_2,

D28288: [QML] Correctly watch for unregistration

bruns created this revision. bruns added reviewers: Baloo, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY We wont get the serviceUnregistered signal if only the WatchForRegistration

D28260: [QML] Set the remaining time in the monitor more reliably

This revision was automatically updated to reflect the committed changes. Closed by commit R293:6eecf5e7af29: [QML] Set the remaining time in the monitor more reliably (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28260?vs=78410=78475

D28258: [TimeEstimator] Correct batch size, remove config reference

This revision was automatically updated to reflect the committed changes. Closed by commit R293:bafd84779b52: [TimeEstimator] Correct batch size, remove config reference (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28258?vs=78418=78474

D28260: [QML] Set the remaining time in the monitor more reliably

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Thanks for the explanation. REPOSITORY R293 Baloo BRANCH config_rework REVISION DETAIL https://phabricator.kde.org/D28260 To: bruns, #baloo, ngraham Cc: kde-frameworks-devel,

D28258: [TimeEstimator] Correct batch size, remove config reference

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D28258 To: bruns, #baloo, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, GB_2,

D28273: Fix building breeze-icons

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Whoops, nice catch. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28273 To: mardelle, nicolasfella, ngraham Cc: ngraham, kde-frameworks-devel, LeGast00n,

D28285: [ApplicationLauncherJob] Add way to launch KServiceAction

broulik edited the summary of this revision. broulik edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28285 To: broulik, #frameworks, dfaure, davidedmundson Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28274: [KFontChooser] Add a checkbox to toggle showing only monospaced fonts

ngraham edited the summary of this revision. ngraham added a dependency: D28271: [KFontChooser] More code cleanup. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D28274 To: ahmadsamir, #frameworks, dfaure, cfeck, apol, bport Cc: kde-frameworks-devel, LeGast00n,

D28278: Move responsiblity for creating KService to CommandLauncherJob

broulik added a dependent revision: D28285: [ApplicationLauncherJob] Add way to launch KServiceAction. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28278 To: davidedmundson Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28271: [KFontChooser] More code cleanup

ngraham added a dependent revision: D28274: [KFontChooser] Add a checkbox to toggle showing only monospaced fonts. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D28271 To: ahmadsamir, #frameworks, dfaure, cfeck, apol, bport Cc: kde-frameworks-devel, LeGast00n,

D28285: [ApplicationLauncherJob] Add way to launch KServiceAction

broulik edited the test plan for this revision. broulik added a dependency: D28278: Move responsiblity for creating KService to CommandLauncherJob. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28285 To: broulik, #frameworks, dfaure, davidedmundson Cc:

D28285: [ApplicationLauncherJob] Add way to launch KServiceAction

broulik updated this revision to Diff 78470. broulik added a comment. - Assert REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28285?vs=78466=78470 REVISION DETAIL https://phabricator.kde.org/D28285 AFFECTED FILES src/gui/applicationlauncherjob.cpp

D27540: KCModule: Indicate when a setting has been changed from the default or previous value

ervin added a comment. In D27540#629380 , @ervin wrote: > In D27540#629362 , @ndavis wrote: > > > Is it possible to align all of the reset buttons like a column? > > > Why I'm not surprised.

D27540: KCModule: Indicate when a setting has been changed from the default or previous value

ervin edited the test plan for this revision. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D27540 To: ervin, ngraham, davidedmundson, meven, crossi, bport, #vdg, ndavis Cc: alexde, ndavis, iasensio, davidre, kde-frameworks-devel, LeGast00n, cblack, GB_2,

D27840: Introduce SettingState* elements to ease KCM writing

ervin updated this revision to Diff 78469. ervin added a comment. Have the indicators line up vertically automatically when applicable REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27840?vs=77848=78469 REVISION DETAIL

D28285: [ApplicationLauncherJob] Add way to launch KServiceAction

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Excellent idea! I'm glad to see that the class design allows these kinds of things. INLINE COMMENTS > applicationlauncherjob.cpp:57 > +d->m_service.detach(); > +if

D27540: KCModule: Indicate when a setting has been changed from the default or previous value

ervin updated this revision to Diff 78468. ervin added a comment. Have the indicators vertically line up automatically REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27540?vs=77847=78468 REVISION DETAIL https://phabricator.kde.org/D27540

D28285: [ApplicationLauncherJob] Add way to launch KServiceAction

broulik created this revision. broulik added reviewers: Frameworks, dfaure, davidedmundson. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY This offers convenience API for launching a specific

D28278: Move responsiblity for creating KService to CommandLauncherJob

davidedmundson added inline comments. INLINE COMMENTS > broulik wrote in kprocessrunner.cpp:119 > I //think// we can still end up with a `null` `service` through > `ApplicationLauncherJob`? I don't think so, or at least, it would be crashing already. The constructor with the KService::Ptr

D28278: Move responsiblity for creating KService to CommandLauncherJob

davidedmundson updated this revision to Diff 78463. davidedmundson added a comment. rebase, fix icon REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28278?vs=78451=78463 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28278 AFFECTED FILES

D28278: Move responsiblity for creating KService to CommandLauncherJob

davidedmundson marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28278 To: davidedmundson Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27883: Register spawned applications as an independent cgroups

This revision was automatically updated to reflect the committed changes. Closed by commit R241:a7d91ea3f0df: Register spawned applications as an independent cgroups (authored by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D27883?vs=78288=78462#toc REPOSITORY R241

D28203: Move corner fold to top right in 24 icons

davidhurka marked an inline comment as done. davidhurka added inline comments. INLINE COMMENTS > acrobat.svg:2 > -http://www.w3.org/2000/svg; width="22" height="22"> > - > - I realize that acrobat.svg had a fixed color, which I mistakenly replaced by colorScheme-Negative. Shall I change that

D28279: Fix build

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R241:68f677e234e9: Fix build (authored by davidedmundson). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D28203: Move corner fold to top right in 24 icons

davidhurka updated this revision to Diff 78459. davidhurka added a comment. - Fix symlinks: make relative REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28203?vs=78305=78459 BRANCH move-corner-fold-to-top REVISION DETAIL

D28278: Move responsiblity for creating KService to CommandLauncherJob

broulik added a comment. Lovely simplification INLINE COMMENTS > kprocessrunner.cpp:119 > { > -if (service && !service->entryPath().isEmpty() > +if (!service->entryPath().isEmpty() > && !KDesktopFile::isAuthorizedDesktopFile(service->entryPath())) > { I //think// we

D28279: Fix build

davidedmundson created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. TEST PLAN Compiles REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D28279 AFFECTED

D28278: Move responsiblity for creating KService to CommandLauncherJob

davidedmundson created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY KProcessRunner had two code paths for if data was part of the KService or if it was separate pars. This

D27902: smb: figure out the best host to use for the UDS_URL

sitter added a comment. I've actually had a better idea! Well kinda and it may be trickier to do. We could move the resolution dance to actual resolution time so it stops having impact on discovery. i.e. we just always use `"smb://" + m_prettyName + ".local"` as UDS_URL for discovery.

D27873: sftp: do not show creation time when we do not know it

This revision was automatically updated to reflect the committed changes. Closed by commit R320:b13449a13b00: sftp: do not show creation time when we do not know it (authored by sitter). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27873?vs=78352=78444

D27872: sftp: fix partial transfer resuming when copying to local

This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit R320:8a04e1009130: sftp: fix partial transfer resuming when copying to local (authored by sitter). CHANGED PRIOR TO

Re: Problems in KWayland causes by API and ABI compatibility promises

Hi, On 3/23/20 4:44 PM, David Edmundson wrote: Yeah, I feel that's what kwayland was originally going for. Seat, for example, does a lot of dispatching and logic internally. Then it drifted into being just wrappers. We do need to answer that question definitively otherwise we'll be forever

Re: Problems in KWayland causes by API and ABI compatibility promises

Hi, On 3/24/20 4:35 PM, Aleix Pol wrote: We can decide what we want for KF6 and act accordingly. If for example, we were to split kwayland into kwaylandclient and kwaylandserver and the latter be in plasma, we could consider putting new code in KWin or a shared repository. I was also thinking

Re: Problems in KWayland causes by API and ABI compatibility promises

I'll take care of it. It's still fixable within KF5 in the usual way. Let's follow up specifics of this on bug 419222 so we can keep this thread about the more general strategy. But it serves as a nice example to the type of problem we're facing. David

Re: Problems in KWayland causes by API and ABI compatibility promises

Hi, On 3/24/20 6:55 PM, David Edmundson wrote: I just had a near miss with XdgOutputV1(version2) which luckily we were able to easily guard. Had the spec claimed that in version2 sending xdg_output.name was mandatory we would have been completely screwed. Unfortunately, I have bad news. We're

D28274: [KFontChooser] Add a checkbox to toggle showing only monospaced fonts

ahmadsamir updated this revision to Diff 78441. ahmadsamir added a comment. Depends on D28271 REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28274?vs=78440=78441 BRANCH l-monospace-checkbox REVISION DETAIL

D28274: [KFontChooser] Add a checkbox to toggle showing only monospaced fonts

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, cfeck, apol, bport. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY The use case is applications where the user is usually interested in monospaced/fixe-width

D28273: Fix building breeze-icons

mardelle created this revision. mardelle added a reviewer: nicolasfella. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mardelle requested review of this revision. REVISION SUMMARY Trying to build breeze icons fails on the 24px icons generations with

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.12 - Build # 119 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.12/119/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 25 Mar 2020 09:38:23 + Build duration: 15 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.14 - Build # 4 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.14/4/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Wed, 25 Mar 2020 09:38:22 + Build duration: 9 min 17 sec and counting JUnit Tests Name:

D28263: [autotests/client] Set event queue on registry

This revision was automatically updated to reflect the committed changes. Closed by commit R127:939be7791c41: [autotests/client] Set event queue on registry (authored by davidedmundson). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28263?vs=78413=78434

D28220: Switch to using Kirigami's ShadowedRectangle

leinir marked 8 inline comments as done. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D28220 To: leinir, #knewstuff, #frameworks, #plasma, ahiemstra, broulik, mart, #vdg Cc: davidedmundson, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D28220: Switch to using Kirigami's ShadowedRectangle

leinir added inline comments. INLINE COMMENTS > ahiemstra wrote in EntryScreenshots.qml:134 > The x and y offsets should be 0 by default, so there's little reason to > specify that I'd say. Ha, yes, quite, setting defaults does seem a little silly ;) REPOSITORY R304 KNewStuff REVISION

D28271: [KFontChooser] More code cleanup

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, cfeck, apol, bport. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY - Simplfy the layout by removing the splitter, the goal was to allow resizing the font

D28128: Add force save behavior to KEntryMap

bport updated this revision to Diff 78432. bport added a comment. - fix when entry is a string (entry=) lead to empty string not fallback to default value - can't find a way to use bReverted / bDeleted without bForceSave because bReverted is set when we call revertEntry and at this time we

D28220: Switch to using Kirigami's ShadowedRectangle

leinir updated this revision to Diff 78430. leinir added a comment. Address comment by @ahiemstra - Remove some unneeded values REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28220?vs=78342=78430 BRANCH switch-to-kirigami-shadowedrectangle

D28221: Don't write default value to configuration file when default value came from /etc/* file

bport planned changes to this revision. bport added a comment. Change will be planed (firstly fix https://phabricator.kde.org/D28128) REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D28221 To: bport, ervin, dfaure, davidedmundson Cc: kde-frameworks-devel, LeGast00n,

D27338: Provide an initial implementation for input-method-unstable-v1

zzag added inline comments. INLINE COMMENTS > display.cpp:49 > +#include "inputmethod_interface.h" > + > Stray new line. Please remove it. > inputmethod_interface.cpp:25 > + > +class InputMethodContextInterface::Private : public > QtWaylandServer::zwp_input_method_context_v1 > +{ Add

D28223: Add "Stat" prefix to StatDetails Enum entries

meven added a comment. In D28223#633824 , @meven wrote: > Using enum class would need a bunch of added code such as described http://blog.bitwigglers.org/using-enum-classes-as-type-safe-bitmasks/ > I like it a lot more, this adds quite a lot

D28223: Add "Stat" prefix to StatDetails Enum entries

This revision was automatically updated to reflect the committed changes. Closed by commit R241:36038b904f68: Add Stat prefix to StatDetails Enum entries (authored by meven). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28223?vs=78401=78429 REVISION DETAIL

D27951: Allow users to change dropAction to MoveAction through kdeglobals

trmdi updated this revision to Diff 78427. trmdi added a comment. Improve the symlink case, any symlink is considered as on the same device with any destination. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27951?vs=78426=78427 BRANCH add-dndToMove