D28902: CopyJob: when stat'ing the dest, use StatBasic.

meven added a comment. Fix and test coming REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28902 To: dfaure, meven Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D28902: CopyJob: when stat'ing the dest, use StatBasic.

meven added a comment. In D28902#671260 , @ngraham wrote: > @dfaure git bisect says this caused https://bugs.kde.org/show_bug.cgi?id=421213. > > After fixing, maybe we should get a test for that use case? I see the issue, because we

D27844: Store and fetch complete view config in and from session config

dhaumann added a comment. I suggest to revert, and send a notification with the change to kde-distro-packa...@kde.org to avoid that many users break their configuration. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D27844 To: kossebau, #kate, loh.tar,

D29711: Create kcmshell.openSystemSettings() and kcmshell.openInfoCenter() functions

ngraham added a comment. In D29711#670503 , @ltoscano wrote: > If the scope of this change is just about Plasma applet, of course systemsettings is going to be around. Yes the scope of this change is purely for Plasma applets; look at

D29483: [knewfilemenu] Show inline warning when creating items with leading or trailing spaces

ngraham added a comment. Ping. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D29483 To: ngraham, #frameworks, #vdg, cfeck Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29502: kwidgetsaddons: Add a named colors support in KColorCombo.

araujoluis added a reviewer: VDG. REPOSITORY R236 KWidgetsAddons BRANCH named_color_support REVISION DETAIL https://phabricator.kde.org/D29502 To: araujoluis, tcanabrava, patrickelectric, hindenburg, ngraham, #vdg Cc: cblack, broulik, cfeck, kde-frameworks-devel, LeGast00n, michaelh,

D28902: CopyJob: when stat'ing the dest, use StatBasic.

ngraham added a comment. @dfaure git bisect says this caused https://bugs.kde.org/show_bug.cgi?id=421213. After fixing, maybe we should get a test for that use case? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28902 To: dfaure, meven Cc: ngraham,

D29739: Add 48px places icons

ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. I have to say, I'm very impressed overall. There are a few things I'd like to see changed though: folder-documents should use a single page, not the copy icon F8320517:

D29740: [PC3 Button] Don't remain in a pressed state after press

ndavis added a comment. In D29740#671221 , @filipf wrote: > The more I think about this the more it feels like a workaround. Presuming QQC2's behavior of leaving a pressed button focused after press is correct, perhaps we are at fault for

D29740: [PC3 Button] Don't remain in a pressed state after press

filipf added a comment. The more I think about this the more it feels like a workaround. Presuming QQC2's behavior of leaving a pressed button focused after press is correct, perhaps we are at fault for providing the same svg for `focus-background` and `pressed`. REPOSITORY R242 Plasma

D29739: Add 48px places icons

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Looks fantastic to me. All good now, @ndavis? REPOSITORY R266 Breeze Icons BRANCH 48px-places (branched from master) REVISION DETAIL https://phabricator.kde.org/D29739 To:

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.14 - Build # 105 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/105/ Project: kf5-qt5 SUSEQt5.14 Date of build: Thu, 14 May 2020 18:26:34 + Build duration: 6 min 57 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 603 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/603/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 14 May 2020 18:26:34 + Build duration: 6 min 9 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 113 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/113/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Thu, 14 May 2020 18:26:34 + Build duration: 4 min 51 sec and counting JUnit Tests Name:

D29738: Fix service file specifying 'Run in terminal' giving an error code 100

This revision was automatically updated to reflect the committed changes. Closed by commit R241:6452a34cf01d: Fix service file specifying Run in terminal giving an error code 100 (authored by marten). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D29739: Add 48px places icons

manueljlin added a comment. Everything should be good now, I think REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D29739 To: manueljlin, #vdg Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D29739: Add 48px places icons

manueljlin updated this revision to Diff 82873. manueljlin marked 2 inline comments as done. manueljlin added a comment. Made 64x64 scalable again and tweaked the comments. REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29739?vs=82866=82873 BRANCH

D29747: Deprecate AbstractBarcode::minimumSize() also for the compiler

kossebau added a comment. In D29747#671169 , @svuorela wrote: > I think we should wait a bit with formally deprecating. I like add the new, wait a bit, then deprecate. So you propose to also remove the `@deprecated` from the API dox?

D29747: Deprecate AbstractBarcode::minimumSize() also for the compiler

svuorela added a comment. I think we should wait a bit with formally deprecating. I like add the new, wait a bit, then deprecate. Also, while I might be a unconventional developer, but given this is a tier 1 library, I'm often hand patching the required ECM version to a much lower

D29739: Add 48px places icons

ndavis added inline comments. INLINE COMMENTS > index.theme:477 > > #32x32 - Scalable - For folder icons >!!!ONLY!!!< - Scalable to the > following sizes: 64x64 (default), 32x32, 128x128, 256x256 - > DO_NOT_USE_ANYWHERE_ELSE - Color > [places/32] This and the other comments should

D29739: Add 48px places icons

ndavis added a comment. In D29739#671163 , @manueljlin wrote: > should line 495 "## Status" actually be removed? No. Phabricator doesn't keep the original context for those comments if you change the code they were referring to.

D29739: Add 48px places icons

manueljlin added a comment. should line 495 "## Status" actually be removed? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D29739 To: manueljlin, #vdg Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D29738: Fix service file specifying 'Run in terminal' giving an error code 100

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Nice! In addition to the bugfix, calling resultingArguments() only once is a definite improvement, given everything that happens in there. I didn't realize we were calling it twice.

D29034: Add systemd user service file for kded

broulik updated this revision to Diff 82868. broulik added a comment. - fix exec - add slice REPOSITORY R297 KDED CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29034?vs=80722=82868 REVISION DETAIL https://phabricator.kde.org/D29034 AFFECTED FILES src/CMakeLists.txt

D29739: Add 48px places icons

manueljlin updated this revision to Diff 82866. manueljlin added a comment. Oops. Actually set 64x64 to fixed and remove MinSize and MaxSize REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29739?vs=82865=82866 BRANCH 48px-places (branched from

D29739: Add 48px places icons

manueljlin updated this revision to Diff 82865. manueljlin marked 7 inline comments as done. manueljlin added a comment. Fixed the issues from the comments REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29739?vs=82861=82865 BRANCH 48px-places

D29739: Add 48px places icons

ndavis added a comment. I just noticed, the new auto-generated 24px places icons aren't being used because the places/24 folder isn't in the index.theme files, but that's outside the scope of this patch. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D29739

D29739: Add 48px places icons

ndavis added a comment. comments apply to both files INLINE COMMENTS > index.theme:105 > > >

D29739: Add 48px places icons

manueljlin updated this revision to Diff 82861. manueljlin added a comment. Include places/48 REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29739?vs=82824=82861 BRANCH 48px-places (branched from master) REVISION DETAIL

D29569: Fix computing display geometry on multi-monitor HiDPI setups on X11

printesoi added a comment. @zzag yes, but as per the https://doc.qt.io/qt-5/qscreen.html#availableGeometry-prop, it does not work on setups with multiple displays :) REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D29569 To: printesoi, davidedmundson, #kwin,

D29738: Fix service file specifying 'Run in terminal' giving an error code 100

ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D29738 To: marten, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29739: Add 48px places icons

ngraham added a comment. Nice work! REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D29739 To: manueljlin, #vdg Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D29740: [PC3 Button] Don't remain in a pressed state after press

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH dont-remain-pressed (branched from master) REVISION DETAIL https://phabricator.kde.org/D29740 To: filipf, davidedmundson, mart, #plasma, ngraham Cc:

D29739: Add 48px places icons

ndavis added a comment. You'll also need to update the index.theme files to include places/48 REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D29739 To: manueljlin, #vdg Cc: ndavis, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29745: look for kded as runtime dep

ngraham accepted this revision. REPOSITORY R241 KIO BRANCH kded REVISION DETAIL https://phabricator.kde.org/D29745 To: sitter, dfaure, apol, ngraham Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29739: Add 48px places icons

ngraham edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D29739 To: manueljlin, #vdg Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29743: sftp: map sftp_open error to kio error

feverfew accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras BRANCH release/20.04 REVISION DETAIL https://phabricator.kde.org/D29743 To: sitter, feverfew Cc: kde-frameworks-devel, kfm-devel, waitquietly, azyx, nikolaik, pberestov,

D27844: Store and fetch complete view config in and from session config

kossebau added a comment. Seems this change has some sideeffects I did not experience when I played with this, but which are now uncovering as it hits people usinjg KF 5.70 : config seems to write any settings, also the ones inherited from global defaults, as view-specific settings, and

D29745: look for kded as runtime dep

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH kded REVISION DETAIL https://phabricator.kde.org/D29745 To: sitter, dfaure, apol Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

KDE CI: Frameworks » kirigami » kf5-qt5 FreeBSDQt5.14 - Build # 72 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20FreeBSDQt5.14/72/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Thu, 14 May 2020 13:27:18 + Build duration: 11 min and counting JUnit Tests Name:

Re: Request for plasma framework patch release

On jeudi 14 mai 2020 15:24:57 CEST David Faure wrote: > On jeudi 14 mai 2020 13:56:50 CEST David Edmundson wrote: > > We seem to have a common crasher newly introduced in plasma-framework. A > > dozen reports in a few days. > > > > Can I ask for a plasma-framework 5.70.1. with > >

D29747: Deprecate AbstractBarcode::minimumSize() also for the compiler

kossebau added inline comments. INLINE COMMENTS > abstractbarcode.h:69 > */ > +PRISON_DEPRECATED_VERSION_BELATED(5, 71, 5, 69, "Use preferredSize() or > trueMinimumSize()") > QSizeF minimumSize() const; D29573 bringing _BELATED only landed a

D29747: Deprecate AbstractBarcode::minimumSize() also for the compiler

kossebau created this revision. kossebau added reviewers: Frameworks, svuorela, vkrause. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REPOSITORY R280 Prison BRANCH fullydeprecateminimumsize REVISION DETAIL

Re: Request for plasma framework patch release

On jeudi 14 mai 2020 13:56:50 CEST David Edmundson wrote: > We seem to have a common crasher newly introduced in plasma-framework. A > dozen reports in a few days. > > Can I ask for a plasma-framework 5.70.1. with > c215c54eced5bd0b195c208dd72bb580e65f8fe4 cherry-picked. > > Sorry. Here you go.

D29745: look for kded as runtime dep

sitter created this revision. sitter added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY kded is called over dbus to talk to the proxyscout, and also to track uidelegate

D27989: Add a new set of barcode size functions

kossebau added a comment. In D27989#670659 , @vkrause wrote: > There's two remaining users in everything covered by lxr, the Plasma clipboard (patch in review: https://phabricator.kde.org/D29478) and KDE PIM (which now depends on a sufficiently

D29743: sftp: map sftp_open error to kio error

sitter created this revision. sitter added a reviewer: feverfew. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY sftp gives out more relevant errors such as

D29634: sftp: break large writes into multiple requests

This revision was automatically updated to reflect the committed changes. Closed by commit R320:1df6174834bb: sftp: break large writes into multiple requests (authored by sitter). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29634?vs=82723=82834

Request for plasma framework patch release

We seem to have a common crasher newly introduced in plasma-framework. A dozen reports in a few days. Can I ask for a plasma-framework 5.70.1. with c215c54eced5bd0b195c208dd72bb580e65f8fe4 cherry-picked. Sorry. David

D29742: Avoid potential disconnect of all signals in IconItem

This revision was automatically updated to reflect the committed changes. Closed by commit R242:c215c54eced5: Avoid potential disconnect of all signals in IconItem (authored by davidedmundson). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D29742: Avoid potential disconnect of all signals in IconItem

ahiemstra accepted this revision. ahiemstra added a comment. This revision is now accepted and ready to land. This fixes bug 421170 for me. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D29742 To: davidedmundson, #plasma,

D29742: Avoid potential disconnect of all signals in IconItem

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY m_svgIcon can be null. disconnect(q, nullptr, nullptr,

D29740: [PC3 Button] Don't remain in a pressed state after press

filipf added a dependent revision: D29741: [Logout] Port to QQC2 and PC3. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D29740 To: filipf, davidedmundson, mart, #plasma Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29740: [PC3 Button] Don't remain in a pressed state after press

filipf edited the summary of this revision. filipf edited the test plan for this revision. filipf added reviewers: davidedmundson, mart, Plasma. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D29740 To: filipf, davidedmundson, mart, #plasma Cc:

D29740: [PC3 Button] Don't remain in a pressed state after press

filipf created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. filipf requested review of this revision. REVISION SUMMARY We have two interfering button background items right now: - surfaceNormal when it has activeFocus and is using

D29739: Add 48px places icons

manueljlin edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D29739 To: manueljlin, #vdg Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29739: Add 48px places icons

manueljlin edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D29739 To: manueljlin, #vdg Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29739: Add 48px places icons

manueljlin created this revision. manueljlin added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. manueljlin requested review of this revision. REVISION SUMMARY Everything added except for both trash icons because I couldn't figure out

D29738: Fix service file specifying 'Run in terminal' giving an error code 100

marten created this revision. marten added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. marten requested review of this revision. REVISION SUMMARY https://bugs.kde.org/show_bug.cgi?id=421374 describes how a service file

D29569: Fix computing display geometry on multi-monitor HiDPI setups on X11

zzag accepted this revision. zzag added a comment. This revision is now accepted and ready to land. In general, it's better to use QScreen::availableGeometry(). REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D29569 To: printesoi, davidedmundson, #kwin, zzag

KDE CI: Frameworks » kirigami » kf5-qt5 WindowsMSVCQt5.14 - Build # 141 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20WindowsMSVCQt5.14/141/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Thu, 14 May 2020 08:42:17 + Build duration: 2 min 11 sec and counting JUnit Tests

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.12 - Build # 462 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.12/462/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 14 May 2020 08:42:17 + Build duration: 1 min 54 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.14 - Build # 66 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.14/66/ Project: kf5-qt5 SUSEQt5.14 Date of build: Thu, 14 May 2020 08:42:17 + Build duration: 1 min 53 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kirigami » kf5-qt5 FreeBSDQt5.14 - Build # 70 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20FreeBSDQt5.14/70/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Thu, 14 May 2020 08:42:17 + Build duration: 58 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kirigami » kf5-qt5 AndroidQt5.14 - Build # 91 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20AndroidQt5.14/91/ Project: kf5-qt5 AndroidQt5.14 Date of build: Thu, 14 May 2020 08:42:17 + Build duration: 1 min 3 sec and counting

KDE CI: Frameworks » kirigami » kf5-qt5 WindowsMSVCQt5.14 - Build # 140 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20WindowsMSVCQt5.14/140/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Thu, 14 May 2020 08:38:07 + Build duration: 29 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.14 - Build # 65 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.14/65/ Project: kf5-qt5 SUSEQt5.14 Date of build: Thu, 14 May 2020 08:38:07 + Build duration: 46 sec and counting CONSOLE OUTPUT [...truncated 278

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.12 - Build # 461 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.12/461/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 14 May 2020 08:38:07 + Build duration: 52 sec and counting CONSOLE OUTPUT [...truncated 278

KDE CI: Frameworks » kirigami » kf5-qt5 FreeBSDQt5.14 - Build # 69 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20FreeBSDQt5.14/69/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Thu, 14 May 2020 08:38:07 + Build duration: 23 sec and counting CONSOLE OUTPUT [...truncated

KDE CI: Frameworks » kirigami » kf5-qt5 AndroidQt5.14 - Build # 90 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20AndroidQt5.14/90/ Project: kf5-qt5 AndroidQt5.14 Date of build: Thu, 14 May 2020 08:38:07 + Build duration: 57 sec and counting CONSOLE OUTPUT [...truncated

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 602 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/602/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 14 May 2020 07:47:06 + Build duration: 14 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 112 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/112/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Thu, 14 May 2020 07:47:07 + Build duration: 12 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.14 - Build # 104 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/104/ Project: kf5-qt5 SUSEQt5.14 Date of build: Thu, 14 May 2020 07:47:07 + Build duration: 6 min 37 sec and counting BUILD ARTIFACTS

D29634: sftp: break large writes into multiple requests

meven added a comment. In D29634#670485 , @feverfew wrote: > In D29634#670419 , @meven wrote: > > > In D29634#670377 , @ngraham wrote: > > > > > Nice

D29610: [kio_file] Handle renaming file 'A' to 'a' on FAT32 filesystems

dfaure added inline comments. INLINE COMMENTS > file_unix.cpp:1074 > > if (::rename(_src.data(), _dest.data())) { > if (auto err = execWithElevatedPrivilege(RENAME, {_src, _dest}, > errno)) { Wouldn't it be enough to just call QFile::rename here? The whole idea is: if

D27989: Add a new set of barcode size functions

vkrause added a comment. In D27989#670416 , @kossebau wrote: > > minimumSize() becomes deprecated by this, the deprecation macros will > > follow once the current users have been adjusted. > > IMHO you should add the macros from the start,

D29735: Assign "Identifier" attribute to opening double quote instead of "Comment"

dhaumann added a subscriber: cullmann. dhaumann added a comment. @cullmann could you integrate this? REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D29735 To: bewuethr, #framework_syntax_highlighting, dhaumann Cc: cullmann, dhaumann, kwrite-devel,

D29735: Assign "Identifier" attribute to opening double quote instead of "Comment"

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Good catch :) please commit REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D29735 To: bewuethr, #framework_syntax_highlighting, dhaumann Cc: