This revision was automatically updated to reflect the committed changes.
Closed by commit R287:8562ce18f1ab: Add some sanity and bounds checking
(authored by sandsmark).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D24367?vs=79917=82450#toc
REPOSITORY
R287 KImageFormats
CHANGES
aacid accepted this revision.
aacid added a comment.
This revision is now accepted and ready to land.
Looks good to me :)
REPOSITORY
R287 KImageFormats
REVISION DETAIL
https://phabricator.kde.org/D24367
To: sandsmark, aacid, cfeck
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh,
sandsmark marked 2 inline comments as done.
REPOSITORY
R287 KImageFormats
REVISION DETAIL
https://phabricator.kde.org/D24367
To: sandsmark, aacid, cfeck
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
sandsmark marked an inline comment as done.
sandsmark added inline comments.
INLINE COMMENTS
> cfeck wrote in pcx.cpp:312
> If `p` indeed could be zero, the next statements need to be in an `else`
> block (or a add a `return`).
good catch, thanks
REPOSITORY
R287 KImageFormats
REVISION
sandsmark updated this revision to Diff 79917.
sandsmark added a comment.
Added missing return.
REPOSITORY
R287 KImageFormats
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D24367?vs=67201=79917
REVISION DETAIL
https://phabricator.kde.org/D24367
AFFECTED FILES
cfeck added inline comments.
INLINE COMMENTS
> pcx.cpp:312
> +qWarning() << "Failed to get scanline for" << y << "might be out
> of bounds";
> +}
> for (int x = 0; x < header.width(); ++x) {
If `p` indeed could be zero, the next statements need to be in an `else`
sandsmark created this revision.
sandsmark added reviewers: aacid, cfeck.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
sandsmark requested review of this revision.
REVISION SUMMARY
Since QImage does sanity checking for overflows and stuff wrt. dimensions
