D25149: Add a new Template for KCM's.

2019-11-07 Thread Tomaz Canabrava
tcanabrava added a comment. In D25149#559075 , @davidedmundson wrote: > A very sensible idea. ++ > > > templates/kcm-qml/qml-plasmoid.png > > What's this about? We need a better icon. it's the icon for the `Plasmoid` template.

D25149: Add a new Template for KCM's.

2019-11-07 Thread Tomaz Canabrava
tcanabrava updated this revision to Diff 69400. tcanabrava added a comment. - Add KConfigXT REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25149?vs=69296=69400 BRANCH arcpatch-D25149 REVISION DETAIL

D25149: Add a new Template for KCM's.

2019-11-05 Thread Yuri Chornoivan
yurchor added inline comments. INLINE COMMENTS > main.qml:37 > +QQC2.Label { > +text: i18n("Exemple KCM that does nothing") > +} Typo: Exemple -> Example REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25149 To:

D25149: Add a new Template for KCM's.

2019-11-05 Thread David Edmundson
davidedmundson added a comment. A very sensible idea. ++ > templates/kcm-qml/qml-plasmoid.png What's this about? INLINE COMMENTS > main.qml:26 > +import org.kde.kcm 1.1 as KCM > +import Qt.labs.platform 1.1 > + lets not encourage this import REPOSITORY R242 Plasma Framework

D25149: Add a new Template for KCM's.

2019-11-05 Thread Carl Schwan
ognarb added a comment. Another related todo would be to update/rewrite https://techbase.kde.org/Development/Tutorials/KCM_HowTo after this template is merged and include information about it ;) REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D25149: Add a new Template for KCM's.

2019-11-04 Thread Kevin Ottens
ervin added a comment. What about having the template use kcfg and ManagedConfigModule as well? It'd give better behaving modules by default and is a better practice than starting without them. I'd rather have people make the conscious decision to remove them because it turns out it's a KCM

D25149: Add a new Template for KCM's.

2019-11-04 Thread Tomaz Canabrava
tcanabrava updated this revision to Diff 69296. tcanabrava added a comment. - Update readme REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25149?vs=69295=69296 BRANCH kcm_template REVISION DETAIL https://phabricator.kde.org/D25149

D25149: Add a new Template for KCM's.

2019-11-04 Thread Tomaz Canabrava
tcanabrava edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25149 To: tcanabrava Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25149: Add a new Template for KCM's.

2019-11-04 Thread Tomaz Canabrava
tcanabrava created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. tcanabrava requested review of this revision. REVISION SUMMARY Add a new template for KCM's TEST PLAN Created a new project via KAppTemplate, compiled, run the kcm stuvb