D25984: Load translations

broulik abandoned this revision. broulik added a comment. Looks like D27595 fixes the issue REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D25984 To: broulik, #kirigami, #frameworks, kossebau, aacid Cc: vkrause, mart,

D25984: Load translations

vkrause added a comment. In D25984#589426 , @mart wrote: > ping, what's the current status of this? There's also https://phabricator.kde.org/D27595, which might address the same/a similar issue. REPOSITORY R169 Kirigami REVISION

D25984: Load translations

sitter removed a reviewer: sitter. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D25984 To: broulik, #kirigami, #frameworks, kossebau, aacid Cc: mart, davidedmundson, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, ahiemstra

D25984: Load translations

mart added a comment. ping, what's the current status of this? REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D25984 To: broulik, #kirigami, #frameworks, kossebau, aacid, sitter Cc: mart, davidedmundson, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos,

D25984: Load translations

kossebau added a comment. In D25984#578306 , @kossebau wrote: > Hm, though now I am confused why calling this from `KirigamiPlugin::initializeEngine` fixes things for you, the static struct constructor of that startup hook technology in the lib

D25984: Load translations

broulik added a comment. I guess it builds the QML tree and evaluates the `qsTr` calls and then finds it needs an item from a plugin and loads the import and only then translates it. Subsequent controls are translated, only the ones on the initial item are not. Perhaps if we shoehorn a

D25984: Load translations

kossebau added a comment. Hm, though now I am confused why calling this from `KirigamiPlugin::initializeEngine` fixes things for you, the static struct constructor of that startup hook technology in the lib should be invoked before during loading, no? Time to go playing with the actual

D25984: Load translations

kossebau added a comment. In D25984#578299 , @broulik wrote: > Ok, so turns out, it does call it when the plugin is loaded, but the translations are only installed *after* the QML has loaded and processed. Uh, okay, that seems like

D25984: Load translations

davidedmundson added a comment. > Okay. Which app did you test with? Does it link kcoreaddons? Would poke then as well a bit, as I happen to have a related rant blog post lying around ;) ). systemsettings5 exhibits this situation REPOSITORY R169 Kirigami REVISION DETAIL

D25984: Load translations

kossebau added a comment. In D25984#578298 , @broulik wrote: > Well, whatever it is, it doesn't work. My search field isn't translated and I put breakpoints and I only get it load translations for kcoreaddons and kjobwidgets. Okay.

D25984: Load translations

broulik added a comment. Ok, so turns out, it does call it when the plugin is loaded, but the translations are only installed *after* the QML has loaded and processed. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D25984 To: broulik, #kirigami, #frameworks,

D25984: Load translations

broulik added a comment. Well, whatever it is, it doesn't work. My search field isn't translated and I put breakpoints and I only get it load translations for kcoreaddons and kjobwidgets. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D25984 To: broulik,

D25984: Load translations

kossebau added a comment. In D25984#578296 , @broulik wrote: > We don't link against Kirigami, so the startup routine stuff doesn't apply? `Q_COREAPP_STARTUP_FUNCTION` generates a static struct in the compiled code, whose constructor

D25984: Load translations

broulik added a comment. We don't link against Kirigami, so the startup routine stuff doesn't apply? And we're way after the QCoreApp constructor at this point. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D25984 To: broulik, #kirigami, #frameworks, kossebau,

D25984: Load translations

kossebau added a comment. In D25984#578291 , @broulik wrote: > Qt docs say "Adds a global function that will be called from the QCoreApplication constructor. " but when we at runtime somewhere load a QML plugin we're too late with that.

D25984: Load translations

broulik added a comment. Qt docs say "Adds a global function that will be called from the QCoreApplication constructor. " but when we at runtime somewhere load a QML plugin we're too late with that. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D25984 To:

D25984: Load translations

kossebau added a comment. > The ECM QM Loader uses Q_COREAPP_STARTUP_FUNCTION which doesn't work for things loaded as plugins like QML modules. Curious, where it exactly does it fail to work? Q_COREAPP_STARTUP_FUNCTION being nvoked during lib loading after the QApp instance exists still

D25984: Load translations

broulik added a comment. Sounds good to me lol REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D25984 To: broulik, #kirigami, #frameworks, kossebau, aacid, sitter Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, ahiemstra, davidedmundson,

D25984: Load translations

sitter added a comment. Seems a bit meh to have a verbatim copy of the auto generated functions. Perhaps it'd be better to add an option to the ECM generator to export a loader function for use in plugins? Then we could just call that from the plugin init instead of having to copy it.

D25984: Load translations

broulik edited the summary of this revision. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D25984 To: broulik, #kirigami, #frameworks, kossebau, aacid, sitter Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, ahiemstra, davidedmundson, mart,

D25984: Load translations

broulik added a reviewer: sitter. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D25984 To: broulik, #kirigami, #frameworks, kossebau, aacid, sitter Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, ahiemstra, davidedmundson, mart, hein

D25984: Load translations

broulik created this revision. broulik added reviewers: Kirigami, Frameworks, kossebau, aacid. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY The ECM QM Loader uses `Q_COREAPP_STARTUP_FUNCTION` which doesn't