D27724: Syncronise setNeedsSave between KCModule and ConfigModule in both directions

davidedmundson added a comment. > Unfortunately, if the user clicks on reset button at first, the apply button is disabled an stays disabled. I'm not sure I understand why that would happen. That means there's something else going on, and we shouldn't ship this till we understand

D27724: Syncronise setNeedsSave between KCModule and ConfigModule in both directions

davidedmundson updated this revision to Diff 78329. davidedmundson added a comment. typo fix REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27724?vs=76644=78329 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27724 AFFECTED FILES

D27724: Syncronise setNeedsSave between KCModule and ConfigModule in both directions

davidedmundson marked an inline comment as done. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D27724 To: davidedmundson, ervin Cc: ervin, meven, iasensio, crossi, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27724: Syncronise setNeedsSave between KCModule and ConfigModule in both directions

ervin requested changes to this revision. ervin added a comment. This revision now requires changes to proceed. What @meven said about the typo, otherwise LGTM indeed. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D27724 To: davidedmundson, ervin Cc: ervin, meven,

D27724: Syncronise setNeedsSave between KCModule and ConfigModule in both directions

meven added inline comments. INLINE COMMENTS > kcmoduleqml.cpp:87 > + > +// changed is also manipulated extermally by KCModule, we need to keep > the Quick implementation in sync > +// TODO KF6 remove the differed "emit changed" in KConfigModule and then > we can remove this here

D27724: Syncronise setNeedsSave between KCModule and ConfigModule in both directions

crossi added a comment. Tested as an alternative to D27944 At initialization, the apply button is enabled. Unfortunately, if the user clicks on reset button at first, the apply button is disabled an stays disabled. REPOSITORY R295 KCMUtils REVISION

D27724: Syncronise setNeedsSave between KCModule and ConfigModule in both directions

davidedmundson edited the summary of this revision. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D27724 To: davidedmundson Cc: iasensio, crossi, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27724: Syncronise setNeedsSave between KCModule and ConfigModule in both directions

davidedmundson created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY The problem occurs in the following situation: Widgets and such often change state and emit they're