D28647: Fix KIO::Scheduler::emitReparseSlaveConfiguration() to work if called twice in same process

2020-04-29 Thread Jonathan Marten
marten added a comment. I've thought about this a bit more and can't find any explanation as to why the DBus signal does not loop back to the sending process as well as all other listeners. It may be an unspecified detail of the DBus implementation that could possibly change at any time

D28647: Fix KIO::Scheduler::emitReparseSlaveConfiguration() to work if called twice in same process

2020-04-18 Thread David Faure
dfaure resigned from this revision. This revision now requires review to proceed. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28647 To: marten, #frameworks Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28647: Fix KIO::Scheduler::emitReparseSlaveConfiguration() to work if called twice in same process

2020-04-18 Thread David Faure
dfaure added a comment. Something like that, but in your pseudo-code I'm missing the call to emit self()->reparseSlaveConfiguration(QString()); "Other slaves" confuses me. This is about broadcasting to "other processes" (applications), and that each process/application (this one,

D28647: Fix KIO::Scheduler::emitReparseSlaveConfiguration() to work if called twice in same process

2020-04-16 Thread Jonathan Marten
marten added a comment. I'm happy to work on the refactoring if you think it's the right thing to do. Do you mean splitting SchedulerPrivate::slotReparseSlaveConfiguration() up into two halves, the first part (KProtocolManager::reparseConfiguration through to NetRC::self()->reload -

D28647: Fix KIO::Scheduler::emitReparseSlaveConfiguration() to work if called twice in same process

2020-04-11 Thread David Faure
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. The new code structure screams for killing the bool and just extracting the code (all of slotReparseSlaveConfiguration) to a different method, called directly from

D28647: Fix KIO::Scheduler::emitReparseSlaveConfiguration() to work if called twice in same process

2020-04-07 Thread Jonathan Marten
marten created this revision. marten added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. marten requested review of this revision. REVISION SUMMARY I've been looking at porting Konqueror's User Agent Changer plugin to current