D28854: [KRichTextWidget] Add support for headings

poboiko closed this revision. REPOSITORY R310 KTextWidgets REVISION DETAIL https://phabricator.kde.org/D28854 To: poboiko, #frameworks, mlaurent, ahmadsamir, dfaure Cc: abstractdevelop, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28854: [KRichTextWidget] Add support for headings

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. I see, thanks for the explanations. I don't mind 6 levels if that's what HTML does. REPOSITORY R310 KTextWidgets BRANCH textwidget-heading (branched from master) REVISION DETAIL

D28854: [KRichTextWidget] Add support for headings

mlaurent added inline comments. INLINE COMMENTS > poboiko wrote in krichtextedit.cpp:346 > Yes, that's true. I agree it's a bit confusing, but that's the case with HTML > too, which I had in mind (see screenshot, it's Chrome) > F8241667: scr1.png > > For

D28854: [KRichTextWidget] Add support for headings

poboiko marked 3 inline comments as done. poboiko added a comment. In D28854#649189 , @abstractdevelop wrote: > Hey, thanks for this @poboiko I used to have to implement this myself, so this will be very useful in my app, O20.Word. ;)

D28854: [KRichTextWidget] Add support for headings

abstractdevelop added a comment. Hey, thanks for this @poboiko I used to have to implement this myself, so this will be very useful in my app, O20.Word. ;) REPOSITORY R310 KTextWidgets REVISION DETAIL https://phabricator.kde.org/D28854 To: poboiko, #frameworks, mlaurent, ahmadsamir,

D28854: [KRichTextWidget] Add support for headings

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > krichtextedit.cpp:346 > +// level=2 look the same > +int sizeAdjustment = boundedLevel > 0 ? 5 - boundedLevel: 0; > + If boundedLevel is 6, the size

D28854: [KRichTextWidget] Add support for headings

mlaurent accepted this revision. mlaurent added a comment. This revision is now accepted and ready to land. Thanks REPOSITORY R310 KTextWidgets BRANCH textwidget-heading (branched from master) REVISION DETAIL https://phabricator.kde.org/D28854 To: poboiko, #frameworks, mlaurent,

D28854: [KRichTextWidget] Add support for headings

poboiko updated this revision to Diff 80202. poboiko added a comment. Added a unit-test testing for everything I could come up with (at least 4 "behavior nuances" from the commit message) Address other feedback as well (const'ify, @since version) REPOSITORY R310 KTextWidgets

D28854: [KRichTextWidget] Add support for headings

mlaurent requested changes to this revision. mlaurent added a comment. This revision now requires changes to proceed. Can you improve autotest KRichTextEditTest ? INLINE COMMENTS > krichtextedit.cpp:346 > +// level=2 look the same > +int sizeAdjustment = boundedLevel > 0 ? 5 -

D28854: [KRichTextWidget] Add support for headings

poboiko edited the test plan for this revision. REPOSITORY R310 KTextWidgets REVISION DETAIL https://phabricator.kde.org/D28854 To: poboiko, #frameworks, mlaurent, ahmadsamir, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28854: [KRichTextWidget] Add support for headings

poboiko created this revision. poboiko added reviewers: Frameworks, mlaurent, ahmadsamir, dfaure. Herald added a project: Frameworks. poboiko requested review of this revision. REVISION SUMMARY This patch adds support of different headings (essentially, HTML h1..h6 tags). Those might be