D28882: Create protocol to manage video feeds

apol added a comment. Moving to kwayland-server REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D28882 To: apol, #kwin, jgrulich, davidedmundson, zzag Cc: meven, davidedmundson, romangg, zzag, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28882: Create protocol to manage video feeds

apol abandoned this revision. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D28882 To: apol, #kwin, jgrulich, davidedmundson, zzag Cc: meven, davidedmundson, romangg, zzag, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28882: Create protocol to manage video feeds

zzag added a comment. In D28882#658780 , @apol wrote: > > In future, it might be faster to put up just the interface xml for review first. > > @davidedmundson @zzag I don't really see how it would have made a difference, you only decided

D28882: Create protocol to manage video feeds

apol added a comment. > In future, it might be faster to put up just the interface xml for review first. @davidedmundson @zzag I don't really see how it would have made a difference, you only decided to review it 7 to 10 days after I first submitted it. 路 > What about using

D28882: Create protocol to manage video feeds

zzag requested changes to this revision. zzag added a comment. This revision now requires changes to proceed. > In future, it might be faster to put up just the interface xml for review first. ++ --- What about using existing `wl_output` objects? The `add_source` event can be

D28882: Create protocol to manage video feeds

apol updated this revision to Diff 81341. apol added a comment. Address review comments REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28882?vs=81113=81341 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28882 AFFECTED FILES

D28882: Create protocol to manage video feeds

apol marked 2 inline comments as done. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D28882 To: apol, #kwin, jgrulich, davidedmundson Cc: meven, davidedmundson, romangg, zzag, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28882: Create protocol to manage video feeds

meven added inline comments. INLINE COMMENTS > screencasting.cpp:141 > +} > +void zkde_screencast_unstable_v1_removeSource(uint32_t sourceId) > override { > +auto it = std::find_if(m_sources.begin(), m_sources.end(), > [sourceId] (const ScreencastingSource ) { Missing blank

D28882: Create protocol to manage video feeds

davidedmundson added inline comments. INLINE COMMENTS > screencast.xml:46 > + > + > + add type = "destructor" so that clients calling this release the resource REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D28882 To: apol, #kwin, jgrulich,

D28882: Create protocol to manage video feeds

apol updated this revision to Diff 81113. apol added a comment. Refactor the protocol as suggested by David and Vlad REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28882?vs=80984=81113 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28882

D28882: Create protocol to manage video feeds

apol marked an inline comment as done. apol added inline comments. INLINE COMMENTS > davidedmundson wrote in screencast.xml:31 > this is racey with create. Any suggestion on how to do it better? REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D28882 To: apol, #kwin,

D28882: Create protocol to manage video feeds

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. In future, it might be faster to put up just the interface xml for review first. -- In terms of wayland protocols this is non-standard. All

D28882: Create protocol to manage video feeds

jgrulich added a comment. I have tested this and it now works as before, tested with Chromium, while checking all the values we pass to the portal and PipeWire which seem to be correct. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D28882 To: apol, #kwin,

D28882: Create protocol to manage video feeds

apol updated this revision to Diff 80984. apol added a comment. Also propagate the buffer size, it's important for the client to know what buffer size it will have. REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28882?vs=80801=80984 BRANCH master

D28882: Create protocol to manage video feeds

apol updated this revision to Diff 80801. apol added a comment. Hopefully fix the build for Jan REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28882?vs=80798=80801 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28882 AFFECTED FILES

D28882: Create protocol to manage video feeds

apol updated this revision to Diff 80798. apol added a comment. - Test Cleanup - When a resource is destroyed, emit to close all its streams REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28882?vs=80677=80798 BRANCH master REVISION DETAIL

D28882: Create protocol to manage video feeds

jgrulich added a comment. In D28882#653483 , @jgrulich wrote: > Doesn't seem to build here: > > In file included from /home/jgrulich/development/projects/kde/kwayland/src/server/screencasting_interface.cpp:7: >

D28882: Create protocol to manage video feeds

jgrulich added a comment. Doesn't seem to build here: In file included from /home/jgrulich/development/projects/kde/kwayland/src/server/screencasting_interface.cpp:7: /home/jgrulich/development/projects/kde/kwayland/src/server/screencasting_interface.h:32:121: error:

D28882: Create protocol to manage video feeds

apol updated this revision to Diff 80677. apol added a comment. Improve how we initialise the sourceId REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28882?vs=80662=80677 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28882 AFFECTED

D28882: Create protocol to manage video feeds

apol updated this revision to Diff 80662. apol added a comment. Iterate tests (which work now) and uses REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28882?vs=80658=80662 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28882 AFFECTED

D28882: Create protocol to manage video feeds

apol updated this revision to Diff 80658. apol added a comment. Fix test REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28882?vs=80637=80658 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28882 AFFECTED FILES

D28882: Create protocol to manage video feeds

apol updated this revision to Diff 80637. apol added a comment. iterate test REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28882?vs=80605=80637 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28882 AFFECTED FILES

D28882: Create protocol to manage video feeds

apol updated this revision to Diff 80605. apol added a comment. oops REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28882?vs=80604=80605 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28882 AFFECTED FILES

D28882: Create protocol to manage video feeds

apol updated this revision to Diff 80604. apol added a comment. Include server side, a test (that doesn't pass) and some renaming REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28882?vs=80411=80604 BRANCH master REVISION DETAIL

D28882: Create protocol to manage video feeds

apol updated this revision to Diff 80411. apol added a comment. Include the server side and some renames REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28882?vs=80284=80411 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28882 AFFECTED

D28882: Create protocol to manage video feeds

apol marked 2 inline comments as done. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D28882 To: apol, #kwin, jgrulich Cc: romangg, zzag, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28882: Create protocol to manage video feeds

romangg added inline comments. INLINE COMMENTS > screencast.xml:8 > + ]]> > + > + Interface names should be scoped too. Example

D28882: Create protocol to manage video feeds

jgrulich added inline comments. INLINE COMMENTS > screencast.xml:13 > + > + > + Can we switch the values to follow xdg-desktop-portal specification? See

D28882: Create protocol to manage video feeds

apol updated this revision to Diff 80284. apol added a subscriber: zzag. apol added a comment. renamed protocol as per @zzag's suggestion REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28882?vs=80278=80284 BRANCH master REVISION DETAIL

D28882: Create protocol to manage video feeds

apol added a dependent revision: D28884: screencasting: Adoption of the org_kde_plasma_video_streaming protocol. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D28882 To: apol, #kwin, jgrulich Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28882: Create protocol to manage video feeds

apol created this revision. apol added reviewers: KWin, jgrulich. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY Creates a protocol based on Pipewire that allows us to request feeds to be set up by