This revision was automatically updated to reflect the committed changes.
Closed by commit R175:97139b80e80b: Nicaragua Holidays (authored by carguello,
committed by cgiboudeaux).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D28891?vs=80322=80452#toc
REPOSITORY
R175 KHolidays
winterz accepted this revision.
winterz added a comment.
This revision is now accepted and ready to land.
other than the indentation in the .qrc file this is good to go.. tests pass
would appreciate if someone would commit this for us. (after fixing the
indentation)
REPOSITORY
R175
winterz added inline comments.
INLINE COMMENTS
> holidays.qrc:101
> plan2/holiday_mx_es
> -plan2/holiday_na_en-gb
> + plan2/holiday_na_en-gb
> plan2/holiday_nc_fr
realign the indentation
> holidays.qrc:103
> plan2/holiday_nc_fr
> +
ngraham added a comment.
You're very welcome. Thank you for the patch!
REPOSITORY
R175 KHolidays
REVISION DETAIL
https://phabricator.kde.org/D28891
To: carguello, winterz, #frameworks
Cc: ngraham, kde-frameworks-devel, #vdg, LeGast00n, cblack, michaelh, bruns
carguello added a comment.
Thank you for your time and support.
REPOSITORY
R175 KHolidays
REVISION DETAIL
https://phabricator.kde.org/D28891
To: carguello, winterz, #frameworks
Cc: ngraham, kde-frameworks-devel, #vdg, LeGast00n, cblack, michaelh, bruns
ngraham added a comment.
Great job! I'll hand it over to @winterz and other reviewers now.
REPOSITORY
R175 KHolidays
REVISION DETAIL
https://phabricator.kde.org/D28891
To: carguello, winterz, #frameworks
Cc: ngraham, kde-frameworks-devel, #vdg, LeGast00n, cblack, michaelh, bruns
carguello added a comment.
Okay, I'm confident it went through this time
REPOSITORY
R175 KHolidays
REVISION DETAIL
https://phabricator.kde.org/D28891
To: carguello, winterz, #frameworks
Cc: ngraham, kde-frameworks-devel, #vdg, LeGast00n, cblack, michaelh, bruns
carguello updated this revision to Diff 80322.
carguello added a comment.
Adding Nicaragua Holidays file back
REPOSITORY
R175 KHolidays
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28891?vs=80319=80322
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D28891
ngraham added a comment.
git add [the path to the new file you want to add]`
arc diff --update D28891
REPOSITORY
R175 KHolidays
REVISION DETAIL
https://phabricator.kde.org/D28891
To: carguello, winterz, #frameworks
Cc: ngraham, kde-frameworks-devel, #vdg, LeGast00n, cblack,
carguello added a comment.
How can I add it back? Sorry this is my first time using git and Phabricator
REPOSITORY
R175 KHolidays
REVISION DETAIL
https://phabricator.kde.org/D28891
To: carguello, winterz, #frameworks
Cc: ngraham, kde-frameworks-devel, #vdg, LeGast00n, cblack,
ngraham added a comment.
Now the new file you wanted to add is gone. :)
With Phabricator, you need to include all commits in your patch, not just the
latest one.
REPOSITORY
R175 KHolidays
REVISION DETAIL
https://phabricator.kde.org/D28891
To: carguello, winterz, #frameworks
Cc:
carguello updated this revision to Diff 80319.
carguello added a comment.
Previously messed up holidays/holidays.qrc I have fixed it now
REPOSITORY
R175 KHolidays
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28891?vs=80318=80319
BRANCH
master
REVISION DETAIL
carguello added a comment.
I think I messed up
REPOSITORY
R175 KHolidays
REVISION DETAIL
https://phabricator.kde.org/D28891
To: carguello, winterz, #frameworks
Cc: ngraham, kde-frameworks-devel, #vdg, LeGast00n, cblack, michaelh, bruns
carguello updated this revision to Diff 80318.
carguello added a comment.
Remove file extension .qrc per instructions
REPOSITORY
R175 KHolidays
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28891?vs=80309=80318
BRANCH
master
REVISION DETAIL
ngraham removed a reviewer: VDG.
REPOSITORY
R175 KHolidays
REVISION DETAIL
https://phabricator.kde.org/D28891
To: carguello, winterz, #frameworks
Cc: ngraham, kde-frameworks-devel, #vdg, LeGast00n, cblack, michaelh, bruns
ngraham added reviewers: winterz, Frameworks.
ngraham added a comment.
Thanks for the patch! You need to update the `holidays/holidays.qrc` file
too, to mention this new file that you're adding. Also I don't think you need
to have the `.qrc` extension on the file you're adding.
REPOSITORY
carguello added a reviewer: VDG.
REPOSITORY
R175 KHolidays
REVISION DETAIL
https://phabricator.kde.org/D28891
To: carguello, #vdg
Cc: kde-frameworks-devel, #vdg, LeGast00n, cblack, michaelh, ngraham, bruns
carguello created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
carguello requested review of this revision.
REVISION SUMMARY
Added file containing Nicaragua holidays in holidays/plan2/holiday_ni_es
REPOSITORY
R175 KHolidays
BRANCH
18 matches
Mail list logo
