D28902: CopyJob: when stat'ing the dest, use StatBasic.

meven added a comment. Fix at D29767 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28902 To: dfaure, meven Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D28902: CopyJob: when stat'ing the dest, use StatBasic.

meven added a comment. Fix and test coming REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28902 To: dfaure, meven Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D28902: CopyJob: when stat'ing the dest, use StatBasic.

meven added a comment. In D28902#671260 , @ngraham wrote: > @dfaure git bisect says this caused https://bugs.kde.org/show_bug.cgi?id=421213. > > After fixing, maybe we should get a test for that use case? I see the issue, because we

D28902: CopyJob: when stat'ing the dest, use StatBasic.

ngraham added a comment. @dfaure git bisect says this caused https://bugs.kde.org/show_bug.cgi?id=421213. After fixing, maybe we should get a test for that use case? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28902 To: dfaure, meven Cc: ngraham,

D28902: CopyJob: when stat'ing the dest, use StatBasic.

meven added a comment. D28947 for the StatAcl fix REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28902 To: dfaure, meven Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28902: CopyJob: when stat'ing the dest, use StatBasic.

dfaure added a comment. In D28902#650160 , @meven wrote: > So the `settings:/` , `remote:/` should return UDS_LOCAL_PATH for KIO::StatBasic, but file:/ should not . That's for sure, it's redundant for kio_file. > The code here uses

D28902: CopyJob: when stat'ing the dest, use StatBasic.

dfaure updated this revision to Diff 80462. dfaure added a comment. update comment REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28902?vs=80338=80462 BRANCH 2020_use_StatDetails REVISION DETAIL https://phabricator.kde.org/D28902 AFFECTED FILES

D28902: CopyJob: when stat'ing the dest, use StatBasic.

dfaure closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28902 To: dfaure, meven Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28902: CopyJob: when stat'ing the dest, use StatBasic.

meven added a comment. I believe that's just fine but the comment could be updated : From udsentry.h /// A local file path if the ioslave display files sitting /// on the local filesystem (but in another hierarchy, e.g. settings:/ or remote:/) UDS_LOCAL_PATH So the

D28902: CopyJob: when stat'ing the dest, use StatBasic.

meven accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D28902 To: dfaure, meven Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28902: CopyJob: when stat'ing the dest, use StatBasic.

dfaure created this revision. dfaure added a reviewer: meven. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY However the StatDetail enum doesn't specify which enum value will get us UDS_LOCAL_PATH