D29003: Use Q_EMIT and build with QT_NO_KEYWORDS

junghans added a comment. Thank you for committing! Although I recently gained push rights, I did not have time yet to dig into the details of how to create/push commit respecting the KDE standards etc. Next time, I'll try on my own :) REPOSITORY R275 KItemModels REVISION DETAIL

D29003: Use Q_EMIT and build with QT_NO_KEYWORDS

kossebau closed this revision. REPOSITORY R275 KItemModels REVISION DETAIL https://phabricator.kde.org/D29003 To: junghans, kossebau, dfaure, apol Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29003: Use Q_EMIT and build with QT_NO_KEYWORDS

kossebau added a comment. Looking at D28915 , seems you are only collecting to earn push rights so far :), so going to push for you with the author info taken from there. REPOSITORY R275 KItemModels REVISION DETAIL https://phabricator.kde.org/D29003

D29003: Use Q_EMIT and build with QT_NO_KEYWORDS

kossebau added a comment. @junghans Hi. Do you have push rights, or do you need someone to merge your patch? REPOSITORY R275 KItemModels REVISION DETAIL https://phabricator.kde.org/D29003 To: junghans, kossebau, dfaure, apol Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack,

D29003: Use Q_EMIT and build with QT_NO_KEYWORDS

dfaure accepted this revision. REPOSITORY R275 KItemModels REVISION DETAIL https://phabricator.kde.org/D29003 To: junghans, kossebau, dfaure, apol Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29003: Use Q_EMIT and build with QT_NO_KEYWORDS

junghans updated this revision to Diff 80852. junghans added a comment. The initial diff was incomplete. This one covers all occurrences of Q_EMIT. REPOSITORY R275 KItemModels CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29003?vs=80610=80852 REVISION DETAIL

D29003: Use Q_EMIT and build with QT_NO_KEYWORDS

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R275 KItemModels REVISION DETAIL https://phabricator.kde.org/D29003 To: junghans, kossebau, dfaure, apol Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29003: Use Q_EMIT and build with QT_NO_KEYWORDS

ahmadsamir added a reviewer: dfaure. ahmadsamir added a comment. We should also have a task on the KF6 workboard[1] about this, so that we cull them out of all the current code in KDE. (Or maybe use a perl-script to get them all?) [1] https://phabricator.kde.org/project/board/310/

D29003: Use Q_EMIT and build with QT_NO_KEYWORDS

junghans created this revision. junghans added a reviewer: kossebau. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. junghans requested review of this revision. REVISION SUMMARY QT_NO_KEYWORDS will be default in Qt 6 so all occurrences of `emit` should be