D29358: Implement lock-screen visibility control on Android

2020-05-23 Thread Volker Krause
vkrause closed this revision. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D29358 To: vkrause, nicolasfella Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29358: Implement lock-screen visibility control on Android

2020-05-22 Thread Nicolas Fella
nicolasfella accepted this revision. This revision is now accepted and ready to land. REPOSITORY R289 KNotifications BRANCH pending REVISION DETAIL https://phabricator.kde.org/D29358 To: vkrause, nicolasfella Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29358: Implement lock-screen visibility control on Android

2020-05-22 Thread Volker Krause
vkrause updated this revision to Diff 83104. vkrause added a comment. Rename visibility hint. REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29358?vs=81734=83104 BRANCH pending REVISION DETAIL https://phabricator.kde.org/D29358 AFFECTED FILES

D29358: Implement lock-screen visibility control on Android

2020-05-20 Thread Nicolas Fella
nicolasfella requested changes to this revision. nicolasfella added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > notifybyandroid.cpp:110 > n.setField("urgency", (jint)(notification->urgency() == > KNotification::DefaultUrgency ?

D29358: Implement lock-screen visibility control on Android

2020-05-20 Thread Nicolas Fella
nicolasfella accepted this revision. This revision is now accepted and ready to land. REPOSITORY R289 KNotifications BRANCH pending REVISION DETAIL https://phabricator.kde.org/D29358 To: vkrause, nicolasfella Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29358: Implement lock-screen visibility control on Android

2020-05-19 Thread Volker Krause
vkrause added a comment. ping? REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D29358 To: vkrause Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29358: Implement lock-screen visibility control on Android

2020-05-02 Thread Volker Krause
vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY This is only the backend part, lacking a proper frontend API this is using a custom hint for now. Android knows three