On Aug. 15, 2014, 8:20 a.m., Alex Merry wrote:
modules/ECMGeneratePkgConfigFile.cmake, line 47
https://git.reviewboard.kde.org/r/119798/diff/1/?file=305638#file305638line47
This belongs in KDEInstallDirs.cmake, not here (as
CMAKE_INSTALL_PKGCONFIGDIR, ideally). Projects that
On Aug. 15, 2014, 8:20 a.m., Alex Merry wrote:
modules/ECMGeneratePkgConfigFile.cmake, lines 25-26
https://git.reviewboard.kde.org/r/119798/diff/1/?file=305638#file305638line25
Why not have both be KF5Archive as the standard? And have LIB_NAME
default to BASE_NAME (or vice
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119798/
---
(Updated Aug. 18, 2014, 1:59 p.m.)
Review request for Build System, KDE
On Aug. 15, 2014, 8:20 a.m., Alex Merry wrote:
modules/ECMGeneratePkgConfigFile.cmake, lines 25-26
https://git.reviewboard.kde.org/r/119798/diff/1/?file=305638#file305638line25
Why not have both be KF5Archive as the standard? And have LIB_NAME
default to BASE_NAME (or vice
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119798/#review64807
---
modules/ECMGeneratePkgConfigFile.cmake
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119798/#review64585
---
I'm in favour of this - I was planning to do it myself before
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119798/
---
Review request for Build System, KDE Frameworks and Harald Sitter.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119798/#review64581
---
+1
- Harald Sitter
On Aug. 14, 2014, 11:10 p.m., Aleix Pol
