Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

2013-09-06 Thread Dawit Alemayehu
changes after your port, then feel free to ship this, otherwise would it be possible for you to hold off on this port? For the record I am not the maintainer of this code base. I am just trying to improve as many of these ioslaves as I can when I get the chance. - Dawit Alemayehu On Sept. 2

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

2013-09-09 Thread Dawit Alemayehu
On Sept. 6, 2013, 1:10 p.m., Dawit Alemayehu wrote: I have several changes coming to this ioslave. Mainly I am going to implement the copyFrom and copyTo optimizations like I did for the sftp ioslave and add support for upload/download resumptions. The changes are going to come

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

2013-11-27 Thread Dawit Alemayehu
On Nov. 26, 2013, 5:12 p.m., Kevin Ottens wrote: It's been stalled for almost three months now, any chance to see progress or should it be discarded? Mark Gaiser wrote: No, it should most certainly not be disgarded. It was even working when i posted this post up for review.

Re: Review Request 115613: Drop platform name from default user agent string

2014-02-10 Thread Dawit Alemayehu
the following: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/32.0.1700.107 Safari/537.36 So removing the platform name from the user-agent string might have consequences on sites that rely on it. - Dawit Alemayehu On Feb. 10, 2014, 9:15 a.m., Martin Gräßlin

Re: Review Request 115723: Use Q_OS_UNIX instead of HAVE_X11 to determine the platform we are on

2014-02-13 Thread Dawit Alemayehu
wonder what Mozilla/Chromium send when the windowing system is something other than X11. Probably the same thing. - Dawit Alemayehu On Feb. 13, 2014, 1:03 p.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail

Re: Review Request 122007: Fix KTcpSocket to return correct negotiated protocol

2015-01-15 Thread Dawit Alemayehu
/ktcpsocket.h d59b180 src/core/ktcpsocket.cpp f223986 src/core/tcpslavebase.cpp e62e72a Diff: https://git.reviewboard.kde.org/r/122007/diff/ Testing --- Thanks, Dawit Alemayehu ___ Kde-frameworks-devel mailing list Kde-frameworks-devel

Re: Review Request 122007: Fix KTcpSocket to return correct negotiated protocol

2015-01-18 Thread Dawit Alemayehu
- src/core/ktcpsocket.h d59b180 src/core/ktcpsocket.cpp f223986 src/core/tcpslavebase.cpp e62e72a Diff: https://git.reviewboard.kde.org/r/122007/diff/ Testing --- Thanks, Dawit Alemayehu ___ Kde-frameworks-devel mailing list Kde

Review Request 122007: Fix KTcpSocket to return correct negotiated protocol

2015-01-11 Thread Dawit Alemayehu
/tcpslavebase.cpp e62e72a Diff: https://git.reviewboard.kde.org/r/122007/diff/ Testing --- Thanks, Dawit Alemayehu ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel