D21695: Add FindTaglib.cmake

elvisangelaccio commandeered this revision. elvisangelaccio added a reviewer: heikobecker. elvisangelaccio added a comment. In D21695#675056 , @elvisangelaccio wrote: > New attempt at

D21695: Add FindTaglib.cmake

elvisangelaccio abandoned this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D21695 To: elvisangelaccio, kde-buildsystem, kde-frameworks-devel, dfaure, heikobecker Cc: asturmlechner, ngraham, elvisangelaccio, cgiboudeaux, dfaure, LeGast00n,

D21695: Add FindTaglib.cmake

elvisangelaccio added a comment. New attempt at https://invent.kde.org/frameworks/extra-cmake-modules/-/merge_requests/6 REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D21695 To: heikobecker, kde-buildsystem, kde-frameworks-devel, dfaure Cc:

D21695: Add FindTaglib.cmake

elvisangelaccio added a comment. @heikobecker are you still interested in this patch? I can take over otherwise. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D21695 To: heikobecker, kde-buildsystem, kde-frameworks-devel, dfaure Cc: ngraham,

D21695: Add FindTaglib.cmake

dfaure added inline comments. INLINE COMMENTS > dfaure wrote in FindTaglib.cmake:84 > ( this searches for it both ways, so it's unclear what the include dir > will be --- with or without taglib at the end?) BTW since then it was determined that applications should use , so you should NOT

D21695: Add FindTaglib.cmake

ngraham added a comment. Can we move forward on this? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D21695 To: heikobecker, kde-buildsystem, kde-frameworks-devel, dfaure Cc: ngraham, elvisangelaccio, cgiboudeaux, dfaure, LeGast00n, GB_2, bencreasy,

D21695: Add FindTaglib.cmake

ngraham added a comment. @heikobecker ping! REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D21695 To: heikobecker, kde-buildsystem, kde-frameworks-devel, dfaure Cc: ngraham, elvisangelaccio, cgiboudeaux, dfaure, LeGast00n, GB_2, bencreasy, michaelh,

D21695: Add FindTaglib.cmake

elvisangelaccio added a comment. Where does this FindTaglib.cmake come from? We should probably use the one from kio-extras, which got a bunch of fixes in the last months. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D21695 To: heikobecker,

D21695: Add FindTaglib.cmake

elvisangelaccio added a comment. In D21695#476826 , @heikobecker wrote: > I'm not entirely sure about taglib-config on Windows See

D21695: Add FindTaglib.cmake

cgiboudeaux added a comment. attic/modules/FindTaglib.cmake shall be deleted. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D21695 To: heikobecker, kde-buildsystem, kde-frameworks-devel, dfaure Cc: cgiboudeaux, dfaure, LeGast00n, bencreasy, michaelh,

D21695: Add FindTaglib.cmake

cgiboudeaux added inline comments. INLINE COMMENTS > FindTaglib.cmake:19 > +# > +# If ``Taglib_Found is TRUE, it will also define the following imported > +# target: If ``Taglib_FOUND`` ... > FindTaglib.cmake:22 > +# > +# ``Taglib::Talib`` > +# The Taglib library Typo REPOSITORY R240

D21695: Add FindTaglib.cmake

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Certainly a good idea to have this in ECM, so that this mess can be sorted out once and for all... INLINE COMMENTS > FindTaglib.cmake:56 > +# The minimum version of Taglib we

D21695: Add FindTaglib.cmake

heikobecker added a comment. I'm not entirely sure about taglib-config on Windows and Android (can't test there), but similar to pkg-config I omitted the special casing. Tried to test this by moving taglib-config out of the way on Linux and a taglib install in default locations, which

D21695: Add FindTaglib.cmake

heikobecker created this revision. heikobecker added reviewers: kde-buildsystem, kde-frameworks-devel. Herald added projects: Frameworks, Build System. heikobecker requested review of this revision. REVISION SUMMARY The old one from KDELibs4 times is used by several projects from Frameworks,