[Reminder Daemon] [Bug 452264] Appointment reminder handling reduces usability and functionality between 21.12.3 and 22.03.80

2024-02-16 Thread David Faure
https://bugs.kde.org/show_bug.cgi?id=452264

David Faure  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/pim/ |https://invent.kde.org/pim/
   |akonadi-calendar/-/commit/2 |akonadi-calendar/-/commit/0
   |2fbeb4e48646ab4fa9abce21c4e |dea82b7100a3f79a81bfdc2e627
   |f1eab31475e5|ba8923131abe

--- Comment #29 from David Faure  ---
Git commit 0dea82b7100a3f79a81bfdc2e627ba8923131abe by David Faure.
Committed on 15/02/2024 at 19:40.
Pushed by dfaure into branch 'release/24.02'.

Implement a dialog for the user to choose the suspend duration

The "Remind in 1h" action has been replaced with a "Remind later..."
action which pops up that dialog.

The UI is QWidget-based (reusing some code from korgac).
On mobile we could just not show the "Remind later" action or
implement a similar QML-based UI.
Related: bug 481024, bug 457046, bug 453298, bug 457046

M  +2-0reminder-daemon/CMakeLists.txt
M  +5-4reminder-daemon/alarmnotification.cpp
M  +2-2reminder-daemon/kalendaracmain.cpp
M  +21   -5reminder-daemon/kalendaralarmclient.cpp
M  +4-0reminder-daemon/kalendaralarmclient.h
A  +136  -0reminder-daemon/suspenddialog.cpp  *
A  +33   -0reminder-daemon/suspenddialog.h  *

The files marked with a * at the end have a non valid license. Please read:
https://community.kde.org/Policies/Licensing_Policy and use the headers which
are listed at that page.


https://invent.kde.org/pim/akonadi-calendar/-/commit/0dea82b7100a3f79a81bfdc2e627ba8923131abe

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Reminder Daemon] [Bug 457046] Recent update removes the reminder popup window with a notification, snooze time adjustment is no longer available

2024-02-16 Thread David Faure
https://bugs.kde.org/show_bug.cgi?id=457046

--- Comment #9 from David Faure  ---
Git commit 0dea82b7100a3f79a81bfdc2e627ba8923131abe by David Faure.
Committed on 15/02/2024 at 19:40.
Pushed by dfaure into branch 'release/24.02'.

Implement a dialog for the user to choose the suspend duration

The "Remind in 1h" action has been replaced with a "Remind later..."
action which pops up that dialog.

The UI is QWidget-based (reusing some code from korgac).
On mobile we could just not show the "Remind later" action or
implement a similar QML-based UI.
Related: bug 481024, bug 452264, bug 453298

M  +2-0reminder-daemon/CMakeLists.txt
M  +5-4reminder-daemon/alarmnotification.cpp
M  +2-2reminder-daemon/kalendaracmain.cpp
M  +21   -5reminder-daemon/kalendaralarmclient.cpp
M  +4-0reminder-daemon/kalendaralarmclient.h
A  +136  -0reminder-daemon/suspenddialog.cpp  *
A  +33   -0reminder-daemon/suspenddialog.h  *

The files marked with a * at the end have a non valid license. Please read:
https://community.kde.org/Policies/Licensing_Policy and use the headers which
are listed at that page.


https://invent.kde.org/pim/akonadi-calendar/-/commit/0dea82b7100a3f79a81bfdc2e627ba8923131abe

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Reminder Daemon] [Bug 481024] The loss of user-defined snoozing for calendar and todo reminders is a massive functional regression and actually a hard show-stopper for my kontact usage

2024-02-16 Thread David Faure
https://bugs.kde.org/show_bug.cgi?id=481024

David Faure  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/pim/ |https://invent.kde.org/pim/
   |akonadi-calendar/-/commit/2 |akonadi-calendar/-/commit/0
   |2fbeb4e48646ab4fa9abce21c4e |dea82b7100a3f79a81bfdc2e627
   |f1eab31475e5|ba8923131abe

--- Comment #28 from David Faure  ---
Git commit 0dea82b7100a3f79a81bfdc2e627ba8923131abe by David Faure.
Committed on 15/02/2024 at 19:40.
Pushed by dfaure into branch 'release/24.02'.

Implement a dialog for the user to choose the suspend duration

The "Remind in 1h" action has been replaced with a "Remind later..."
action which pops up that dialog.

The UI is QWidget-based (reusing some code from korgac).
On mobile we could just not show the "Remind later" action or
implement a similar QML-based UI.
Related: bug 457046, bug 452264, bug 453298, bug 457046

M  +2-0reminder-daemon/CMakeLists.txt
M  +5-4reminder-daemon/alarmnotification.cpp
M  +2-2reminder-daemon/kalendaracmain.cpp
M  +21   -5reminder-daemon/kalendaralarmclient.cpp
M  +4-0reminder-daemon/kalendaralarmclient.h
A  +136  -0reminder-daemon/suspenddialog.cpp  *
A  +33   -0reminder-daemon/suspenddialog.h  *

The files marked with a * at the end have a non valid license. Please read:
https://community.kde.org/Policies/Licensing_Policy and use the headers which
are listed at that page.


https://invent.kde.org/pim/akonadi-calendar/-/commit/0dea82b7100a3f79a81bfdc2e627ba8923131abe

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Reminder Daemon] [Bug 457046] Recent update removes the reminder popup window with a notification, snooze time adjustment is no longer available

2024-02-16 Thread David Faure
https://bugs.kde.org/show_bug.cgi?id=457046

David Faure  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/pim/ |https://invent.kde.org/pim/
   |akonadi-calendar/-/commit/2 |akonadi-calendar/-/commit/0
   |2fbeb4e48646ab4fa9abce21c4e |dea82b7100a3f79a81bfdc2e627
   |f1eab31475e5|ba8923131abe

--- Comment #8 from David Faure  ---
Git commit 0dea82b7100a3f79a81bfdc2e627ba8923131abe by David Faure.
Committed on 15/02/2024 at 19:40.
Pushed by dfaure into branch 'release/24.02'.

Implement a dialog for the user to choose the suspend duration

The "Remind in 1h" action has been replaced with a "Remind later..."
action which pops up that dialog.

The UI is QWidget-based (reusing some code from korgac).
On mobile we could just not show the "Remind later" action or
implement a similar QML-based UI.
Related: bug 481024, bug 452264, bug 453298

M  +2-0reminder-daemon/CMakeLists.txt
M  +5-4reminder-daemon/alarmnotification.cpp
M  +2-2reminder-daemon/kalendaracmain.cpp
M  +21   -5reminder-daemon/kalendaralarmclient.cpp
M  +4-0reminder-daemon/kalendaralarmclient.h
A  +136  -0reminder-daemon/suspenddialog.cpp  *
A  +33   -0reminder-daemon/suspenddialog.h  *

The files marked with a * at the end have a non valid license. Please read:
https://community.kde.org/Policies/Licensing_Policy and use the headers which
are listed at that page.


https://invent.kde.org/pim/akonadi-calendar/-/commit/0dea82b7100a3f79a81bfdc2e627ba8923131abe

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Reminder Daemon] [Bug 453298] kalendarac: Notifications miss option to remind later with other time duration than 5 minutes

2024-02-16 Thread David Faure
https://bugs.kde.org/show_bug.cgi?id=453298

David Faure  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/pim/ |https://invent.kde.org/pim/
   |akonadi-calendar/-/commit/2 |akonadi-calendar/-/commit/0
   |2fbeb4e48646ab4fa9abce21c4e |dea82b7100a3f79a81bfdc2e627
   |f1eab31475e5|ba8923131abe

--- Comment #11 from David Faure  ---
Git commit 0dea82b7100a3f79a81bfdc2e627ba8923131abe by David Faure.
Committed on 15/02/2024 at 19:40.
Pushed by dfaure into branch 'release/24.02'.

Implement a dialog for the user to choose the suspend duration

The "Remind in 1h" action has been replaced with a "Remind later..."
action which pops up that dialog.

The UI is QWidget-based (reusing some code from korgac).
On mobile we could just not show the "Remind later" action or
implement a similar QML-based UI.
Related: bug 481024, bug 457046, bug 452264, bug 457046

M  +2-0reminder-daemon/CMakeLists.txt
M  +5-4reminder-daemon/alarmnotification.cpp
M  +2-2reminder-daemon/kalendaracmain.cpp
M  +21   -5reminder-daemon/kalendaralarmclient.cpp
M  +4-0reminder-daemon/kalendaralarmclient.h
A  +136  -0reminder-daemon/suspenddialog.cpp  *
A  +33   -0reminder-daemon/suspenddialog.h  *

The files marked with a * at the end have a non valid license. Please read:
https://community.kde.org/Policies/Licensing_Policy and use the headers which
are listed at that page.


https://invent.kde.org/pim/akonadi-calendar/-/commit/0dea82b7100a3f79a81bfdc2e627ba8923131abe

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Reminder Daemon] [Bug 453298] kalendarac: Notifications miss option to remind later with other time duration than 5 minutes

2024-02-13 Thread David Faure
https://bugs.kde.org/show_bug.cgi?id=453298

David Faure  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/pim/
   ||akonadi-calendar/-/commit/2
   ||2fbeb4e48646ab4fa9abce21c4e
   ||f1eab31475e5
 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

--- Comment #9 from David Faure  ---
Git commit 22fbeb4e48646ab4fa9abce21c4ef1eab31475e5 by David Faure.
Committed on 13/02/2024 at 15:57.
Pushed by dfaure into branch 'master'.

Implement a dialog for the user to choose the suspend duration

The "Remind in 1h" action has been replaced with a "Remind later..."
action which pops up that dialog.

The UI is QWidget-based (reusing some code from korgac).
On mobile we could just not show the "Remind later" action or
implement a similar QML-based UI.
Related: bug 481024, bug 457046, bug 452264, bug 457046

M  +2-0reminder-daemon/CMakeLists.txt
M  +5-4reminder-daemon/alarmnotification.cpp
M  +2-2reminder-daemon/kalendaracmain.cpp
M  +21   -5reminder-daemon/kalendaralarmclient.cpp
M  +4-0reminder-daemon/kalendaralarmclient.h
A  +136  -0reminder-daemon/suspenddialog.cpp  *
A  +33   -0reminder-daemon/suspenddialog.h  *

The files marked with a * at the end have a non valid license. Please read:
https://community.kde.org/Policies/Licensing_Policy and use the headers which
are listed at that page.


https://invent.kde.org/pim/akonadi-calendar/-/commit/22fbeb4e48646ab4fa9abce21c4ef1eab31475e5

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Reminder Daemon] [Bug 452264] Appointment reminder handling reduces usability and functionality between 21.12.3 and 22.03.80

2024-02-13 Thread David Faure
https://bugs.kde.org/show_bug.cgi?id=452264

David Faure  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/pim/
   ||akonadi-calendar/-/commit/2
   ||2fbeb4e48646ab4fa9abce21c4e
   ||f1eab31475e5
 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

--- Comment #28 from David Faure  ---
Git commit 22fbeb4e48646ab4fa9abce21c4ef1eab31475e5 by David Faure.
Committed on 13/02/2024 at 15:57.
Pushed by dfaure into branch 'master'.

Implement a dialog for the user to choose the suspend duration

The "Remind in 1h" action has been replaced with a "Remind later..."
action which pops up that dialog.

The UI is QWidget-based (reusing some code from korgac).
On mobile we could just not show the "Remind later" action or
implement a similar QML-based UI.
Related: bug 481024, bug 457046, bug 453298, bug 457046

M  +2-0reminder-daemon/CMakeLists.txt
M  +5-4reminder-daemon/alarmnotification.cpp
M  +2-2reminder-daemon/kalendaracmain.cpp
M  +21   -5reminder-daemon/kalendaralarmclient.cpp
M  +4-0reminder-daemon/kalendaralarmclient.h
A  +136  -0reminder-daemon/suspenddialog.cpp  *
A  +33   -0reminder-daemon/suspenddialog.h  *

The files marked with a * at the end have a non valid license. Please read:
https://community.kde.org/Policies/Licensing_Policy and use the headers which
are listed at that page.


https://invent.kde.org/pim/akonadi-calendar/-/commit/22fbeb4e48646ab4fa9abce21c4ef1eab31475e5

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Reminder Daemon] [Bug 457046] Recent update removes the reminder popup window with a notification, snooze time adjustment is no longer available

2024-02-13 Thread David Faure
https://bugs.kde.org/show_bug.cgi?id=457046

--- Comment #7 from David Faure  ---
Git commit 22fbeb4e48646ab4fa9abce21c4ef1eab31475e5 by David Faure.
Committed on 13/02/2024 at 15:57.
Pushed by dfaure into branch 'master'.

Implement a dialog for the user to choose the suspend duration

The "Remind in 1h" action has been replaced with a "Remind later..."
action which pops up that dialog.

The UI is QWidget-based (reusing some code from korgac).
On mobile we could just not show the "Remind later" action or
implement a similar QML-based UI.
Related: bug 481024, bug 452264, bug 453298

M  +2-0reminder-daemon/CMakeLists.txt
M  +5-4reminder-daemon/alarmnotification.cpp
M  +2-2reminder-daemon/kalendaracmain.cpp
M  +21   -5reminder-daemon/kalendaralarmclient.cpp
M  +4-0reminder-daemon/kalendaralarmclient.h
A  +136  -0reminder-daemon/suspenddialog.cpp  *
A  +33   -0reminder-daemon/suspenddialog.h  *

The files marked with a * at the end have a non valid license. Please read:
https://community.kde.org/Policies/Licensing_Policy and use the headers which
are listed at that page.


https://invent.kde.org/pim/akonadi-calendar/-/commit/22fbeb4e48646ab4fa9abce21c4ef1eab31475e5

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Reminder Daemon] [Bug 457046] Recent update removes the reminder popup window with a notification, snooze time adjustment is no longer available

2024-02-13 Thread David Faure
https://bugs.kde.org/show_bug.cgi?id=457046

David Faure  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED
  Latest Commit||https://invent.kde.org/pim/
   ||akonadi-calendar/-/commit/2
   ||2fbeb4e48646ab4fa9abce21c4e
   ||f1eab31475e5

--- Comment #6 from David Faure  ---
Git commit 22fbeb4e48646ab4fa9abce21c4ef1eab31475e5 by David Faure.
Committed on 13/02/2024 at 15:57.
Pushed by dfaure into branch 'master'.

Implement a dialog for the user to choose the suspend duration

The "Remind in 1h" action has been replaced with a "Remind later..."
action which pops up that dialog.

The UI is QWidget-based (reusing some code from korgac).
On mobile we could just not show the "Remind later" action or
implement a similar QML-based UI.
Related: bug 481024, bug 452264, bug 453298

M  +2-0reminder-daemon/CMakeLists.txt
M  +5-4reminder-daemon/alarmnotification.cpp
M  +2-2reminder-daemon/kalendaracmain.cpp
M  +21   -5reminder-daemon/kalendaralarmclient.cpp
M  +4-0reminder-daemon/kalendaralarmclient.h
A  +136  -0reminder-daemon/suspenddialog.cpp  *
A  +33   -0reminder-daemon/suspenddialog.h  *

The files marked with a * at the end have a non valid license. Please read:
https://community.kde.org/Policies/Licensing_Policy and use the headers which
are listed at that page.


https://invent.kde.org/pim/akonadi-calendar/-/commit/22fbeb4e48646ab4fa9abce21c4ef1eab31475e5

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Reminder Daemon] [Bug 481024] The loss of user-defined snoozing for calendar and todo reminders is a massive functional regression and actually a hard show-stopper for my kontact usage

2024-02-13 Thread David Faure
https://bugs.kde.org/show_bug.cgi?id=481024

David Faure  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
  Latest Commit||https://invent.kde.org/pim/
   ||akonadi-calendar/-/commit/2
   ||2fbeb4e48646ab4fa9abce21c4e
   ||f1eab31475e5
 Resolution|--- |FIXED

--- Comment #27 from David Faure  ---
Git commit 22fbeb4e48646ab4fa9abce21c4ef1eab31475e5 by David Faure.
Committed on 13/02/2024 at 15:57.
Pushed by dfaure into branch 'master'.

Implement a dialog for the user to choose the suspend duration

The "Remind in 1h" action has been replaced with a "Remind later..."
action which pops up that dialog.

The UI is QWidget-based (reusing some code from korgac).
On mobile we could just not show the "Remind later" action or
implement a similar QML-based UI.
Related: bug 457046, bug 452264, bug 453298, bug 457046

M  +2-0reminder-daemon/CMakeLists.txt
M  +5-4reminder-daemon/alarmnotification.cpp
M  +2-2reminder-daemon/kalendaracmain.cpp
M  +21   -5reminder-daemon/kalendaralarmclient.cpp
M  +4-0reminder-daemon/kalendaralarmclient.h
A  +136  -0reminder-daemon/suspenddialog.cpp  *
A  +33   -0reminder-daemon/suspenddialog.h  *

The files marked with a * at the end have a non valid license. Please read:
https://community.kde.org/Policies/Licensing_Policy and use the headers which
are listed at that page.


https://invent.kde.org/pim/akonadi-calendar/-/commit/22fbeb4e48646ab4fa9abce21c4ef1eab31475e5

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Reminder Daemon] [Bug 481024] The loss of user-defined snoozing for calendar and todo reminders is a massive functional regression and actually a hard show-stopper for my kontact usage

2024-02-10 Thread David Faure
https://bugs.kde.org/show_bug.cgi?id=481024

--- Comment #22 from David Faure  ---
The change contains a new feature and lots of new texts to be translated, I
have no idea if it can be accepted into 22.12.3. Let's see if it's approved
before discussing backports, in any case.

But you don't actually need it to be released in order to use it. You can
easily rebuild a patch akonadi-calendar package even right now.
You're on OpenSUSE so in your case it means downloading the src rpm (1), adding
my change as a patch in the spec file (2), rebuilding the RPM (3), installing
(4), done. Or doing that on the opensuse build service to install less
development packages locally (but step 2 is the same).

(1) sudo zypper source-install akonadi-calendar
(2) adding the patch in /usr/src/packages/SOURCES, editing
/usr/src/packages/SPECS/akonadi-calendar.spec to add it
(3) rpmbuild -bb akonadi-calendar.spec
(4) rpm -Uvh *.rpm

Please don't ask me to guide you step by step, there are online resources for
all this.
Debian/ubuntu users can do something similar with apt-get source and debuild.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Reminder Daemon] [Bug 481024] The loss of user-defined snoozing for calendar and todo reminders is a massive functional regression and actually a hard show-stopper for my kontact usage

2024-02-10 Thread David Faure
https://bugs.kde.org/show_bug.cgi?id=481024

--- Comment #20 from David Faure  ---
Sorry for derailing the discussions about workarounds with a proper fix ;-)
(see description in merge request)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Reminder Daemon] [Bug 461233] Default time unit for suspending

2024-02-10 Thread David Faure
https://bugs.kde.org/show_bug.cgi?id=461233

--- Comment #5 from David Faure  ---
I'm referring to
https://invent.kde.org/pim/akonadi-calendar/-/merge_requests/82

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Reminder Daemon] [Bug 461233] Default time unit for suspending

2024-02-10 Thread David Faure
https://bugs.kde.org/show_bug.cgi?id=461233

David Faure  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|REPORTED|RESOLVED
 CC||fa...@kde.org

--- Comment #4 from David Faure  ---
It should remember from one time to the next: if you select days and confirm
"suspend", the next time it should offer days.

The code for this was a bit convoluted in korgac (so it might have been buggy)
but I re-worked that code in kalendarac and I can confirm, it will remember
from one time to the next (even across process restarts).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Reminder Daemon] [Bug 481024] The loss of user-defined snoozing for calendar and todo reminders is a massive functional regression and actually a hard show-stopper for my kontact usage

2024-02-10 Thread David Faure
https://bugs.kde.org/show_bug.cgi?id=481024

David Faure  changed:

   What|Removed |Added

  Component|calendar|general
Product|kontact |Reminder Daemon

--- Comment #16 from David Faure  ---
I'm working on a patch.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kontact] [Bug 481024] The loss of user-defined snoozing for calendar and todo reminders is a massive functional regression and actually a hard show-stopper for my kontact usage

2024-02-09 Thread David Faure
https://bugs.kde.org/show_bug.cgi?id=481024

--- Comment #11 from David Faure  ---
Hi Bernhard! Long time no "see" ;-)

Yeah after my last comment I had a similar idea, one of the buttons in the
notification could trigger a dialog box like the old korgac one, where we can
have widgets to define a delay etc. KOrganizer might not be running, so it
wouldn't be the right process for popping up that dialog. But kalendarac (the
new daemon) could pop up the dialog like korgac did.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kontact] [Bug 481024] The loss of user-defined snoozing for calendar and todo reminders is a massive functional regression and actually a hard show-stopper for my kontact usage

2024-02-08 Thread David Faure
https://bugs.kde.org/show_bug.cgi?id=481024

--- Comment #9 from David Faure  ---
> Actually you should never have removed the original functionality 

"You"? Just because I have a @kde.org address does not mean I was part of that
decision in any shape of form. On the contrary I was among the first ones to
complain about it when I found out, as a user. And I'm writing here because I'm
on the same side as you, trying to find possible solutions. I know you're
frustrated but please refrain from attacking the first person you talk to.

As for DBus, I'm sure the notification library sends a DBus signal that plasma
reacts to, but I'm not sure how that would help as long as kalendarac only has
code to postpone by 5 minutes and 1 hour.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kontact] [Bug 481024] The loss of user-defined snoozing for calendar and todo reminders is a massive functional regression and actually a hard show-stopper for my kontact usage

2024-02-08 Thread David Faure
https://bugs.kde.org/show_bug.cgi?id=481024

David Faure  changed:

   What|Removed |Added

 CC||fa...@kde.org

--- Comment #4 from David Faure  ---
I was told this was because freedesktop.org notifications don't support custom
widgets, only a few action buttons, for interoperability with other desktop
environments. I agree however this is really suboptimal, especially when not
caring for other desktop environments.

As for "workarounds", you can find the code in
akonadi-calendar/reminder-daemon/alarmnotification.cpp line 135 and add more
buttons like "remind tomorrow".

Maybe we should implement an alternative notification solution in kalendarac
that looks more like the old korgac dialog (minus its bugs...).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmail2] [Bug 478416] Crash on eMail sending since yesterdays git master snapshot built

2023-12-27 Thread David Faure
https://bugs.kde.org/show_bug.cgi?id=478416

David Faure  changed:

   What|Removed |Added

 CC||fa...@kde.org

--- Comment #11 from David Faure  ---
(In reply to Robby Engelmann from comment #5)
> does this:
> >qt.dbus.integration: Could not connect "org.freedesktop.NetworkManager" to 
> >"stateChanged" : Type not registered with QtDBus in parameter list: 
> >QNetworkManagerInterface::NMState
> >qt.dbus.integration: Could not connect "org.freedesktop.NetworkManager" to 
> >"connectivityChanged" : Type not registered with QtDBus in parameter list: 
> >QNetworkManagerInterface::NMConnectivityState
> >qt.dbus.integration: Could not connect "org.freedesktop.NetworkManager" to 
> >"deviceTypeChanged" : Type not registered with QtDBus in parameter list: 
> >QNetworkManagerInterface::NMDeviceType
> >qt.dbus.integration: Could not connect "org.freedesktop.NetworkManager" to 
> >"meteredChanged" : Type not registered with QtDBus in parameter list: 
> >QNetworkManagerInterface::NMMetered
> 
> hint, that kmail is not able to establish a network connection and this is
> why no mails can be pop'ed and the sending fails.
> And the failed sending triggers a crash?
> And the ews ressource works because making use of another connection
> protocol?
> ...I am only wildly guessing...

No these warnings were harmless and are now fixed in
https://codereview.qt-project.org/c/qt/qtbase/+/527739.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Akonadi] [Bug 477214] Application: Google Mail (akonadi_imap_resource) crash in Akonadi::Collection::hasAttribute

2023-12-02 Thread David Faure
https://bugs.kde.org/show_bug.cgi?id=477214

David Faure  changed:

   What|Removed |Added

Summary|Application: Google Mail|Application: Google Mail
   |(jshand2013)|(akonadi_imap_resource)
   |(akonadi_imap_resource) |crash in
   |crash in|Akonadi::Collection::hasAtt
   |Akonadi::Collection::hasAtt |ribute
   |ribute  |

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Akonadi] [Bug 477214] Application: Google Mail (jshand2013) (akonadi_imap_resource) crash in Akonadi::Collection::hasAttribute

2023-12-02 Thread David Faure
https://bugs.kde.org/show_bug.cgi?id=477214

--- Comment #3 from David Faure  ---
  [KCrash Handler]
  #4  QHash::findNode(QByteArray const&,
unsigned int*) const (ahp=, akey=,
this=) at /usr/
  src/debug/akonadi-23.08.3/src/core/attributestorage.cpp:69
  #5  QHash::contains(QByteArray const&) const
(akey=, this=) at
/usr/include/qt5/QtCore/qhash.h:920
  #6  Akonadi::AttributeStorage::hasAttribute(QByteArray const&) const
(type=..., this=0x40) at
/usr/src/debug/akonadi-23.08.3/src/core/attributestorage.cpp:69
  #7  Akonadi::Collection::hasAttribute(QByteArray const&) const
(this=this@entry=0x55e8e3c046e0, type=...) at
/usr/src/debug/akonadi-23.08.3/src/core/collection.cpp:163
  #8  0x7f90a30bd909 in
Akonadi::Collection::hasAttribute() const
(this=0x55e8e3c046e0) at /usr/src/debug/akonadi-23.08.3/src/co
  re/collection.h:595
  #9  (anonymous namespace)::sortCollectionsForSync(Akonadi::Collection const&,
Akonadi::Collection const&) (l=..., r=...) at
/usr/src/debug/akonadi-23.08.3/src/agentbas
  e/resourcebase.cpp:855

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Akonadi] [Bug 477214] Application: Google Mail (jshand2013) (akonadi_imap_resource) crash in Akonadi::Collection::hasAttribute

2023-12-02 Thread David Faure
https://bugs.kde.org/show_bug.cgi?id=477214

David Faure  changed:

   What|Removed |Added

Summary|Application: Google Mail|Application: Google Mail
   |(jshand2013)|(jshand2013)
   |(akonadi_imap_resource),|(akonadi_imap_resource)
   |signal: Segmentation fault  |crash in
   ||Akonadi::Collection::hasAtt
   ||ribute
 CC||fa...@kde.org

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Reminder Daemon] [Bug 455369] Calendar event notifications lead to segfault if closed by notification button

2022-06-30 Thread David Faure
https://bugs.kde.org/show_bug.cgi?id=455369

David Faure  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/pim/
   ||akonadi-calendar/commit/266
   ||94e8c82562eac2fdbdb6fa85f56
   ||b27fca82a0
 Status|ASSIGNED|RESOLVED

--- Comment #4 from David Faure  ---
Git commit 26694e8c82562eac2fdbdb6fa85f56b27fca82a0 by David Faure.
Committed on 30/06/2022 at 14:32.
Pushed by dfaure into branch 'release/22.04'.

Fix crash when clicking on dismiss, sometimes.

client->dismiss(this) ends up setting client to nullptr, so
the disconnect() warns about null receiver and doesn't actually
disconnect.

(This is similar to 24f3853f14ec in master)
Related: bug 455472, bug 455886, bug 455258, bug 455583

M  +1-1reminder-daemon/alarmnotification.cpp

https://invent.kde.org/pim/akonadi-calendar/commit/26694e8c82562eac2fdbdb6fa85f56b27fca82a0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Reminder Daemon] [Bug 455583] kalendarc crashes when dismissing reminder notification

2022-06-30 Thread David Faure
https://bugs.kde.org/show_bug.cgi?id=455583

David Faure  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/pim/
   ||akonadi-calendar/commit/266
   ||94e8c82562eac2fdbdb6fa85f56
   ||b27fca82a0
 Status|ASSIGNED|RESOLVED

--- Comment #2 from David Faure  ---
Git commit 26694e8c82562eac2fdbdb6fa85f56b27fca82a0 by David Faure.
Committed on 30/06/2022 at 14:32.
Pushed by dfaure into branch 'release/22.04'.

Fix crash when clicking on dismiss, sometimes.

client->dismiss(this) ends up setting client to nullptr, so
the disconnect() warns about null receiver and doesn't actually
disconnect.

(This is similar to 24f3853f14ec in master)
Related: bug 455472, bug 455369, bug 455886, bug 455258

M  +1-1reminder-daemon/alarmnotification.cpp

https://invent.kde.org/pim/akonadi-calendar/commit/26694e8c82562eac2fdbdb6fa85f56b27fca82a0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Reminder Daemon] [Bug 455472] Reminders crashes on login

2022-06-30 Thread David Faure
https://bugs.kde.org/show_bug.cgi?id=455472

David Faure  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/pim/
   ||akonadi-calendar/commit/266
   ||94e8c82562eac2fdbdb6fa85f56
   ||b27fca82a0
 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

--- Comment #4 from David Faure  ---
Git commit 26694e8c82562eac2fdbdb6fa85f56b27fca82a0 by David Faure.
Committed on 30/06/2022 at 14:32.
Pushed by dfaure into branch 'release/22.04'.

Fix crash when clicking on dismiss, sometimes.

client->dismiss(this) ends up setting client to nullptr, so
the disconnect() warns about null receiver and doesn't actually
disconnect.

(This is similar to 24f3853f14ec in master)
Related: bug 455369, bug 455886, bug 455258, bug 455583

M  +1-1reminder-daemon/alarmnotification.cpp

https://invent.kde.org/pim/akonadi-calendar/commit/26694e8c82562eac2fdbdb6fa85f56b27fca82a0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Reminder Daemon] [Bug 455258] Reminders crashed while suspended

2022-06-30 Thread David Faure
https://bugs.kde.org/show_bug.cgi?id=455258

David Faure  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED
  Latest Commit||https://invent.kde.org/pim/
   ||akonadi-calendar/commit/266
   ||94e8c82562eac2fdbdb6fa85f56
   ||b27fca82a0

--- Comment #2 from David Faure  ---
Git commit 26694e8c82562eac2fdbdb6fa85f56b27fca82a0 by David Faure.
Committed on 30/06/2022 at 14:32.
Pushed by dfaure into branch 'release/22.04'.

Fix crash when clicking on dismiss, sometimes.

client->dismiss(this) ends up setting client to nullptr, so
the disconnect() warns about null receiver and doesn't actually
disconnect.

(This is similar to 24f3853f14ec in master)
Related: bug 455472, bug 455369, bug 455886, bug 455583

M  +1-1reminder-daemon/alarmnotification.cpp

https://invent.kde.org/pim/akonadi-calendar/commit/26694e8c82562eac2fdbdb6fa85f56b27fca82a0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Reminder Daemon] [Bug 453298] kalendarac: Notifications miss option to remind later with other time duration than 5 minutes

2022-06-30 Thread David Faure
https://bugs.kde.org/show_bug.cgi?id=453298

David Faure  changed:

   What|Removed |Added

 CC||fa...@kde.org

--- Comment #2 from David Faure  ---
I added a "1 hour" option in master, but I agree that this is not yet optimal
overall.
https://invent.kde.org/pim/akonadi-calendar/-/merge_requests/26

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Reminder Daemon] [Bug 455472] Reminders crashes on login

2022-06-29 Thread David Faure
https://bugs.kde.org/show_bug.cgi?id=455472

David Faure  changed:

   What|Removed |Added

 CC||fa...@kde.org

--- Comment #2 from David Faure  ---
Should be fixed by
https://invent.kde.org/pim/akonadi-calendar/-/merge_requests/28

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Akonadi] [Bug 401054] Stream parser exceptions

2021-08-23 Thread David Faure
https://bugs.kde.org/show_bug.cgi?id=401054

--- Comment #9 from David Faure  ---
You could try increasing the 3 in 
bool ImapStreamParser::waitForMoreData (akonadi git repository), just to see if
this 30s timeout is the reason for the problem? Maybe the server takes a long
time to prepare sending this line...

-- 
You are receiving this mail because:
You are the assignee for the bug.

[akregator] [Bug 391865] Akregator allows feeds to gather data on article reading habits

2021-04-09 Thread David Faure
https://bugs.kde.org/show_bug.cgi?id=391865

--- Comment #2 from David Faure  ---
Thanks for the report. I talked to Laurent and he said he's now working on
this. Not a trivial fix, refactorings needed to share code with KMail, this
will take some time.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[korganizer] [Bug 435352] Crash in EventViews::AgendaItem::firstMultiItem (null agenda item)

2021-04-08 Thread David Faure
https://bugs.kde.org/show_bug.cgi?id=435352

--- Comment #3 from David Faure  ---
Hmm, many things can happen while a modal dialog is up (the question in
showMoveRecurDialog). Like the disappearing+reappearing of events that happens
often after I just created them (with the DAV resource at least).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[korganizer] [Bug 435352] Crash in EventViews::AgendaItem::firstMultiItem (null agenda item)

2021-04-04 Thread David Faure
https://bugs.kde.org/show_bug.cgi?id=435352

--- Comment #1 from David Faure  ---
The line of code is

1217AgendaItem::QPtr placeItem = d->mActionItem->firstMultiItem();

and clearly d->mActionItem is null.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[korganizer] [Bug 435352] Crash in EventViews::AgendaItem::firstMultiItem (null agenda item)

2021-04-04 Thread David Faure
https://bugs.kde.org/show_bug.cgi?id=435352

David Faure  changed:

   What|Removed |Added

 CC||gjditchfi...@acm.org

-- 
You are receiving this mail because:
You are the assignee for the bug.

[korganizer] [Bug 435352] New: Crash in EventViews::AgendaItem::firstMultiItem (null agenda item)

2021-04-04 Thread David Faure
https://bugs.kde.org/show_bug.cgi?id=435352

Bug ID: 435352
   Summary: Crash in EventViews::AgendaItem::firstMultiItem (null
agenda item)
   Product: korganizer
   Version: unspecified
  Platform: Other
OS: Linux
Status: REPORTED
  Severity: normal
  Priority: NOR
 Component: agendaview (weekview)
  Assignee: kdepim-bugs@kde.org
  Reporter: fa...@kde.org
  Target Milestone: ---

SUMMARY

I moved a weekly-recurring event to half an hour later, korganizer asked if
that was for this instance or for all, I clicked on All, and korganizer
crashed.

If it matters, I had previously duplicated an event recurring on thursdays (by
copy/pasting it), then modified that event to be on mondays rather than
thursdays.
And then I moved its start time as described anove.

OBSERVED RESULT

#0  EventViews::AgendaItem::firstMultiItem() const (this=0x0) at
/d/kde/src/5/kde/pim/eventviews/src/agenda/agendaitem.h:171
#1  EventViews::Agenda::endItemAction() (this=0xa40) at
/d/kde/src/5/kde/pim/eventviews/src/agenda/agenda.cpp:1217
#2  0x7fd9580c4804 in EventViews::Agenda::eventFilter_mouse(QObject*,
QMouseEvent*) (this=0xa40, object=, me=0x7ffe802f14d0) at
/d/kde/src/5/kde/pim/eventviews/src/agenda/agenda.cpp:703
#3  0x7fd9552ccda9 in
QCoreApplicationPrivate::sendThroughObjectEventFilters(QObject*, QEvent*)
(receiver=0x7fd948019120, event=0x7ffe802f14d0) at
/d/qt/5/kde/qtbase/src/corelib/kernel/qcoreapplication.cpp:1190
#4  0x7fd9560a981d in QApplicationPrivate::notify_helper(QObject*, QEvent*)
(this=0xcb42d0, receiver=0x7fd948019120, e=0x7ffe802f14d0) at
/d/qt/5/kde/qtbase/src/widgets/kernel/qapplication.cpp:3626
#5  0x7fd9560a73d2 in QApplication::notify(QObject*, QEvent*)
(this=0x7ffe802f2610, receiver=0x7fd948019120, e=0x7ffe802f14d0) at
/d/qt/5/kde/qtbase/src/widgets/kernel/qapplication.cpp:3076
#6  0x7fd9552cc984 in QCoreApplication::notifyInternal2(QObject*, QEvent*)
(receiver=0x7fd948019120, event=0x7ffe802f14d0) at
/d/qt/5/kde/qtbase/src/corelib/kernel/qcoreapplication.cpp:1064
#7  0x7fd9552cd356 in QCoreApplication::sendSpontaneousEvent(QObject*,
QEvent*) (receiver=0x7fd948019120, event=0x7ffe802f14d0) at
/d/qt/5/kde/qtbase/src/corelib/kernel/qcoreapplication.cpp:1474
#8  0x7fd9560a5fa3 in QApplicationPrivate::sendMouseEvent(QWidget*,
QMouseEvent*, QWidget*, QWidget*, QWidget**, QPointer&, bool, bool)
(receiver=0x7fd948019120, event=0x7ffe802f14d0, alienWidget=0x7fd948019120,
nativeWidget=0xe3e7a0, buttonDown=0x7fd956810a10 ,
lastMouseReceiver=..., spontaneous=true, onlyDispatchEnterLeave=false) at
/d/qt/5/kde/qtbase/src/widgets/kernel/qapplication.cpp:2614

EXPECTED RESULT

No crash :)

SOFTWARE/OS VERSIONS
KDEPIM Version: git release/21.04 branch (eventviews commit 04450a2)
KDE Frameworks Version: 5.81.0
Qt Version: 5.15.2

ADDITIONAL INFORMATION

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Akonadi] [Bug 418910] When Event Not found it stop fetching

2021-04-03 Thread David Faure
https://bugs.kde.org/show_bug.cgi?id=418910

--- Comment #5 from David Faure  ---
Ouch. Sorry about the data loss! I understand that's extremely frustrating.

It's however unfair and incorrect to say that the devs have abandoned kdepim.
We're still trying, as hard as it is...

-- 
You are receiving this mail because:
You are the assignee for the bug.

[akregator] [Bug 391865] Akregator allows feeds to gather data on article reading habits

2021-03-30 Thread David Faure
https://bugs.kde.org/show_bug.cgi?id=391865

David Faure  changed:

   What|Removed |Added

 CC||fa...@kde.org
   Assignee|kdepim-bugs@kde.org |mon...@kde.org

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmail2] [Bug 378944] crash when typing a "C" in the folder quick-filter line edit

2020-11-24 Thread David Faure
https://bugs.kde.org/show_bug.cgi?id=378944

David Faure  changed:

   What|Removed |Added

 Status|REPORTED|RESOLVED
 CC||fa...@kde.org
 Resolution|--- |FIXED

--- Comment #3 from David Faure  ---
I'm pretty sure I know how this happened.

The order of the proxy was wrong, so the filter really removed the folders for
a lot of code on top, including the code that wanted to save the
previously-current message.

I changed all that long ago -- and I just removed the assert anyway for another
reason, the case of actually deleting a folder.
https://invent.kde.org/pim/messagelib/commit/53ed9a5675a5516da6d599bf5868e0a0e73ea15e

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kontact] [Bug 408675] KMail crashes sometimes when clicking on toolbar button "Reply"

2020-10-11 Thread David Faure
https://bugs.kde.org/show_bug.cgi?id=408675

David Faure  changed:

   What|Removed |Added

 Resolution|--- |UPSTREAM
 Status|REPORTED|RESOLVED

--- Comment #5 from David Faure  ---
This is excellent news, thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Akonadi] [Bug 405922] Very frequent akonadi crash in QLocale::dayName

2020-09-10 Thread David Faure
https://bugs.kde.org/show_bug.cgi?id=405922

David Faure  changed:

   What|Removed |Added

 CC||fa...@kde.org
Summary|Very frequent akonadi crash |Very frequent akonadi crash
   ||in QLocale::dayName

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kontact] [Bug 420364] Kontact window has wrong title

2020-04-23 Thread David Faure
https://bugs.kde.org/show_bug.cgi?id=420364

David Faure  changed:

   What|Removed |Added

   Assignee|kdepim-bugs@kde.org |fa...@kde.org

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kontact] [Bug 420364] Kontact window has wrong title

2020-04-23 Thread David Faure
https://bugs.kde.org/show_bug.cgi?id=420364

--- Comment #2 from David Faure  ---
Oh, wait, I get it. The switch from KParts::ReadOnlyPart to KParts::Part made
us lose the automatic caption handling that was happening in
KParts::ReadOnlyPart::guiActivateEvent.

How unexpected ;)
Oh well, it's cleaner this way. I'll fix it.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kontact] [Bug 420364] Kontact window has wrong title

2020-04-23 Thread David Faure
https://bugs.kde.org/show_bug.cgi?id=420364

--- Comment #1 from David Faure  ---
I confirm, but I'm surprised that it's a regression (IOW I wonder how it ever
worked).
Does openQA have the information of what was the last version where it worked?
(Qt5, KF5, kdepim -- I suspect the change was either in KF5 or in Qt5)

Excellent GUI regression system you guys have, in any case.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kontact] [Bug 420192] New to-do button failure

2020-04-17 Thread David Faure
https://bugs.kde.org/show_bug.cgi?id=420192

David Faure  changed:

   What|Removed |Added

 CC||fa...@kde.org
 Status|REPORTED|ASSIGNED
   Assignee|kdepim-bugs@kde.org |fa...@kde.org
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kontact] [Bug 408675] KMail crashes sometimes when clicking on toolbar button "Reply"

2020-04-16 Thread David Faure
https://bugs.kde.org/show_bug.cgi?id=408675

--- Comment #3 from David Faure  ---
My wife has been hitting this crash regularly for the last few years.
Let's try to see what frame #6 might be.

One possibility would be:
#5  QMenuSloppyState::stopTimer() { m_time.stop(); }
QMenuSloppyState::reset()
#6  QMenuSloppyState::enter()
#7  QMenu::enterEvent(QEvent*)

But for #5 to crash, `this` must be deleted, but then the other member vars
accessed in reset() would crash too.

Alternatively, this comes from m_parent->childEnter().

#5  QMenuSloppyState::stopTimer() { m_time.stop(); }
QMenuSloppyState::childEnter() on the parent
#6  QMenuSloppyState::enter()  calls m_parent->childEnter();
#7  QMenu::enterEvent(QEvent*)

This seems more likely, m_parent would be a dangling pointer. But m_parent only
happens with submenus...
There are submenus in the "Reply" toolbutton, but the mouse is nowhere near
those... or maybe that's what triggers it?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kontact] [Bug 418356] Kontact crashes when I clicked on the button "Answer All" in mail view

2020-04-16 Thread David Faure
https://bugs.kde.org/show_bug.cgi?id=418356

David Faure  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|REPORTED|RESOLVED
 CC||fa...@kde.org

--- Comment #1 from David Faure  ---


*** This bug has been marked as a duplicate of bug 408675 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kontact] [Bug 408675] KMail crashes sometimes when clicking on toolbar button "Reply"

2020-04-16 Thread David Faure
https://bugs.kde.org/show_bug.cgi?id=408675

David Faure  changed:

   What|Removed |Added

Summary|Kontact random crashes  |KMail crashes sometimes
   ||when clicking on toolbar
   ||button "Reply"
 CC||fa...@kde.org

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kontact] [Bug 408675] Kontact random crashes

2020-04-16 Thread David Faure
https://bugs.kde.org/show_bug.cgi?id=408675

David Faure  changed:

   What|Removed |Added

 CC||rob...@riemann.cc

--- Comment #2 from David Faure  ---
*** Bug 418356 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[korganizer] [Bug 408898] new calendar event cannot be modified while dialog remains open

2020-04-04 Thread David Faure
https://bugs.kde.org/show_bug.cgi?id=408898

David Faure  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|REPORTED|RESOLVED
 CC||fa...@kde.org

--- Comment #1 from David Faure  ---


*** This bug has been marked as a duplicate of bug 407965 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[korganizer] [Bug 407965] Applying two changes in a row in the event editor fails with "Only resources can modify remote identifiers"

2020-04-04 Thread David Faure
https://bugs.kde.org/show_bug.cgi?id=407965

David Faure  changed:

   What|Removed |Added

   Assignee|kdepim-bugs@kde.org |fa...@kde.org
 CC||fa...@kde.org

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Akonadi] [Bug 418910] When Event Not found it stop fetching

2020-03-16 Thread David Faure
https://bugs.kde.org/show_bug.cgi?id=418910

David Faure  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 CC||fa...@kde.org
 Status|REPORTED|RESOLVED

--- Comment #1 from David Faure  ---
I think I fixed that exact problem on March 4.
https://phabricator.kde.org/D27858
commit c06a673cf6b4de7ebb0d4e9b9 in kdepim-runtime, both release/19.12 branch
and master.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmail2] [Bug 415850] "Move message to folder" dialog does not accept certain characters

2020-01-15 Thread David Faure
https://bugs.kde.org/show_bug.cgi?id=415850

--- Comment #2 from David Faure  ---
Git commit 081d57ce53d0a4cdad72f3e77db91ac0e139fdae by David Faure.
Committed on 15/01/2020 at 08:16.
Pushed by dfaure into branch 'release/19.12'.

Fix support for dead keys in foldertreewidget filtering

Summary:
FIXED-IN: 5.13.2

Test Plan:
I can jump to a folder called abédêf with FR layout.
Doesn't seem to work with compose key though.

Reviewers: mlaurent

Reviewed By: mlaurent

Differential Revision: https://phabricator.kde.org/D26682

M  +1-2src/folder/folderselectiondialog.cpp
M  +6-0src/folder/foldertreewidget.cpp

https://commits.kde.org/mailcommon/081d57ce53d0a4cdad72f3e77db91ac0e139fdae

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmail2] [Bug 416086] kmail crashes when opening message (small 7bit empty html table, editor viewable)

2020-01-10 Thread David Faure
https://bugs.kde.org/show_bug.cgi?id=416086

David Faure  changed:

   What|Removed |Added

 Status|REPORTED|RESOLVED
 Resolution|--- |UPSTREAM
 CC||fa...@kde.org

--- Comment #6 from David Faure  ---
I fixed this in https://bugreports.qt.io/browse/QTBUG-80496

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kontact] [Bug 414137] crashed after changing application language to English (UK), which wasn't installed

2019-11-25 Thread David Faure
https://bugs.kde.org/show_bug.cgi?id=414137

--- Comment #1 from David Faure  ---
Git commit 093ed784baf95531cb7526766e3e1fef925ae188 by David Faure.
Committed on 25/11/2019 at 22:34.
Pushed by dfaure into branch 'release/19.12'.

kontact: simplify ksycoca-related startup code

Summary:
ksycoca is rebuilt in process these days, looping and waiting
[for kbuildsycoca] makes no sense anymore [for a long time now].

Test Plan:
deleted ksycoca file, started kontact, it said "rebuilding ksycoca"
and started up fine

Reviewers: mlaurent, winterz, vkrause

Reviewed By: vkrause

Subscribers: kde-pim

Tags: #kde_pim

Differential Revision: https://phabricator.kde.org/D25531

M  +6-27   src/mainwindow.cpp
M  +0-1src/mainwindow.h

https://commits.kde.org/kontact/093ed784baf95531cb7526766e3e1fef925ae188

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Akonadi] [Bug 401054] Stream parser exceptions

2019-10-24 Thread David Faure
https://bugs.kde.org/show_bug.cgi?id=401054

--- Comment #4 from David Faure  ---
Well, either that or the socket got closed meanwhile. I managed to reproduce
this a few times so I added a QElapsedTimer and 0 ms had elapsed. So it wasn't
a timeout, but a closed socket, very likely.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[korganizer] [Bug 413316] Can't see the contents of my Nextcloud calendar

2019-10-24 Thread David Faure
https://bugs.kde.org/show_bug.cgi?id=413316

David Faure  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|REPORTED|RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[korganizer] [Bug 413316] Can't see the contents of my Nextcloud calendar

2019-10-23 Thread David Faure
https://bugs.kde.org/show_bug.cgi?id=413316

--- Comment #3 from David Faure  ---
BTW if you want to downgrade anything, short term, it's kio that you should
downgrade (or all of KF5) from 5.63 to 5.62.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[korganizer] [Bug 413316] Can't see the contents of my Nextcloud calendar

2019-10-23 Thread David Faure
https://bugs.kde.org/show_bug.cgi?id=413316

David Faure  changed:

   What|Removed |Added

 CC||fa...@kde.org,
   ||vkra...@kde.org

--- Comment #2 from David Faure  ---
I just fixed a regression in kio_http which led to a similar issue for me.
https://cgit.kde.org/kio.git/commit/?id=02a8d3deb4f97046da4a0bb79abf9510d2d1c0a2

However that last comment makes me wonder. If Depth:0 came from kio_http and
Depth:1 came from kdav, then things might still be wrong, since my patch
ignores the kdav-provided depth.

Any chance you can try the above kio fix and let us know if it works for you?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Akonadi] [Bug 401054] Stream parser exceptions

2019-10-22 Thread David Faure
https://bugs.kde.org/show_bug.cgi?id=401054

David Faure  changed:

   What|Removed |Added

 CC||fa...@kde.org

--- Comment #3 from David Faure  ---
This error (which comes from the function below in kimap) means that no data
came onto the IMAP socket for 30 seconds. I guess this could happen with very
slow networks?


bool ImapStreamParser::waitForMoreData(bool wait)
{
if (wait) {
if (m_socket->bytesAvailable() > 0 ||
m_socket->waitForReadyRead(3)) {
m_data.append(m_socket->readAll());
} else {
return false;
}
}
return true;
}

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kcalcore] [Bug 401118] kcalcore 18.11.80 fails some tests

2019-10-12 Thread David Faure
https://bugs.kde.org/show_bug.cgi?id=401118

David Faure  changed:

   What|Removed |Added

 CC||fa...@kde.org

--- Comment #3 from David Faure  ---
Does this still happen in KDE Frameworks 5.63, released today?
I think https://phabricator.kde.org/D24089 might have fixed that

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kcalcore] [Bug 345682] zanshin 0.2.1-1074-ge570d19 doesn't show projects as projects after sync

2019-10-12 Thread David Faure
https://bugs.kde.org/show_bug.cgi?id=345682

David Faure  changed:

   What|Removed |Added

 Status|REPORTED|RESOLVED
 Resolution|--- |FIXED
 CC||fa...@kde.org

--- Comment #2 from David Faure  ---
I believe I fixed this in https://phabricator.kde.org/D19238

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kcalcore] [Bug 381013] Qt5/KF5 port of libkcalcore

2019-10-12 Thread David Faure
https://bugs.kde.org/show_bug.cgi?id=381013

David Faure  changed:

   What|Removed |Added

 CC||fa...@kde.org
 Resolution|LATER   |FIXED

--- Comment #2 from David Faure  ---
This has been done.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Akonadi] [Bug 399167] Akonadi enters deadlock state which makes it completely unuseable

2019-08-16 Thread David Faure
https://bugs.kde.org/show_bug.cgi?id=399167

--- Comment #24 from David Faure  ---
Git commit 15c91a0ac93051465b37807efceb6e9fd36cb73b by David Faure.
Committed on 16/08/2019 at 09:27.
Pushed by dfaure into branch 'Applications/18.12'.

Akonadi: fix dangling transaction after itemsync failure

Summary:
TransactionSequence was emitting result() twice when rolling back.

* How did this happen?
The TransactionRollbackJob is (automatically) added as a subjob of the
TransactionSequence, so when it finishes, slotResult is called (like for
all subjobs), as well as rollbackResult().
Since the latter emits result() already [mostly for symmetry with
commitResult()], we don't need to do that in slotResult (which doesn't do
it for the case of committing, either).

* Why is it a problem to emit result() twice?
Well, first, it's against the law in KJob world. In practice,
ItemSyncPrivate::slotTransactionResult was called twice (for the same
TransactionSequence job) which made it decrement mTransactionJobs one
time too many.
As a result, checkDone() finished too early and didn't go into the
"commit transaction" branch for other transactions.
Leaving a transaction "open" is a good recipe for database deadlocks further
down the line.

* Why did the TransactionSequence roll back in the first place?
In my case because of the infamous and not-yet fixed "Multiple merge
candidates" problem, but it seems that it can also happen when having
items without a part, according to Volker's investigations.
All of these issues still need to be fixed, but at least akonadi seems
to be still usable after they happen.

Test Plan: Ctrl+L in kmail, with a folder having multiple items for the same
RID

Reviewers: dvratil, vkrause

Reviewed By: dvratil

Subscribers: kfunk, kde-pim

Tags: #kde_pim

Differential Revision: https://phabricator.kde.org/D19487

(cherry picked from commit f1281cf18f40fd69acd61c31b48f5ce43e138eea)
(cherry picked from commit 8ff596c4fe15199b66262c624d8b7c8d8ec7368f)

M  +0-2src/core/jobs/transactionsequence.cpp

https://commits.kde.org/akonadi/15c91a0ac93051465b37807efceb6e9fd36cb73b

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Akonadi] [Bug 409753] Duplicate column name 'version' QMYSQL

2019-07-21 Thread David Faure
https://bugs.kde.org/show_bug.cgi?id=409753

David Faure  changed:

   What|Removed |Added

 CC||fa...@kde.org

--- Comment #4 from David Faure  ---
This happens on external MySQL servers, since they don't usually have the
option lower_case_table_names=1 enabled, so the (new) toLower() call assumes
that option to be present.

So the immediate fix is to lowercase your table names. I'm not sure doing that
at the filesystem level is enough, they're probably listed in the global mysql
DB too. Instead you can use mysqldump, lowercase the table names, and reimport.

The external MySQL server feature assumes that your MySQL matches the
requirements for Akonadi. This includes InnoDB and lowercase table names, at
least.
See /etc/xdg/akonadi/mysql-global.conf for the settings used by akonadi.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kontact] [Bug 404881] Kontact crashes when closing Akregator from tray icon

2019-06-06 Thread David Faure
https://bugs.kde.org/show_bug.cgi?id=404881

David Faure  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://commits.kde.org/kma
   ||il/97e165dcf5a851ee10526631
   ||d24f9af7736da2e6
 Status|REPORTED|RESOLVED
   Version Fixed In||19.04.2

--- Comment #1 from David Faure  ---
Git commit 97e165dcf5a851ee10526631d24f9af7736da2e6 by David Faure.
Committed on 06/06/2019 at 17:50.
Pushed by dfaure into branch 'Applications/19.04'.

Fix kontact crash on logout.

Summary:
KMail was creating new Akonadi jobs during mainwindow destruction,
due to not testing the bool in GuiActivateEvent.

Same bt in bug 404881, apparently quitting from the akregator tray icon
[which quits all of kontact... separate issue...] gave the same crash.
FIXED-IN: 19.04.2

Test Plan: Run kontact, logout. Hello Drkonqi.

Reviewers: mlaurent, winterz

Reviewed By: mlaurent, winterz

Subscribers: kde-pim

Tags: #kde_pim

Differential Revision: https://phabricator.kde.org/D21626

M  +12   -11   src/kmail_part.cpp

https://commits.kde.org/kmail/97e165dcf5a851ee10526631d24f9af7736da2e6

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmail2] [Bug 404698] Decryption Oracle based on replying to PGP or S/MIME encrypted emails

2019-04-22 Thread David Faure
https://bugs.kde.org/show_bug.cgi?id=404698

--- Comment #12 from David Faure  ---
About the original suggestion: "Do not decrypt emails unless the PGP or S/MIME
encrypted part is the root node -- and therefore the only part -- in the MIME
tree (exception: multipart/signed for encrypted-then-signed S/MIME messages)."

This would mean if you attach a non-encrypted image (say, company logo) to an
encrypted email, the recipient can't reply to the email anymore? I think we
always want to decrypt the main text part? (fuzzy term, I don't know what the
actual logic is in kmail, but I mean the text that gets quoted).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmail2] [Bug 404698] Decryption Oracle based on replying to PGP or S/MIME encrypted emails

2019-04-21 Thread David Faure
https://bugs.kde.org/show_bug.cgi?id=404698

David Faure  changed:

   What|Removed |Added

 CC||fa...@kde.org

--- Comment #11 from David Faure  ---
Interesting problem. Here's my feedback.

- Preventing KMail from *sending* such messages would obviously be no help (one
could just craft that message by hand or using another email client). 

- Preventing the user from replying to such a message would be very weird user
experience (sorry, you are not allowed to reply to this message!)

- So I guess the best solution is that when replying, we don't decrypt parts
that were encrypted in the original message. I.e. if we are replying with a
copy of those parts, and they were encrypted, they should be copied "as is".
This would prevent any newly-added recipient from reading those, but that's
fair enough I would say.
I wouldn't really know how to implement this though.
Might be tricky if the tree in memory only has the decrypted version.

- Alternatively, KMail could say "for security reasons, these parts are going
to be removed from your reply". But this also requires that we somehow know
that these parts used to be encrypted in the original email.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Akonadi] [Bug 399167] Akonadi enters deadlock state which makes it completely unuseable

2019-04-07 Thread David Faure
https://bugs.kde.org/show_bug.cgi?id=399167

--- Comment #23 from David Faure  ---
Oh, and about part-less items, I just noticed that I had a bunch in a spam
folder, and after syncing that folder, the same query returns nothing. So it
seems to me that a successful sync clears that up. In other words, it would be
a consequence of a stuck sync -- not the cause for it.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Akonadi] [Bug 399167] Akonadi enters deadlock state which makes it completely unuseable

2019-04-07 Thread David Faure
https://bugs.kde.org/show_bug.cgi?id=399167

--- Comment #22 from David Faure  ---
Additional fix pushed in
https://cgit.kde.org/akonadi.git/commit/?id=257598195d09b1022ebf08cd58245cd3493f5a2e
for 19.04

Note: all this is about akonadi not getting stuck when the "multiple merge
candidates" problem happens. The problem itself isn't fixed yet, for lack of a
reproducible testcase.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Akonadi] [Bug 399167] Akonadi enters deadlock state which makes it completely unuseable

2019-04-04 Thread David Faure
https://bugs.kde.org/show_bug.cgi?id=399167

--- Comment #21 from David Faure  ---
Found one more problem https://phabricator.kde.org/D20243

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Akonadi] [Bug 401692] Akonadi components crash on logout

2019-03-25 Thread David Faure
https://bugs.kde.org/show_bug.cgi?id=401692

David Faure  changed:

   What|Removed |Added

 Status|REPORTED|RESOLVED
 Resolution|--- |FIXED

--- Comment #25 from David Faure  ---
Should be fixed in the 19.04 release, see https://phabricator.kde.org/D19983

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Akonadi] [Bug 399167] Akonadi enters deadlock state which makes it completely unuseable

2019-03-21 Thread David Faure
https://bugs.kde.org/show_bug.cgi?id=399167

David Faure  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED

--- Comment #20 from David Faure  ---
Both fixes have been pushed in Applications/19.04 branch.

(The fix for canceling is https://phabricator.kde.org/D19488)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Akonadi] [Bug 399167] Akonadi enters deadlock state which makes it completely unuseable

2019-03-21 Thread David Faure
https://bugs.kde.org/show_bug.cgi?id=399167

--- Comment #19 from David Faure  ---
Git commit 8ff596c4fe15199b66262c624d8b7c8d8ec7368f by David Faure.
Committed on 21/03/2019 at 15:50.
Pushed by dfaure into branch 'Applications/19.04'.

Akonadi: fix dangling transaction after itemsync failure

Summary:
TransactionSequence was emitting result() twice when rolling back.

* How did this happen?
The TransactionRollbackJob is (automatically) added as a subjob of the
TransactionSequence, so when it finishes, slotResult is called (like for
all subjobs), as well as rollbackResult().
Since the latter emits result() already [mostly for symmetry with
commitResult()], we don't need to do that in slotResult (which doesn't do
it for the case of committing, either).

* Why is it a problem to emit result() twice?
Well, first, it's against the law in KJob world. In practice,
ItemSyncPrivate::slotTransactionResult was called twice (for the same
TransactionSequence job) which made it decrement mTransactionJobs one
time too many.
As a result, checkDone() finished too early and didn't go into the
"commit transaction" branch for other transactions.
Leaving a transaction "open" is a good recipe for database deadlocks further
down the line.

* Why did the TransactionSequence roll back in the first place?
In my case because of the infamous and not-yet fixed "Multiple merge
candidates" problem, but it seems that it can also happen when having
items without a part, according to Volker's investigations.
All of these issues still need to be fixed, but at least akonadi seems
to be still usable after they happen.

Test Plan: Ctrl+L in kmail, with a folder having multiple items for the same
RID

Reviewers: dvratil, vkrause

Reviewed By: dvratil

Subscribers: kfunk, kde-pim

Tags: #kde_pim

Differential Revision: https://phabricator.kde.org/D19487

(cherry picked from commit f1281cf18f40fd69acd61c31b48f5ce43e138eea)

M  +0-2src/core/jobs/transactionsequence.cpp

https://commits.kde.org/akonadi/8ff596c4fe15199b66262c624d8b7c8d8ec7368f

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Akonadi] [Bug 399167] Akonadi enters deadlock state which makes it completely unuseable

2019-03-21 Thread David Faure
https://bugs.kde.org/show_bug.cgi?id=399167

--- Comment #18 from David Faure  ---
Git commit f1281cf18f40fd69acd61c31b48f5ce43e138eea by David Faure.
Committed on 21/03/2019 at 15:49.
Pushed by dfaure into branch 'master'.

Akonadi: fix dangling transaction after itemsync failure

Summary:
TransactionSequence was emitting result() twice when rolling back.

* How did this happen?
The TransactionRollbackJob is (automatically) added as a subjob of the
TransactionSequence, so when it finishes, slotResult is called (like for
all subjobs), as well as rollbackResult().
Since the latter emits result() already [mostly for symmetry with
commitResult()], we don't need to do that in slotResult (which doesn't do
it for the case of committing, either).

* Why is it a problem to emit result() twice?
Well, first, it's against the law in KJob world. In practice,
ItemSyncPrivate::slotTransactionResult was called twice (for the same
TransactionSequence job) which made it decrement mTransactionJobs one
time too many.
As a result, checkDone() finished too early and didn't go into the
"commit transaction" branch for other transactions.
Leaving a transaction "open" is a good recipe for database deadlocks further
down the line.

* Why did the TransactionSequence roll back in the first place?
In my case because of the infamous and not-yet fixed "Multiple merge
candidates" problem, but it seems that it can also happen when having
items without a part, according to Volker's investigations.
All of these issues still need to be fixed, but at least akonadi seems
to be still usable after they happen.

Test Plan: Ctrl+L in kmail, with a folder having multiple items for the same
RID

Reviewers: dvratil, vkrause

Reviewed By: dvratil

Subscribers: kfunk, kde-pim

Tags: #kde_pim

Differential Revision: https://phabricator.kde.org/D19487

M  +0-2src/core/jobs/transactionsequence.cpp

https://commits.kde.org/akonadi/f1281cf18f40fd69acd61c31b48f5ce43e138eea

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Akonadi] [Bug 399167] Akonadi enters deadlock state which makes it completely unuseable

2019-03-11 Thread David Faure
https://bugs.kde.org/show_bug.cgi?id=399167

--- Comment #16 from David Faure  ---
I debugged this and came up with https://phabricator.kde.org/D19487

It breaks canceling (as a user, clicking on the progress item to cancel), but
if you stay away from canceling, you can try that patch to make akonadi more
useable. I'm working on fixing canceling

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kontact] [Bug 399881] Kontact message list unresponsive

2019-03-11 Thread David Faure
https://bugs.kde.org/show_bug.cgi?id=399881

David Faure  changed:

   What|Removed |Added

 CC||fa...@kde.org

--- Comment #3 from David Faure  ---
The knut resource is only used by unittests, it's very strange that it would
show up in your setup !?

The message "ProtocolException thrown:Failed to write data to stream" makes me
think this is a duplicate of https://bugs.kde.org/show_bug.cgi?id=401692

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Akonadi] [Bug 402396] Throwing exceptions from an event handler is not supported in Qt

2019-03-11 Thread David Faure
https://bugs.kde.org/show_bug.cgi?id=402396

David Faure  changed:

   What|Removed |Added

 Status|REPORTED|RESOLVED
 Resolution|--- |DUPLICATE
 CC||fa...@kde.org

--- Comment #1 from David Faure  ---


*** This bug has been marked as a duplicate of bug 401692 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Akonadi] [Bug 401692] Akonadi components crash on logout

2019-03-11 Thread David Faure
https://bugs.kde.org/show_bug.cgi?id=401692

David Faure  changed:

   What|Removed |Added

 CC||jer...@acjlaw.net

--- Comment #24 from David Faure  ---
*** Bug 402396 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Akonadi] [Bug 401692] Akonadi components crash on logout

2019-03-11 Thread David Faure
https://bugs.kde.org/show_bug.cgi?id=401692

David Faure  changed:

   What|Removed |Added

 CC||fa...@kde.org

--- Comment #23 from David Faure  ---
The backtraces aren't very useful, but the error logs are much more informative
in such cases (see ~/.xsession-errors or ~/.local/share/sddm/xorg-session.log
for sddm users).

This bug is about "ProtocolException thrown:Failed to write data to stream"
right?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Akonadi] [Bug 399167] Akonadi enters deadlock state which makes it completely unuseable

2019-01-08 Thread David Faure
https://bugs.kde.org/show_bug.cgi?id=399167

David Faure  changed:

   What|Removed |Added

 CC||fa...@kde.org

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Akonadi] [Bug 397515] crash (reentrancy, null mutex) in akonadiserver when moving an email

2018-08-16 Thread David Faure
https://bugs.kde.org/show_bug.cgi?id=397515

David Faure  changed:

   What|Removed |Added

   Assignee|kdepim-bugs@kde.org |dvra...@kde.org

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Akonadi] [Bug 397515] New: crash (reentrancy, null mutex) in akonadiserver when moving an email

2018-08-16 Thread David Faure
https://bugs.kde.org/show_bug.cgi?id=397515

Bug ID: 397515
   Summary: crash (reentrancy, null mutex) in akonadiserver when
moving an email
   Product: Akonadi
   Version: 5.8.3
  Platform: openSUSE RPMs
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: server
  Assignee: kdepim-bugs@kde.org
  Reporter: fa...@kde.org
  Target Milestone: ---

Application: akonadiserver (5.8.2)

Qt Version: 5.11.1
Frameworks Version: 5.47.0
Operating System: Linux 4.4.138-59-default x86_64
Distribution: "openSUSE Leap 42.3"

-- Information about the crash:
Hi Dan :)
Sabine got this crash twice in a row today, with 18.04.2 opensuse packages.
Triggered simply by moving a mail from the imap inbox to another imap folder. I
know you rewrote the notification stuff, but is this use of QEventLoop::exec
still there in NotificationManager::waitForSocketData()? Note how it leads to
unexpected reentrancy, NotificationManager::emitPendingNotifications() being
called via a timer, and I think this could be the reason for the crash?

-- Backtrace:
Application: Akonadi Server (akonadiserver), signal: Segmentation fault

Thread 3 (Thread 0x7f21e203f700 (LWP 5433)):
[KCrash Handler]
#6  std::__atomic_base::compare_exchange_strong
(__m2=std::memory_order_acquire, __m1=std::memory_order_acquire, __p2=0x1,
__p1=@0x7f21e203e0e0: 0x0, this=0x10) at
/usr/include/c++/4.8/bits/atomic_base.h:844
#7  std::atomic::compare_exchange_strong
(__m2=std::memory_order_acquire, __m1=std::memory_order_acquire, __p2=0x1,
__p1=@0x7f21e203e0e0: 0x0, this=0x10) at /usr/include/c++/4.8/atomic:432
#8  QAtomicOps::testAndSetAcquire
(currentValue=, newValue=0x1, expectedValue=0x0,
_q_value=...) at ../../src/corelib/thread/qatomic_cxx11.h:290
#9  QBasicAtomicPointer::testAndSetAcquire (currentValue=: , newValue=0x1, expectedValue=0x0, this=0x10) at
../../src/corelib/thread/qbasicatomic.h:263
#10 QBasicMutex::fastTryLock (current=: ,
this=0x10) at thread/qmutex.h:107
#11 QMutex::lock (this=0x10) at thread/qmutex.cpp:224
#12 0x004fd149 in
Akonadi::Server::NotificationSubscriber::notify(QSharedPointer
const&) ()
#13 0x004f82ab in
Akonadi::Server::NotificationManager::emitPendingNotifications() ()
#14 0x7f21ecd2ec13 in QtPrivate::QSlotObjectBase::call (a=0x7f21e203e3a0,
r=0xc6fd90, this=0x7f21d4003220) at
../../src/corelib/kernel/qobjectdefs_impl.h:376
#15 QMetaObject::activate (sender=sender@entry=0x7f21d40013d0,
signalOffset=, local_signal_index=local_signal_index@entry=0,
argv=argv@entry=0x7f21e203e3a0) at kernel/qobject.cpp:3754
#16 0x7f21ecd2f227 in QMetaObject::activate
(sender=sender@entry=0x7f21d40013d0, m=m@entry=0x7f21ed180420
, local_signal_index=local_signal_index@entry=0,
argv=argv@entry=0x7f21e203e3a0) at kernel/qobject.cpp:3633
#17 0x7f21ecd3bf57 in QTimer::timeout (this=this@entry=0x7f21d40013d0,
_t1=_t1@entry=...) at .moc/moc_qtimer.cpp:200
#18 0x7f21ecd3c232 in QTimer::timerEvent (this=0x7f21d40013d0, e=) at kernel/qtimer.cpp:255
#19 0x7f21ecd2fd44 in QObject::event (this=0x7f21d40013d0, e=) at kernel/qobject.cpp:1232
#20 0x7f21ecd048f5 in QCoreApplication::notifyInternal2
(receiver=0x7f21d40013d0, event=event@entry=0x7f21e203e580) at
kernel/qcoreapplication.cpp:1048
#21 0x7f21ecd5688e in QCoreApplication::sendEvent (event=0x7f21e203e580,
receiver=) at ../../src/corelib/kernel/qcoreapplication.h:234
#22 QTimerInfoList::activateTimers (this=0x7f21d4002ed0) at
kernel/qtimerinfo_unix.cpp:643
#23 0x7f21ecd56ed1 in timerSourceDispatch (source=) at
kernel/qeventdispatcher_glib.cpp:182
#24 0x7f21e8c6d134 in g_main_context_dispatch () from
/usr/lib64/libglib-2.0.so.0
#25 0x7f21e8c6d388 in ?? () from /usr/lib64/libglib-2.0.so.0
#26 0x7f21e8c6d42c in g_main_context_iteration () from
/usr/lib64/libglib-2.0.so.0
#27 0x7f21ecd5721b in QEventDispatcherGlib::processEvents
(this=0x7f21d40008c0, flags=...) at kernel/qeventdispatcher_glib.cpp:425
#28 0x7f21ecd0308b in QEventLoop::exec (this=0x7f21e203e810, flags=...) at
kernel/qeventloop.cpp:214
#29 0x004f8cba in
Akonadi::Server::NotificationManager::waitForSocketData() ()
#30 0x7f21ecd3bfc6 in QtPrivate::QSlotObjectBase::call (a=0x7f21e203e8b0,
r=, this=) at
../../src/corelib/kernel/qobjectdefs_impl.h:376
#31 QSingleShotTimer::timerEvent (this=0x7f21d4010850) at kernel/qtimer.cpp:318
#32 0x7f21ecd2fd44 in QObject::event (this=0x7f21d4010850, e=) at kernel/qobject.cpp:1232
#33 0x7f21ecd048f5 in QCoreApplication::notifyInternal2
(receiver=0x7f21d4010850, event=event@entry=0x7f21e203ea70) at
kernel/qcoreapplication.cpp:1048
#34 0x7f21ecd5688e in QCoreApplication::sendEvent (event=0x7f21e203ea70,
receiver=) at ../../src/corelib/kernel/qcoreapplication.h:234
#35 QTimerInfoList::activateTimers (this=0x7f21d4002ed0) at
kernel/qtimerinfo_unix.cpp:643
#36 0x7f21ecd56ed1 in 

[kmail2] [Bug 396339] [Kmail] Main and status toolbars options not remembered

2018-07-31 Thread David Faure
https://bugs.kde.org/show_bug.cgi?id=396339

David Faure  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|REOPENED|RESOLVED
  Latest Commit||https://commits.kde.org/kma
   ||il/814f0db2a1ae5b15bf91909c
   ||e80a5d6792f9aeed

--- Comment #5 from David Faure  ---
Git commit 814f0db2a1ae5b15bf91909ce80a5d6792f9aeed by David Faure.
Committed on 31/07/2018 at 13:46.
Pushed by dfaure into branch 'Applications/18.08'.

Port to setAutoSaveSettings so that saving happens before hiding.

Summary:
See d35a882895 in kxmlgui for more complete explanation.
Related: bug 395988

Test Plan: kmail ; Alt+F4 ; kmail -> now the statusbar and toolbar are visible
again

Reviewers: ngraham, elvisangelaccio, broulik, cfeck, mlaurent

Reviewed By: mlaurent

Subscribers: kde-pim

Tags: #kde_pim

Differential Revision: https://phabricator.kde.org/D14454

M  +1-5src/kmmainwin.cpp

https://commits.kde.org/kmail/814f0db2a1ae5b15bf91909ce80a5d6792f9aeed

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmail2] [Bug 396339] [Kmail] Main and status toolbars options not remembered

2018-07-29 Thread David Faure
https://bugs.kde.org/show_bug.cgi?id=396339

David Faure  changed:

   What|Removed |Added

 CC||fa...@kde.org

--- Comment #4 from David Faure  ---
Suggested fix https://phabricator.kde.org/D14454

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmail2] [Bug 393538] MessageViewer Crash in GrantleeTheme

2018-05-08 Thread David Faure
https://bugs.kde.org/show_bug.cgi?id=393538

David Faure <fa...@kde.org> changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED

--- Comment #2 from David Faure <fa...@kde.org> ---
Yeah I fixed that.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmailtransport] [Bug 392049] weird mailtransport issue (sending only part of the email)

2018-04-22 Thread David Faure
https://bugs.kde.org/show_bug.cgi?id=392049

David Faure <fa...@kde.org> changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://commits.kde.org/ksm
   ||tp/988e0649860952ed05501502
   ||a62af3ccc75afc8f
   Version Fixed In||18.04
 Status|CONFIRMED   |RESOLVED

--- Comment #3 from David Faure <fa...@kde.org> ---
Git commit 988e0649860952ed05501502a62af3ccc75afc8f by David Faure.
Committed on 22/04/2018 at 09:57.
Pushed by dfaure into branch 'Applications/18.04'.

KSMTP: Fix sending emails where a line starts with a dot

Summary:
My previous fix was incomplete because it only considered lines
with a single dot, and not the case where two such lines followed each
other.
FIXED-IN: 18.04

Test Plan: Updated unittest.

Reviewers: dvratil, mlaurent

Subscribers: #kde_pim

Differential Revision: https://phabricator.kde.org/D12434

M  +7-2autotests/smtptest.cpp
M  +1-1src/sendjob.cpp

https://commits.kde.org/ksmtp/988e0649860952ed05501502a62af3ccc75afc8f

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmailtransport] [Bug 392049] weird mailtransport issue (sending only part of the email)

2018-04-22 Thread David Faure
https://bugs.kde.org/show_bug.cgi?id=392049

--- Comment #2 from David Faure <fa...@kde.org> ---
https://phabricator.kde.org/D12434

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmail2] [Bug 383070] Crash in GrantleeTheme::ThemeManager::Private::updateActionList() when reinstalling KMail at runtime

2018-04-22 Thread David Faure
https://bugs.kde.org/show_bug.cgi?id=383070

David Faure <fa...@kde.org> changed:

   What|Removed |Added

   Version Fixed In||18.04
 Resolution|--- |FIXED
  Latest Commit||https://commits.kde.org/kde
   ||pim-addons/f3da346dcecd7d8f
   ||f83582a24b0bcc4ce01d4302
 Status|UNCONFIRMED |RESOLVED

--- Comment #3 from David Faure <fa...@kde.org> ---
Git commit f3da346dcecd7d8ff83582a24b0bcc4ce01d4302 by David Faure.
Committed on 22/04/2018 at 08:58.
Pushed by dfaure into branch 'Applications/18.04'.

Fix GrantleeTheme::ThemeManager being leaked.

Summary:
When a Viewer was deleted, its ThemeManager was kept alive.
So it would still react to KDirWatch (when installing files) and it
would try to update a menu (QActionGroup) that was deleted with the
viewer.
FIXED-IN: 18.04

Test Plan:
KMail, Enter to open separate viewer, Alt+F4, (uncommitted)
debug output shows that now the ThemeManager is deleted, while it wasn't
before.

Reviewers: mlaurent

Reviewed By: mlaurent

Subscribers: #kde_pim

Tags: #kde_pim

Differential Revision: https://phabricator.kde.org/D12431

M  +1-1   
plugins/messageviewerheaderplugins/grantleeheaderstyleplugin/grantleeheaderstyleinterface.cpp

https://commits.kde.org/kdepim-addons/f3da346dcecd7d8ff83582a24b0bcc4ce01d4302

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmailtransport] [Bug 392049] weird mailtransport issue (sending only part of the email)

2018-03-19 Thread David Faure
https://bugs.kde.org/show_bug.cgi?id=392049

David Faure <fa...@kde.org> changed:

   What|Removed |Added

 CC||fa...@kde.org

--- Comment #1 from David Faure <fa...@kde.org> ---
Confirmed, my fix for a similar problem (ksmtp commit 6194f93,
https://phabricator.kde.org/D9972) doesn't appear to be enough for this
particular testcase.

(My testcase was attaching a text file whose first line was just a dot)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Akonadi] [Bug 360313] akonadi_davgroupware_resource doesn't respond on return

2018-01-07 Thread David Faure
https://bugs.kde.org/show_bug.cgi?id=360313

--- Comment #2 from David Faure <fa...@kde.org> ---
The reason I'm asking is that there is the dialog to configure the resource
(initially, at least, but I don't know if it reappears later on), there's the
kwallet dialog, there's maybe a password dialog that appears when kwallet is
disabled... and in my case I use kwallet so there is in fact no password dialog
popping up at all. Hence the request for clarification.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Akonadi] [Bug 360313] akonadi_davgroupware_resource doesn't respond on return

2018-01-07 Thread David Faure
https://bugs.kde.org/show_bug.cgi?id=360313

David Faure <fa...@kde.org> changed:

   What|Removed |Added

 CC||fa...@kde.org

--- Comment #1 from David Faure <fa...@kde.org> ---
Can you post a screenshot so we can be sure which dialog this is about?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmail2] [Bug 387025] KMail crashes when launched

2017-12-23 Thread David Faure
https://bugs.kde.org/show_bug.cgi?id=387025

--- Comment #4 from David Faure <fa...@kde.org> ---
To remove drkonqi from the equation, simply export KDE_DEBUG=1.

Either this is a miscompilation... or I did something wrong in terms of
KConfigGroup lifetime in https://phabricator.kde.org/D8783 ... but the calling
code is simply
KConfigGroup grp(KernelIf->config(), "CollectionTreeOrder");
d->entityOrderProxy->setOrderConfig(grp);
which should be fine...

Does this still happen?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmail2] [Bug 387873] can no longer drag/drop a message from message list to favorites

2017-12-19 Thread David Faure
https://bugs.kde.org/show_bug.cgi?id=387873

David Faure <fa...@kde.org> changed:

   What|Removed |Added

  Latest Commit||https://commits.kde.org/mai
   ||lcommon/ace9cfb46008e4fcd2b
   ||973111fbc508110bbd9c9
 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED

--- Comment #1 from David Faure <fa...@kde.org> ---
Git commit ace9cfb46008e4fcd2b973111fbc508110bbd9c9 by David Faure.
Committed on 19/12/2017 at 22:11.
Pushed by dfaure into branch 'master'.

Fix dropping of emails onto favorites

Summary:
and dropping a collection to define a new favorite.

Test Plan:
Tested all three features, reordering, adding, and dropping a mail.

Two issues left:
- adding a new favourite at a specific position (patch pending
  for akonadi's favoritecollectionsmodel)
- the "+" when moving to reorder shouldn't appear, should be MoveAction only,
  don't know if that's possible here though.

Reviewers: dvratil, mlaurent, mkoller

Reviewed By: dvratil

Subscribers: #kde_pim

Tags: #kde_pim

Differential Revision: https://phabricator.kde.org/D9403

M  +0-10   src/folder/favoritecollectionorderproxymodel.cpp
M  +0-2src/folder/favoritecollectionorderproxymodel.h
M  +47   -9src/widgets/favoritecollectionwidget.cpp
M  +2-0src/widgets/favoritecollectionwidget.h

https://commits.kde.org/mailcommon/ace9cfb46008e4fcd2b973111fbc508110bbd9c9

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmail2] [Bug 379997] Always "Akonadi not started" overlay on reboot

2017-12-08 Thread David Faure
https://bugs.kde.org/show_bug.cgi?id=379997

David Faure <fa...@kde.org> changed:

   What|Removed |Added

 CC||fa...@kde.org
 Status|UNCONFIRMED |CONFIRMED
 Ever confirmed|0   |1
   Assignee|kdepim-bugs@kde.org |fa...@kde.org

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmail2] [Bug 376073] Rearrangement of favorites and inboxes not possible

2017-12-01 Thread David Faure
https://bugs.kde.org/show_bug.cgi?id=376073

David Faure <fa...@kde.org> changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|UNCONFIRMED |RESOLVED
   Version Fixed In||18.04
  Latest Commit||https://commits.kde.org/mai
   ||lcommon/381a28fa201488cea4a
   ||9d7a84f1cf8261d08e8c1

--- Comment #1 from David Faure <fa...@kde.org> ---
Git commit 381a28fa201488cea4a9d7a84f1cf8261d08e8c1 by David Faure.
Committed on 01/12/2017 at 12:52.
Pushed by dfaure into branch 'master'.

Implement reordering of favorite folders using DnD

Summary:
In order to separate favorites from the "entity order" QSFPM
used by the folder tree widget (it was always weird that filtering or
changing the sort order for the folder tree widget would affect favorites),
we need the favorites to get their own "ordering" proxy (otherwise
ordering is random, based on ETM population order). So while at it,
I implemented manual reordering of favorites.
FIXED-IN: 18.04

Test Plan:
I can reorder favorites (in listview mode) using DnD
and the order is persisted

Reviewers: dvratil, mlaurent

Reviewed By: mlaurent

Subscribers: #kde_pim

Tags: #kde_pim

Differential Revision: https://phabricator.kde.org/D8884

M  +3-0autotests/CMakeLists.txt
A  +131  -0autotests/favoritestest.cpp [License: LGPL (v2+)]
M  +2-0autotests/unittestenv/config.xml
M  +3-1src/CMakeLists.txt
A  +59   -0src/folder/favoritecollectionorderproxymodel.cpp [License:
GPL (v2)]
A  +47   -0src/folder/favoritecollectionorderproxymodel.h [License: GPL
(v2)]
M  +35   -0src/widgets/favoritecollectionwidget.cpp
M  +4-0src/widgets/favoritecollectionwidget.h

https://commits.kde.org/mailcommon/381a28fa201488cea4a9d7a84f1cf8261d08e8c1

-- 
You are receiving this mail because:
You are the assignee for the bug.

[korganizer] [Bug 328145] Changing just a date in todo's with the keyboard can't be applied

2017-11-19 Thread David Faure
https://bugs.kde.org/show_bug.cgi?id=328145

David Faure <fa...@kde.org> changed:

   What|Removed |Added

 CC||fa...@kde.org
 Resolution|--- |DUPLICATE
 Status|CONFIRMED   |RESOLVED

--- Comment #5 from David Faure <fa...@kde.org> ---


*** This bug has been marked as a duplicate of bug 364200 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[korganizer] [Bug 364200] korganizer 5.1.3 does not save change of appointment date.

2017-11-19 Thread David Faure
https://bugs.kde.org/show_bug.cgi?id=364200

David Faure <fa...@kde.org> changed:

   What|Removed |Added

   Assignee|kdepim-bugs@kde.org |fa...@kde.org
 CC||fa...@kde.org

--- Comment #1 from David Faure <fa...@kde.org> ---
Indeed, confirmed, and fixed. https://phabricator.kde.org/D8908

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmail2] [Bug 380182] deleting several messages doesn't remove them from the message list

2017-06-11 Thread David Faure
https://bugs.kde.org/show_bug.cgi?id=380182

David Faure <fa...@kde.org> changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|UNCONFIRMED |RESOLVED

--- Comment #8 from David Faure <fa...@kde.org> ---
Fix backported to
https://commits.kde.org/akonadi/2dc7fbf569ba3f7eeef98fb818d7af0820caf7a3.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmail2] [Bug 380182] deleting several messages doesn't remove them from the message list

2017-06-11 Thread David Faure
https://bugs.kde.org/show_bug.cgi?id=380182

David Faure <fa...@kde.org> changed:

   What|Removed |Added

 CC||fa...@kde.org,
   ||kol...@etm.at

--- Comment #5 from David Faure <fa...@kde.org> ---
The new if (with early return) from commit 2edac82af
(https://phabricator.kde.org/D5552, Martin Koller) is the reason for this bug.
When moving (not deleting) multiple messages from a folder (including moving to
trash, or archiving), the early return hits and the ETM doesn't notify of the
removal.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmail2] [Bug 377678] KMail header not showing attachment

2017-04-09 Thread David Faure
https://bugs.kde.org/show_bug.cgi?id=377678

David Faure <fa...@kde.org> changed:

   What|Removed |Added

 Resolution|--- |FIXED
   Version Fixed In||17.04
  Latest Commit||https://commits.kde.org/mes
   ||sagelib/37b992574c9c36e65fa
   ||38d241459b856900fe413
 Status|UNCONFIRMED |RESOLVED

--- Comment #2 from David Faure <fa...@kde.org> ---
Git commit 37b992574c9c36e65fa38d241459b856900fe413 by David Faure.
Committed on 09/04/2017 at 17:46.
Pushed by dfaure into branch 'Applications/17.04'.

Rework timing of script injection for showing attachments in message viewer.

It was sometimes executed too early, before the script that defines qt.jQuery.
FIXED-IN: 17.04

M  +11   -8messageviewer/src/viewer/viewer_p.cpp
M  +17   -10   messageviewer/src/viewer/webengine/mailwebenginescript.cpp
M  +0-9messageviewer/src/viewer/webengine/mailwebengineview.cpp
M  +0-1messageviewer/src/viewer/webengine/mailwebengineview.h
M  +2-2   
messageviewer/src/viewer/webengine/tests/testjquerysupportmailwebengine.js
M  +1-1webengineviewer/src/webenginepage.cpp
M  +1-3webengineviewer/src/webengineview.cpp

https://commits.kde.org/messagelib/37b992574c9c36e65fa38d241459b856900fe413

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmail2] [Bug 376589] Layout destroyed after clicking link with HiDPI

2017-04-04 Thread David Faure
https://bugs.kde.org/show_bug.cgi?id=376589

--- Comment #4 from David Faure <fa...@kde.org> ---
Note: if `kcmshell5 componentchooser` says the webbrowser is firefox, the bug
doesn't happen.
If OTOH it says "based on the contents of the URL" (i.e. KMail uses KIO), then
the bug happens.

That's a workaround for now, and an indication that something in KIO is
triggering it.

-- 
You are receiving this mail because:
You are the assignee for the bug.

  1   2   3   4   >