[Bug 293098] KAddressbook/Akonadi stores CATEGORIES escaped the wrong way
https://bugs.kde.org/show_bug.cgi?id=293098 Laurent Montel mon...@kde.org changed: What|Removed |Added CC||mon...@kde.org --- Comment #11 from Laurent Montel mon...@kde.org --- I confirm it. Will look at how to fix it. -- You are receiving this mail because: You are the assignee for the bug. ___ Kdepim-bugs mailing list Kdepim-bugs@kde.org https://mail.kde.org/mailman/listinfo/kdepim-bugs
[Bug 293098] KAddressbook/Akonadi stores CATEGORIES escaped the wrong way
https://bugs.kde.org/show_bug.cgi?id=293098 Laurent Montel mon...@kde.org changed: What|Removed |Added Status|REOPENED|RESOLVED Version Fixed In||4.8.5 Resolution|--- |FIXED Latest Commit||http://commits.kde.org/kdep ||imlibs/51a474722ee0d5b96e2e ||5593978bc5be3deef516 --- Comment #12 from Laurent Montel mon...@kde.org --- Git commit 51a474722ee0d5b96e2e5593978bc5be3deef516 by Montel Laurent. Committed on 29/06/2012 at 10:22. Pushed by mlaurent into branch 'master'. Fix Bug 293098 - KAddressbook/Akonadi stores CATEGORIES escaped the wrong way It was already escaped when we create category Not necessary to re-escapte it. FIXED-IN: 4.8.5 M +4-4kabc/vcardparser/vcardparser.cpp http://commits.kde.org/kdepimlibs/51a474722ee0d5b96e2e5593978bc5be3deef516 -- You are receiving this mail because: You are the assignee for the bug. ___ Kdepim-bugs mailing list Kdepim-bugs@kde.org https://mail.kde.org/mailman/listinfo/kdepim-bugs
[Bug 293098] KAddressbook/Akonadi stores CATEGORIES escaped the wrong way
https://bugs.kde.org/show_bug.cgi?id=293098 Laurent Montel mon...@kde.org changed: What|Removed |Added Latest Commit|http://commits.kde.org/kdep |http://commits.kde.org/kdep |imlibs/51a474722ee0d5b96e2e |imlibs/e2fe3f314d5ab5665e87 |5593978bc5be3deef516|e6e9b5b8ba268ada90f9 --- Comment #13 from Laurent Montel mon...@kde.org --- Git commit e2fe3f314d5ab5665e87e6e9b5b8ba268ada90f9 by Montel Laurent. Committed on 29/06/2012 at 10:22. Pushed by mlaurent into branch 'KDE/4.8'. Fix Bug 293098 - KAddressbook/Akonadi stores CATEGORIES escaped the wrong way It was already escaped when we create category Not necessary to re-escapte it. FIXED-IN: 4.8.5 (cherry picked from commit 51a474722ee0d5b96e2e5593978bc5be3deef516) M +4-4kabc/vcardparser/vcardparser.cpp http://commits.kde.org/kdepimlibs/e2fe3f314d5ab5665e87e6e9b5b8ba268ada90f9 -- You are receiving this mail because: You are the assignee for the bug. ___ Kdepim-bugs mailing list Kdepim-bugs@kde.org https://mail.kde.org/mailman/listinfo/kdepim-bugs
[Bug 293098] KAddressbook/Akonadi stores CATEGORIES escaped the wrong way
https://bugs.kde.org/show_bug.cgi?id=293098 Laurent Montel mon...@kde.org changed: What|Removed |Added Latest Commit|http://commits.kde.org/kdep |http://commits.kde.org/kdep |imlibs/e2fe3f314d5ab5665e87 |imlibs/688dc4c1c61cfc90308c |e6e9b5b8ba268ada90f9|25c4b5e9213d3263c8f4 --- Comment #14 from Laurent Montel mon...@kde.org --- Git commit 688dc4c1c61cfc90308c25c4b5e9213d3263c8f4 by Montel Laurent. Committed on 29/06/2012 at 10:22. Pushed by mlaurent into branch 'KDE/4.9'. Fix Bug 293098 - KAddressbook/Akonadi stores CATEGORIES escaped the wrong way It was already escaped when we create category Not necessary to re-escapte it. FIXED-IN: 4.8.5 (cherry picked from commit 51a474722ee0d5b96e2e5593978bc5be3deef516) M +4-4kabc/vcardparser/vcardparser.cpp http://commits.kde.org/kdepimlibs/688dc4c1c61cfc90308c25c4b5e9213d3263c8f4 -- You are receiving this mail because: You are the assignee for the bug. ___ Kdepim-bugs mailing list Kdepim-bugs@kde.org https://mail.kde.org/mailman/listinfo/kdepim-bugs
[Bug 293098] KAddressbook/Akonadi stores CATEGORIES escaped the wrong way
https://bugs.kde.org/show_bug.cgi?id=293098 --- Comment #15 from Ingo Ratsdorf i...@envirology.co.nz --- Supercool! If that solved the issue, that would be fantastic. Thanks! -- You are receiving this mail because: You are the assignee for the bug. ___ Kdepim-bugs mailing list Kdepim-bugs@kde.org https://mail.kde.org/mailman/listinfo/kdepim-bugs
[Bug 293098] KAddressbook/Akonadi stores CATEGORIES escaped the wrong way
https://bugs.kde.org/show_bug.cgi?id=293098 --- Comment #16 from Laurent Montel mon...@kde.org --- For me it's ok now. Please test it:) -- You are receiving this mail because: You are the assignee for the bug. ___ Kdepim-bugs mailing list Kdepim-bugs@kde.org https://mail.kde.org/mailman/listinfo/kdepim-bugs
[Bug 293098] KAddressbook/Akonadi stores CATEGORIES escaped the wrong way
https://bugs.kde.org/show_bug.cgi?id=293098 --- Comment #9 from Ingo Ratsdorf i...@envirology.co.nz --- Hard to believe that nobody else is bothered by this bug and that no one seems to put any effort into fixing it. Is anybody reading this out there? If the source code would be better documented or I could actually FIND the files, I could hunt for myself! Disappointing really! -- You are receiving this mail because: You are the assignee for the bug. ___ Kdepim-bugs mailing list Kdepim-bugs@kde.org https://mail.kde.org/mailman/listinfo/kdepim-bugs
[Bug 293098] KAddressbook/Akonadi stores CATEGORIES escaped the wrong way
https://bugs.kde.org/show_bug.cgi?id=293098 --- Comment #10 from Andreas Dick and...@gmx.ch --- I agree! thanks so far... Andreas Am Dienstag, 26. Juni 2012, 19.11:13 schrieben Sie: https://bugs.kde.org/show_bug.cgi?id=293098 --- Comment #9 from Ingo Ratsdorf i...@envirology.co.nz --- Hard to believe that nobody else is bothered by this bug and that no one seems to put any effort into fixing it. Is anybody reading this out there? If the source code would be better documented or I could actually FIND the files, I could hunt for myself! Disappointing really! -- You are receiving this mail because: You are the assignee for the bug. ___ Kdepim-bugs mailing list Kdepim-bugs@kde.org https://mail.kde.org/mailman/listinfo/kdepim-bugs
[Bug 293098] KAddressbook/Akonadi stores CATEGORIES escaped the wrong way
https://bugs.kde.org/show_bug.cgi?id=293098 --- Comment #3 from Ingo Ratsdorf i...@envirology.co.nz --- This is a bug in the underlaying iCal library. Anybody working on this one? -- You are receiving this mail because: You are the assignee for the bug. ___ Kdepim-bugs mailing list Kdepim-bugs@kde.org https://mail.kde.org/mailman/listinfo/kdepim-bugs
[Bug 293098] KAddressbook/Akonadi stores CATEGORIES escaped the wrong way
https://bugs.kde.org/show_bug.cgi?id=293098 Ingo Ratsdorf i...@envirology.co.nz changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |UPSTREAM --- Comment #4 from Ingo Ratsdorf i...@envirology.co.nz --- After upgrading to 4.8.3, the bug seems to be resolved. -- You are receiving this mail because: You are the assignee for the bug. ___ Kdepim-bugs mailing list Kdepim-bugs@kde.org https://mail.kde.org/mailman/listinfo/kdepim-bugs
[Bug 293098] KAddressbook/Akonadi stores CATEGORIES escaped the wrong way
https://bugs.kde.org/show_bug.cgi?id=293098 Andreas Dick and...@gmx.ch changed: What|Removed |Added CC||and...@gmx.ch --- Comment #5 from Andreas Dick and...@gmx.ch --- Hei Ingo how did you have tested this? I have just installed 4.8.3 on my Kubuntu 12.4 then I created just a simple addressbook (as plain file) then I exported a dummy contact to as VCARD 3.0: -- BEGIN:VCARD CATEGORIES:Friends\,Familie FN:Blabla N:Blabla UID:z3HxtI38VK VERSION:3.0 END:VCARD --- thus, the group seperator is still wrong for me: \, Using the GroupDAV connector with SabreDAV is doing the same, but testing with the vcf3.0 export is a faster check Andreas -- You are receiving this mail because: You are the assignee for the bug. ___ Kdepim-bugs mailing list Kdepim-bugs@kde.org https://mail.kde.org/mailman/listinfo/kdepim-bugs
[Bug 293098] KAddressbook/Akonadi stores CATEGORIES escaped the wrong way
https://bugs.kde.org/show_bug.cgi?id=293098 --- Comment #6 from Ingo Ratsdorf i...@envirology.co.nz --- Hmm, strange. I did a sync via CardDAV using the groupdav resource and traced conversation using WireShark. And all was fine, only commas ,, without the backslashes \,... So sync was perfect. Is the akonadi groupdav resource maybe changing the encoding before it sends it? And KAddressbook is using the original iCal library to export? Remember the export is not done by Akonadi or it's resources... -- You are receiving this mail because: You are the assignee for the bug. ___ Kdepim-bugs mailing list Kdepim-bugs@kde.org https://mail.kde.org/mailman/listinfo/kdepim-bugs
[Bug 293098] KAddressbook/Akonadi stores CATEGORIES escaped the wrong way
https://bugs.kde.org/show_bug.cgi?id=293098 Ingo Ratsdorf i...@envirology.co.nz changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|UPSTREAM|--- --- Comment #7 from Ingo Ratsdorf i...@envirology.co.nz --- Sorry, my wrong. KOrganiser does sync calendar CATEGORIES now correctly, but KAddressbook is still doing it wrong. And it still does not sync or export FBURL. Strange bug. It stores it incorrectly in Akonadi, so I guess it's not a bug in KAddressbook but in one of the underlaying libs. One of the bugs in KAddressbook re birthday display has recently been resolved. I'll dig a bit in the git repos to find the origin. -- You are receiving this mail because: You are the assignee for the bug. ___ Kdepim-bugs mailing list Kdepim-bugs@kde.org https://mail.kde.org/mailman/listinfo/kdepim-bugs
[Bug 293098] KAddressbook/Akonadi stores CATEGORIES escaped the wrong way
https://bugs.kde.org/show_bug.cgi?id=293098
--- Comment #8 from Ingo Ratsdorf i...@envirology.co.nz ---
vcardtool assumes that categories are stored in a QStringList:
creating VCard data
142if ( version == VCard::v3_0 ) {
143 QStringList categories = (*addrIt).categories();
144 QStringList::Iterator catIt;
145 for ( catIt = categories.begin(); catIt != categories.end();
++catIt ) {
146(*catIt).replace( QLatin1Char( ',' ), QLatin1String( \\, ) );
147 }
148
149 VCardLine catLine( QLatin1String( CATEGORIES ), categories.join(
QLatin1String( , ) ) );
150 card.addLine( catLine );
151}
The code seems to be okay. It replaces all commas within each string (category)
with '\,' which is correct.
It then joins it all together using plain ','.
This is according to RFC
parsing VCard Data
364 static const QLatin1Char commaSep( ',' );
428else if ( identifier == QLatin1String( categories ) ) {
429 const QStringList categories = splitString( commaSep,
(*lineIt).value().toString() );
430 addr.setCategories( categories );
431}
Addr is apparently defined in kabc/addressee.cpp, however I cannot find that
file!!!
=
ASSUMPTION: KAddressbook or underlaying packages are not using QStringlist but
store one single CATEGORIES string in QStringlist,
hence all commas within are replaced.
Does that make sense to anyone?
--
You are receiving this mail because:
You are the assignee for the bug.
___
Kdepim-bugs mailing list
Kdepim-bugs@kde.org
https://mail.kde.org/mailman/listinfo/kdepim-bugs
[Bug 293098] KAddressbook/Akonadi stores CATEGORIES escaped the wrong way
https://bugs.kde.org/show_bug.cgi?id=293098 Heiner Markert mephi...@gmx.net changed: What|Removed |Added CC||mephi...@gmx.net --- Comment #2 from Heiner Markert mephi...@gmx.net --- I am also experiencing this bug. Also exported vCard 3.0 files are broken. This bug can already be seen in Kontact from KDE 3.5.10 (with export to vCard, DAV was not supported at that time), so it seems to be a pretty old defect... -- You are receiving this mail because: You are the assignee for the bug. ___ Kdepim-bugs mailing list Kdepim-bugs@kde.org https://mail.kde.org/mailman/listinfo/kdepim-bugs
[Bug 293098] KAddressbook/Akonadi stores CATEGORIES escaped the wrong way
https://bugs.kde.org/show_bug.cgi?id=293098 Dean Cording d...@cording.id.au changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever Confirmed|0 |1 --- Comment #1 from Dean Cording dean cording id au 2012-02-09 13:48:58 --- *** This bug has been confirmed by popular vote. *** -- Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Kdepim-bugs mailing list Kdepim-bugs@kde.org https://mail.kde.org/mailman/listinfo/kdepim-bugs
[Bug 293098] KAddressbook/Akonadi stores CATEGORIES escaped the wrong way
https://bugs.kde.org/show_bug.cgi?id=293098 Evert Pot ev...@rooftopsolutions.nl changed: What|Removed |Added CC||ev...@rooftopsolutions.nl -- Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Kdepim-bugs mailing list Kdepim-bugs@kde.org https://mail.kde.org/mailman/listinfo/kdepim-bugs
