[kontact] [Bug 327865] Endless fetch loop with favorite collections

2013-12-19 Thread Christian Mollekopf
https://bugs.kde.org/show_bug.cgi?id=327865 --- Comment #10 from Christian Mollekopf mollek...@kolabsys.com --- I'm tracking the layoutChanged signal problem here: https://bugs.kde.org/show_bug.cgi?id=329004 It's in fact an optimization to not issue layoutChanged IMO, meaning we just can't rely

[kontact] [Bug 327865] Endless fetch loop with favorite collections

2013-12-18 Thread Christian Mollekopf
https://bugs.kde.org/show_bug.cgi?id=327865 --- Comment #8 from Christian Mollekopf mollek...@kolabsys.com --- A layoutChanged signal comes from the modelstack in kmail foldertreewidget: EntityCollectionOrderProxyModel - expands a dataChanged signal to layoutChanged FolderTreeWidgetProxyModel

[kontact] [Bug 327865] Endless fetch loop with favorite collections

2013-12-18 Thread Christian Mollekopf
https://bugs.kde.org/show_bug.cgi?id=327865 --- Comment #9 from Christian Mollekopf mollek...@kolabsys.com --- The reason why everything gets dereferenced to zero, is because the FavortiteCollectionsModel sits on top of the EntityCollectionOrderProxyModel just like the other SelectionProxyModels

[kontact] [Bug 327865] Endless fetch loop with favorite collections

2013-12-02 Thread Christian Mollekopf
https://bugs.kde.org/show_bug.cgi?id=327865 Christian Mollekopf mollek...@kolabsys.com changed: What|Removed |Added Status|UNCONFIRMED |CONFIRMED Ever

[kontact] [Bug 327865] Endless fetch loop with favorite collections

2013-11-21 Thread Christian Mollekopf
https://bugs.kde.org/show_bug.cgi?id=327865 --- Comment #3 from Christian Mollekopf mollek...@kolabsys.com --- (In reply to comment #2) Could be fixed by this [0] patch, not sure whether it is still valid after Christian's changes though (or whether it was ever valid at all ;-) [0]

[kontact] [Bug 327865] Endless fetch loop with favorite collections

2013-11-21 Thread Christian Mollekopf
https://bugs.kde.org/show_bug.cgi?id=327865 --- Comment #4 from Christian Mollekopf mollek...@kolabsys.com --- This is what we get when selecting a new collection without any dataChanged signals: kmail2(25459)/libakonadi Akonadi::EntityTreeModelPrivate::deref: 659 kmail2(25459)/libakonadi

[kontact] [Bug 327865] Endless fetch loop with favorite collections

2013-11-21 Thread Christian Mollekopf
https://bugs.kde.org/show_bug.cgi?id=327865 --- Comment #5 from Christian Mollekopf mollek...@kolabsys.com --- And this is what happens with dataChanged signals: kmail2(27586)/libakonadi Akonadi::EntityTreeModelPrivate::monitoredItemChanged:

[kontact] [Bug 327865] Endless fetch loop with favorite collections

2013-11-21 Thread Christian Mollekopf
https://bugs.kde.org/show_bug.cgi?id=327865 --- Comment #6 from Christian Mollekopf mollek...@kolabsys.com --- After some more research it looks like it's not the KSelectionProxyModel that breaks the refcounting. If all favorite folders are removed the referencing works as expected, with always

[kontact] [Bug 327865] Endless fetch loop with favorite collections

2013-11-20 Thread Rex Dieter
https://bugs.kde.org/show_bug.cgi?id=327865 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added CC||rdie...@math.unl.edu -- You

[kontact] [Bug 327865] Endless fetch loop with favorite collections

2013-11-20 Thread Christian Mollekopf
https://bugs.kde.org/show_bug.cgi?id=327865 --- Comment #1 from Christian Mollekopf mollek...@kolabsys.com --- Two problems is probably that an itemFetch shouldn't trigger dataChanged for the parent collection (we have rowsAboutToBeInserted signals for that). There may be more problems though.

[kontact] [Bug 327865] Endless fetch loop with favorite collections

2013-11-20 Thread Daniel Vrátil
https://bugs.kde.org/show_bug.cgi?id=327865 Daniel Vrátil dvra...@redhat.com changed: What|Removed |Added CC||dvra...@redhat.com ---