Re: [OS-BUILD PATCH 0/3] redhat/configs/evaluate_configs: Add find dead configs option

2021-11-16 Thread Don Zickus (via Email Bridge)
From: Don Zickus on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1498#note_735095272 @prarit - thanks! /me mumbles something about ark commit id? then runs... ___ kernel mailing list -- kernel@lists.fedoraproject.org To

Re: [OS-BUILD PATCH 0/3] redhat/configs/evaluate_configs: Add find dead configs option

2021-11-16 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1498#note_735002771 Sorry about that, put that into the "why aren't you thinking what I'm thinking" basket. I've updated the description on the 3rd commit. I looked at separating things out and it

Re: [OS-BUILD PATCH 0/3] redhat/configs/evaluate_configs: Add find dead configs option

2021-11-15 Thread Jarod Wilson (via Email Bridge)
From: Jarod Wilson on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1498#note_733805832 Fair point. :) ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org

Re: [OS-BUILD PATCH 0/3] redhat/configs/evaluate_configs: Add find dead configs option

2021-11-15 Thread Don Zickus (via Email Bridge)
From: Don Zickus on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1498#note_733799374 @jwilsonrh - thanks for the explaination. But I shouldn't have to engage in dialog to figure that out. :-) @prarit - can you beef up the commit log to explain why those new configs are

Re: [OS-BUILD PATCH 0/3] redhat/configs/evaluate_configs: Add find dead configs option

2021-11-15 Thread Jarod Wilson (via Email Bridge)
From: Jarod Wilson on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1498#note_733797260 I've attempted to comment on the overall diff, but I keep getting a "failed to save comment" message from gitlab, so... Here's one of the two "added" files from the overall, in snipped

Re: [OS-BUILD PATCH 0/3] redhat/configs/evaluate_configs: Add find dead configs option

2021-11-15 Thread Jarod Wilson (via Email Bridge)
From: Jarod Wilson on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1498#note_733793141 Oh, ha, I didn't look at the individual commits, just the overall. Looking at the overall, those two additions are because they were named incorrectly and removed by the initial pass,

Re: [OS-BUILD PATCH 0/3] redhat/configs/evaluate_configs: Add find dead configs option

2021-11-15 Thread Don Zickus (via Email Bridge)
From: Don Zickus on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1498#note_733792189 @jwilsonrh Look at the third commit. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to

Re: [OS-BUILD PATCH 0/3] redhat/configs/evaluate_configs: Add find dead configs option

2021-11-15 Thread Jarod Wilson (via Email Bridge)
From: Jarod Wilson on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1498#note_733746242 Which ones are added? I see two files moved/renamed, because the actual config option name changed, and only the contents of the file were updated, while the file name wasn't. Those

Re: [OS-BUILD PATCH 0/3] redhat/configs/evaluate_configs: Add find dead configs option

2021-11-15 Thread Don Zickus (via Email Bridge)
From: Don Zickus on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1498#note_733447538 @prarit - why are you *adding* 2 new configs, when all you did is delete dead configs? ___ kernel mailing list --

Re: [OS-BUILD PATCH 0/3] redhat/configs/evaluate_configs: Add find dead configs option

2021-11-13 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1498#note_732549529 Just a note on testing. I did: ``` make rh-configs cp configs/*.config /tmp/old_rh_configs make fedora-configs cp configs/*.config /tmp/old_fedora_configs make rh-configs cp

[OS-BUILD PATCH 0/3] redhat/configs/evaluate_configs: Add find dead configs option

2021-11-13 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1498 The kernel's CONFIG entries are under a constant state of change. New CONFIG entries are added and removed every upstream release. In kernel-ark we track CONFIG values with unique