Re: [OS-BUILD PATCH 0/5] configs: Add include_rhel and include_fedora to kernel.spec

2021-09-30 Thread Justin M. Forbes (via Email Bridge)
From: Justin M. Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1413#note_691410712 Acked-by: Justin M. Forbes (via approve button) ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email

Re: [OS-BUILD PATCH 0/5] configs: Add include_rhel and include_fedora to kernel.spec

2021-09-29 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1413#note_690565580 Okay based on that I'm resolving the thread. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to

Re: [OS-BUILD PATCH 0/5] configs: Add include_rhel and include_fedora to kernel.spec

2021-09-29 Thread Herton R. Krzesinski (via Email Bridge)
From: Herton R. Krzesinski on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1413#note_690503573 Acked-by: Herton R. Krzesinski (via approve button) ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an

Re: [OS-BUILD PATCH 0/5] configs: Add include_rhel and include_fedora to kernel.spec

2021-09-29 Thread Herton R. Krzesinski (via Email Bridge)
From: Herton R. Krzesinski on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1413#note_690502948 So the question here is if when we do the kernel-ark sync to centos/rhel dist- git next time, will we set INCLUDE_FEDORA_FILES to 0? I believe not, so from that use case we are

Re: [OS-BUILD PATCH 0/5] configs: Add include_rhel and include_fedora to kernel.spec

2021-09-29 Thread Herton R. Krzesinski (via Email Bridge)
From: Herton R. Krzesinski on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1413#note_690495733 No, because there is a window in the future where we will use again kernel-ark to sync to dist-git (in next centos stream/rhel major version), and then we will still have fedora

Re: [OS-BUILD PATCH 0/5] configs: Add include_rhel and include_fedora to kernel.spec

2021-09-29 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1413#note_690443819 Good point @hertonrk-rh. My plan is to remove the fedora_files, configs/fedora, priority.fedora, and update flavors in RHEL & centos-stream. Would that solve your concerns?

Re: [OS-BUILD PATCH 0/5] configs: Add include_rhel and include_fedora to kernel.spec

2021-09-29 Thread Herton R. Krzesinski (via Email Bridge)
From: Herton R. Krzesinski on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1413#note_690416057 I think this need an additional change on top: If INCLUDE_FEDORA_FILES is disabled, you don't need to copy ```fedora_files/*```. The same with INCLUDE_RHEL_FILES. It is harmless

Re: [OS-BUILD PATCH 0/5] configs: Add include_rhel and include_fedora to kernel.spec

2021-09-29 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1413#note_690382344 Fixed :) ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org

[OS-BUILD PATCH 0/5] configs: Add include_rhel and include_fedora to kernel.spec

2021-09-29 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1413 The centos-stream-9 (c9s) [1] repository contains files for both RHEL and Fedora configs. The Fedora configs will never be updated, and will quickly be out-of-date with respect to